From: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 1/3] cgroup: fix mount failure in a corner case
Date: Mon, 30 Jun 2014 09:41:22 +0800 [thread overview]
Message-ID: <53B0C042.9030206@huawei.com> (raw)
In-Reply-To: <20140628115743.GB10829-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
On 2014/6/28 19:58, Tejun Heo wrote:
> Hello, Li.
>
> On Fri, Jun 27, 2014 at 05:13:12PM +0800, Li Zefan wrote:
>> + for_each_subsys(ss, i) {
>> + if (!(opts.subsys_mask & (1 << i)) ||
>> + ss->root == &cgrp_dfl_root)
>> + continue;
>> +
>> + if (!percpu_ref_tryget_live(&ss->root->cgrp.self.refcnt)) {
>> + mutex_unlock(&cgroup_mutex);
>> + msleep(10);
>> + ret = restart_syscall();
>> + goto out_free;
>> + }
>
> Why not just put it immediately? We know that it's not gonna be
> destroyed while holding cgroup_mutex. It may look a bit weird but
> this is a pretty special case anyway and deferring put doesn't buy
> anything.
>
Yeah, this is better. :)
WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] cgroup: fix mount failure in a corner case
Date: Mon, 30 Jun 2014 09:41:22 +0800 [thread overview]
Message-ID: <53B0C042.9030206@huawei.com> (raw)
In-Reply-To: <20140628115743.GB10829@htj.dyndns.org>
On 2014/6/28 19:58, Tejun Heo wrote:
> Hello, Li.
>
> On Fri, Jun 27, 2014 at 05:13:12PM +0800, Li Zefan wrote:
>> + for_each_subsys(ss, i) {
>> + if (!(opts.subsys_mask & (1 << i)) ||
>> + ss->root == &cgrp_dfl_root)
>> + continue;
>> +
>> + if (!percpu_ref_tryget_live(&ss->root->cgrp.self.refcnt)) {
>> + mutex_unlock(&cgroup_mutex);
>> + msleep(10);
>> + ret = restart_syscall();
>> + goto out_free;
>> + }
>
> Why not just put it immediately? We know that it's not gonna be
> destroyed while holding cgroup_mutex. It may look a bit weird but
> this is a pretty special case anyway and deferring put doesn't buy
> anything.
>
Yeah, this is better. :)
next prev parent reply other threads:[~2014-06-30 1:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 7:10 [PATCH v2 1/3] cgroup: fix mount failure in a corner case Li Zefan
2014-06-27 7:10 ` Li Zefan
2014-06-27 7:10 ` [PATCH v2 2/3] kernfs: introduce kernfs_pin_sb() Li Zefan
[not found] ` <53AD18F8.4050501-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-06-27 15:01 ` Tejun Heo
2014-06-27 15:01 ` Tejun Heo
[not found] ` <20140627150141.GB4044-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-06-27 17:48 ` Greg Kroah-Hartman
2014-06-27 17:48 ` Greg Kroah-Hartman
[not found] ` <53AD18D0.3090100-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-06-27 7:11 ` [PATCH v2 3/3] cgroup: fix a race between cgroup_mount() and cgroup_kill_sb() Li Zefan
2014-06-27 7:11 ` Li Zefan
2014-06-27 8:16 ` [PATCH v2 1/3] cgroup: fix mount failure in a corner case Li Zefan
[not found] ` <53AD2852.2060304-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-06-27 9:13 ` Li Zefan
2014-06-27 9:13 ` Li Zefan
[not found] ` <53AD35A8.7030908-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-06-28 11:58 ` Tejun Heo
2014-06-28 11:58 ` Tejun Heo
[not found] ` <20140628115743.GB10829-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-06-30 1:41 ` Li Zefan [this message]
2014-06-30 1:41 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B0C042.9030206@huawei.com \
--to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.