* [PATCH v2 1/5] ARM: dts: exynos4: add port sub-nodes to exynos usb host modules
2014-06-25 13:26 [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support Marek Szyprowski
@ 2014-06-25 13:26 ` Marek Szyprowski
2014-06-25 13:26 ` [PATCH v2 2/5] ARM: dts: exynos4412-odroidx: enable common hardware blocks Marek Szyprowski
` (4 subsequent siblings)
5 siblings, 0 replies; 19+ messages in thread
From: Marek Szyprowski @ 2014-06-25 13:26 UTC (permalink / raw)
To: linux-samsung-soc
Cc: Marek Szyprowski, Kukjin Kim, Kamil Debski, Sylwester Nawrocki,
Tobias Jakobi, Daniel Drake
This patch adds port sub-nodes to exynos4 ehci and ohci modules, which
are required by recently merged new exynos4 usb2 phy support.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/boot/dts/exynos4.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index b8ece4be41ca..c91284441694 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -322,6 +322,23 @@
clocks = <&clock CLK_USB_HOST>;
clock-names = "usbhost";
status = "disabled";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ phys = <&exynos_usbphy 1>;
+ status = "disabled";
+ };
+ port@1 {
+ reg = <1>;
+ phys = <&exynos_usbphy 2>;
+ status = "disabled";
+ };
+ port@2 {
+ reg = <2>;
+ phys = <&exynos_usbphy 3>;
+ status = "disabled";
+ };
};
ohci@12590000 {
@@ -331,6 +348,13 @@
clocks = <&clock CLK_USB_HOST>;
clock-names = "usbhost";
status = "disabled";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ phys = <&exynos_usbphy 1>;
+ status = "disabled";
+ };
};
i2s1: i2s@13960000 {
--
1.9.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH v2 2/5] ARM: dts: exynos4412-odroidx: enable common hardware blocks
2014-06-25 13:26 [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support Marek Szyprowski
2014-06-25 13:26 ` [PATCH v2 1/5] ARM: dts: exynos4: add port sub-nodes to exynos usb host modules Marek Szyprowski
@ 2014-06-25 13:26 ` Marek Szyprowski
2014-06-25 13:26 ` [PATCH v2 3/5] ARM: dts: exynos4412-odroidx: add support for USB (phy, host, device) Marek Szyprowski
` (3 subsequent siblings)
5 siblings, 0 replies; 19+ messages in thread
From: Marek Szyprowski @ 2014-06-25 13:26 UTC (permalink / raw)
To: linux-samsung-soc
Cc: Marek Szyprowski, Kukjin Kim, Kamil Debski, Sylwester Nawrocki,
Tobias Jakobi, Daniel Drake
This patch adds support for common hardware modules available on all
Exynos4412-based Odroid boards, which already have complete support in
mainline kernel. This includes secure firmware calls, watchdog, g2d and
fimc (mem2mem) multimedia accelerators.
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/boot/dts/exynos4412-odroidx.dts | 35 ++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index 31db28a4bb33..fda9ac23dd55 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -22,6 +22,11 @@
reg = <0x40000000 0x40000000>;
};
+ firmware@0204F000 {
+ compatible = "samsung,secure-firmware";
+ reg = <0x0204F000 0x1000>;
+ };
+
leds {
compatible = "gpio-leds";
led1 {
@@ -68,10 +73,40 @@
regulator-boot-on;
};
+ watchdog@10060000 {
+ status = "okay";
+ };
+
rtc@10070000 {
status = "okay";
};
+ g2d@10800000 {
+ status = "okay";
+ };
+
+ camera {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <>;
+
+ fimc_0: fimc@11800000 {
+ status = "okay";
+ };
+
+ fimc_1: fimc@11810000 {
+ status = "okay";
+ };
+
+ fimc_2: fimc@11820000 {
+ status = "okay";
+ };
+
+ fimc_3: fimc@11830000 {
+ status = "okay";
+ };
+ };
+
sdhci@12530000 {
bus-width = <4>;
pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
--
1.9.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH v2 3/5] ARM: dts: exynos4412-odroidx: add support for USB (phy, host, device)
2014-06-25 13:26 [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support Marek Szyprowski
2014-06-25 13:26 ` [PATCH v2 1/5] ARM: dts: exynos4: add port sub-nodes to exynos usb host modules Marek Szyprowski
2014-06-25 13:26 ` [PATCH v2 2/5] ARM: dts: exynos4412-odroidx: enable common hardware blocks Marek Szyprowski
@ 2014-06-25 13:26 ` Marek Szyprowski
2014-06-25 13:58 ` Vivek Gautam
2014-06-25 13:26 ` [PATCH v2 4/5] ARM: dts: refactor Odroid DTS file and add support for Odroid X2 and U2/U3 Marek Szyprowski
` (2 subsequent siblings)
5 siblings, 1 reply; 19+ messages in thread
From: Marek Szyprowski @ 2014-06-25 13:26 UTC (permalink / raw)
To: linux-samsung-soc
Cc: Marek Szyprowski, Kukjin Kim, Kamil Debski, Sylwester Nawrocki,
Tobias Jakobi, Daniel Drake
From: Kamil Debski <k.debski@samsung.com>
This patch adds basic support for USB modules (host and device) on
OdroidX board.
Signed-off-by: Kamil Debski <k.debski@samsung.com>
[removed incorrect port@2 node]
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/boot/dts/exynos4412-odroidx.dts | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index fda9ac23dd55..4c853fbf7202 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -148,6 +148,16 @@
pinctrl-names = "default";
status = "okay";
+ usb3503@08 {
+ compatible = "smsc,usb3503";
+ reg = <0x08>;
+
+ intn-gpios = <&gpx3 0 0>;
+ connect-gpios = <&gpx3 4 0>;
+ reset-gpios = <&gpx3 5 0>;
+ initial-mode = <1>;
+ };
+
max77686: pmic@09 {
compatible = "maxim,max77686";
reg = <0x09>;
@@ -338,4 +348,21 @@
};
};
};
+
+ exynos-usbphy@125B0000 {
+ status = "okay";
+ };
+
+ hsotg@12480000 {
+ status = "okay";
+ vusb_d-supply = <&ldo15_reg>;
+ vusb_a-supply = <&ldo12_reg>;
+ };
+
+ ehci@12580000 {
+ status = "okay";
+ port@1 {
+ status = "okay";
+ };
+ };
};
--
1.9.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v2 3/5] ARM: dts: exynos4412-odroidx: add support for USB (phy, host, device)
2014-06-25 13:26 ` [PATCH v2 3/5] ARM: dts: exynos4412-odroidx: add support for USB (phy, host, device) Marek Szyprowski
@ 2014-06-25 13:58 ` Vivek Gautam
2014-06-26 6:07 ` Marek Szyprowski
0 siblings, 1 reply; 19+ messages in thread
From: Vivek Gautam @ 2014-06-25 13:58 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim, Kamil Debski,
Sylwester Nawrocki, Tobias Jakobi, Daniel Drake
On Wed, Jun 25, 2014 at 6:56 PM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> From: Kamil Debski <k.debski@samsung.com>
>
> This patch adds basic support for USB modules (host and device) on
> OdroidX board.
>
> Signed-off-by: Kamil Debski <k.debski@samsung.com>
> [removed incorrect port@2 node]
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/boot/dts/exynos4412-odroidx.dts | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
> index fda9ac23dd55..4c853fbf7202 100644
> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
> @@ -148,6 +148,16 @@
> pinctrl-names = "default";
> status = "okay";
>
> + usb3503@08 {
> + compatible = "smsc,usb3503";
> + reg = <0x08>;
> +
> + intn-gpios = <&gpx3 0 0>;
> + connect-gpios = <&gpx3 4 0>;
> + reset-gpios = <&gpx3 5 0>;
> + initial-mode = <1>;
> + };
> +
> max77686: pmic@09 {
> compatible = "maxim,max77686";
> reg = <0x09>;
> @@ -338,4 +348,21 @@
> };
> };
> };
> +
> + exynos-usbphy@125B0000 {
> + status = "okay";
> + };
> +
> + hsotg@12480000 {
> + status = "okay";
> + vusb_d-supply = <&ldo15_reg>;
> + vusb_a-supply = <&ldo12_reg>;
Can you please point me to the documentation for these two properties
in the DT bindings ?
Which tree i should grep to find that ?
We have similar supplies for ehci/ohci and other host controllers too,
so just wondering
if we can use similar nomenclature for hsotg as well as host.
I have posted driver side patches for host (with DT documentation) a
while back :
https://lkml.org/lkml/2014/6/25/363
[snip]
--
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH v2 3/5] ARM: dts: exynos4412-odroidx: add support for USB (phy, host, device)
2014-06-25 13:58 ` Vivek Gautam
@ 2014-06-26 6:07 ` Marek Szyprowski
0 siblings, 0 replies; 19+ messages in thread
From: Marek Szyprowski @ 2014-06-26 6:07 UTC (permalink / raw)
To: Vivek Gautam
Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim, Kamil Debski,
Sylwester Nawrocki, Tobias Jakobi, Daniel Drake
Hello,
On 2014-06-25 15:58, Vivek Gautam wrote:
> On Wed, Jun 25, 2014 at 6:56 PM, Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> From: Kamil Debski <k.debski@samsung.com>
>>
>> This patch adds basic support for USB modules (host and device) on
>> OdroidX board.
>>
>> Signed-off-by: Kamil Debski <k.debski@samsung.com>
>> [removed incorrect port@2 node]
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> arch/arm/boot/dts/exynos4412-odroidx.dts | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> index fda9ac23dd55..4c853fbf7202 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
>> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> @@ -148,6 +148,16 @@
>> pinctrl-names = "default";
>> status = "okay";
>>
>> + usb3503@08 {
>> + compatible = "smsc,usb3503";
>> + reg = <0x08>;
>> +
>> + intn-gpios = <&gpx3 0 0>;
>> + connect-gpios = <&gpx3 4 0>;
>> + reset-gpios = <&gpx3 5 0>;
>> + initial-mode = <1>;
>> + };
>> +
>> max77686: pmic@09 {
>> compatible = "maxim,max77686";
>> reg = <0x09>;
>> @@ -338,4 +348,21 @@
>> };
>> };
>> };
>> +
>> + exynos-usbphy@125B0000 {
>> + status = "okay";
>> + };
>> +
>> + hsotg@12480000 {
>> + status = "okay";
>> + vusb_d-supply = <&ldo15_reg>;
>> + vusb_a-supply = <&ldo12_reg>;
> Can you please point me to the documentation for these two properties
> in the DT bindings ?
Documentation/devicetree/bindings/usb/samsung-hsotg.txt:
- vusb_d-supply: phandle to voltage regulator of digital section,
- vusb_a-supply: phandle to voltage regulator of analog section.
> Which tree i should grep to find that ?
Support for vusb_d and vusb_a regulators is already in s3c-hsotg driver
(now a part of dwc2/gadget driver) since v3.5.
> We have similar supplies for ehci/ohci and other host controllers too,
> so just wondering
> if we can use similar nomenclature for hsotg as well as host.
>
> I have posted driver side patches for host (with DT documentation) a
> while back :
> https://lkml.org/lkml/2014/6/25/363
Ok, I will take a look into your patches, but I'm not sure if it makes
sense to change the s3c-hsotg bindings now.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v2 4/5] ARM: dts: refactor Odroid DTS file and add support for Odroid X2 and U2/U3
2014-06-25 13:26 [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support Marek Szyprowski
` (2 preceding siblings ...)
2014-06-25 13:26 ` [PATCH v2 3/5] ARM: dts: exynos4412-odroidx: add support for USB (phy, host, device) Marek Szyprowski
@ 2014-06-25 13:26 ` Marek Szyprowski
2014-06-25 13:26 ` [PATCH v2 5/5] ARM: dts: exynos4412-odroid-common: disable 'always on' for BUCK8 regulator Marek Szyprowski
2014-06-30 5:34 ` [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support Marek Szyprowski
5 siblings, 0 replies; 19+ messages in thread
From: Marek Szyprowski @ 2014-06-25 13:26 UTC (permalink / raw)
To: linux-samsung-soc
Cc: Marek Szyprowski, Kukjin Kim, Kamil Debski, Sylwester Nawrocki,
Tobias Jakobi, Daniel Drake
This patch moves some parts of exynos4412-odroidx.dts to common
exynos4412-odroid-common.dtsi file and adds support for Odroid X2 and
U2/U3 boards. X2 is same as X, but it has faster SoC module (1.7GHz
instead of 1.4GHz), while U2/U3 differs from X2 by different way of
routing signals to host USB hub. It also lacks some hw modules not yet
supported by those dts files (i.e. LCD & touch panel).
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/boot/dts/Makefile | 2 +
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 319 +++++++++++++++++++++++
arch/arm/boot/dts/exynos4412-odroidu3.dts | 49 ++++
arch/arm/boot/dts/exynos4412-odroidx.dts | 326 +-----------------------
arch/arm/boot/dts/exynos4412-odroidx2.dts | 23 ++
5 files changed, 404 insertions(+), 315 deletions(-)
create mode 100644 arch/arm/boot/dts/exynos4412-odroid-common.dtsi
create mode 100644 arch/arm/boot/dts/exynos4412-odroidu3.dts
create mode 100644 arch/arm/boot/dts/exynos4412-odroidx2.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 5986ff63b901..28b354936685 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -66,7 +66,9 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
exynos4210-smdkv310.dtb \
exynos4210-trats.dtb \
exynos4210-universal_c210.dtb \
+ exynos4412-odroidu3.dtb \
exynos4412-odroidx.dtb \
+ exynos4412-odroidx2.dtb \
exynos4412-origen.dtb \
exynos4412-smdk4412.dtb \
exynos4412-tiny4412.dtb \
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
new file mode 100644
index 000000000000..f793f3b8f0b9
--- /dev/null
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -0,0 +1,319 @@
+/*
+ * Common definition for Hardkernel's Exynos4412 based ODROID-X/X2/U2/U3 boards
+ * device tree source
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include "exynos4412.dtsi"
+
+/ {
+ firmware@0204F000 {
+ compatible = "samsung,secure-firmware";
+ reg = <0x0204F000 0x1000>;
+ };
+
+ mmc@12550000 {
+ pinctrl-0 = <&sd4_clk &sd4_cmd &sd4_bus4 &sd4_bus8>;
+ pinctrl-names = "default";
+ vmmc-supply = <&ldo20_reg &buck8_reg>;
+ status = "okay";
+
+ num-slots = <1>;
+ supports-highspeed;
+ broken-cd;
+ card-detect-delay = <200>;
+ samsung,dw-mshc-ciu-div = <3>;
+ samsung,dw-mshc-sdr-timing = <2 3>;
+ samsung,dw-mshc-ddr-timing = <1 2>;
+
+ slot@0 {
+ reg = <0>;
+ bus-width = <8>;
+ };
+ };
+
+ watchdog@10060000 {
+ status = "okay";
+ };
+
+ rtc@10070000 {
+ status = "okay";
+ };
+
+ g2d@10800000 {
+ status = "okay";
+ };
+
+ camera {
+ status = "okay";
+ pinctrl-names = "default";
+ pinctrl-0 = <>;
+
+ fimc_0: fimc@11800000 {
+ status = "okay";
+ };
+
+ fimc_1: fimc@11810000 {
+ status = "okay";
+ };
+
+ fimc_2: fimc@11820000 {
+ status = "okay";
+ };
+
+ fimc_3: fimc@11830000 {
+ status = "okay";
+ };
+ };
+
+ sdhci@12530000 {
+ bus-width = <4>;
+ pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
+ pinctrl-names = "default";
+ vmmc-supply = <&ldo4_reg &ldo21_reg>;
+ status = "okay";
+ };
+
+ serial@13800000 {
+ status = "okay";
+ };
+
+ serial@13810000 {
+ status = "okay";
+ };
+
+ fixed-rate-clocks {
+ xxti {
+ compatible = "samsung,clock-xxti";
+ clock-frequency = <0>;
+ };
+
+ xusbxti {
+ compatible = "samsung,clock-xusbxti";
+ clock-frequency = <24000000>;
+ };
+ };
+
+ i2c@13860000 {
+ pinctrl-0 = <&i2c0_bus>;
+ pinctrl-names = "default";
+ status = "okay";
+
+ usb3503: usb3503@08 {
+ compatible = "smsc,usb3503";
+ reg = <0x08>;
+
+ intn-gpios = <&gpx3 0 0>;
+ connect-gpios = <&gpx3 4 0>;
+ reset-gpios = <&gpx3 5 0>;
+ initial-mode = <1>;
+ };
+
+ max77686: pmic@09 {
+ compatible = "maxim,max77686";
+ reg = <0x09>;
+ #clock-cells = <1>;
+
+ voltage-regulators {
+ ldo1_reg: LDO1 {
+ regulator-name = "VDD_ALIVE_1.0V";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-always-on;
+ };
+
+ ldo2_reg: LDO2 {
+ regulator-name = "VDDQ_M1_2_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
+ ldo3_reg: LDO3 {
+ regulator-name = "VDDQ_EXT_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
+ ldo4_reg: LDO4 {
+ regulator-name = "VDDQ_MMC2_2.8V";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo5_reg: LDO5 {
+ regulator-name = "VDDQ_MMC1_3_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo6_reg: LDO6 {
+ regulator-name = "VDD10_MPLL_1.0V";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-always-on;
+ };
+
+ ldo7_reg: LDO7 {
+ regulator-name = "VDD10_XPLL_1.0V";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-always-on;
+ };
+
+ ldo11_reg: LDO11 {
+ regulator-name = "VDD18_ABB1_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
+ ldo12_reg: LDO12 {
+ regulator-name = "VDD33_USB_3.3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo13_reg: LDO13 {
+ regulator-name = "VDDQ_C2C_W_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo14_reg: LDO14 {
+ regulator-name = "VDD18_ABB0_2_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo15_reg: LDO15 {
+ regulator-name = "VDD10_HSIC_1.0V";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo16_reg: LDO16 {
+ regulator-name = "VDD18_HSIC_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo20_reg: LDO20 {
+ regulator-name = "LDO20_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-boot-on;
+ };
+
+ ldo21_reg: LDO21 {
+ regulator-name = "LDO21_3.3V";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ ldo25_reg: LDO25 {
+ regulator-name = "VDDQ_LCD_1.8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ buck1_reg: BUCK1 {
+ regulator-name = "vdd_mif";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ buck2_reg: BUCK2 {
+ regulator-name = "vdd_arm";
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ buck3_reg: BUCK3 {
+ regulator-name = "vdd_int";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ buck4_reg: BUCK4 {
+ regulator-name = "vdd_g3d";
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <1100000>;
+ regulator-microvolt-offset = <50000>;
+ };
+
+ buck5_reg: BUCK5 {
+ regulator-name = "VDDQ_CKEM1_2_1.2V";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ buck6_reg: BUCK6 {
+ regulator-name = "BUCK6_1.35V";
+ regulator-min-microvolt = <1350000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ buck7_reg: BUCK7 {
+ regulator-name = "BUCK7_2.0V";
+ regulator-min-microvolt = <2000000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-always-on;
+ };
+
+ buck8_reg: BUCK8 {
+ regulator-name = "BUCK8_2.8V";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ regulator-always-on;
+ };
+ };
+ };
+ };
+
+ exynos-usbphy@125B0000 {
+ status = "okay";
+ };
+
+ hsotg@12480000 {
+ status = "okay";
+ vusb_d-supply = <&ldo15_reg>;
+ vusb_a-supply = <&ldo12_reg>;
+ };
+
+ ehci: ehci@12580000 {
+ status = "okay";
+ };
+};
diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
new file mode 100644
index 000000000000..b89408ea9efc
--- /dev/null
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -0,0 +1,49 @@
+/*
+ * Hardkernel's Exynos4412 based ODROID-U3 board device tree source
+ *
+ * Copyright (c) 2014 Marek Szyprowski <m.szyprowski@samsung.com>
+ *
+ * Device tree source file for Hardkernel's ODROID-U3 board which is based
+ * on Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+#include "exynos4412-odroid-common.dtsi"
+
+/ {
+ model = "Hardkernel ODROID-U3 board based on Exynos4412";
+ compatible = "hardkernel,odroid-u3", "samsung,exynos4412", "samsung,exynos4";
+
+ memory {
+ reg = <0x40000000 0x80000000>;
+ };
+
+ leds {
+ compatible = "gpio-leds";
+ led1 {
+ label = "led1:heart";
+ gpios = <&gpc1 0 1>;
+ default-state = "on";
+ linux,default-trigger = "heartbeat";
+ };
+ };
+};
+
+&usb3503 {
+ clock-names = "refclk";
+ clocks = <&pmu_system_controller 0>;
+ refclk-frequency = <24000000>;
+};
+
+&ehci {
+ port@1 {
+ status = "okay";
+ };
+ port@2 {
+ status = "okay";
+ };
+};
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index 4c853fbf7202..990a04760313 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -3,8 +3,8 @@
*
* Copyright (c) 2012 Dongjin Kim <tobetter@gmail.com>
*
- * Device tree source file for Hardkernel's ODROID-X board which is based on
- * Samsung's Exynos4412 SoC.
+ * Device tree source file for Hardkernel's ODROID-X board which is based
+ * on Samsung's Exynos4412 SoC.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
@@ -12,7 +12,7 @@
*/
/dts-v1/;
-#include "exynos4412.dtsi"
+#include "exynos4412-odroid-common.dtsi"
/ {
model = "Hardkernel ODROID-X board based on Exynos4412";
@@ -22,11 +22,6 @@
reg = <0x40000000 0x40000000>;
};
- firmware@0204F000 {
- compatible = "samsung,secure-firmware";
- reg = <0x0204F000 0x1000>;
- };
-
leds {
compatible = "gpio-leds";
led1 {
@@ -43,24 +38,12 @@
};
};
- mmc@12550000 {
- pinctrl-0 = <&sd4_clk &sd4_cmd &sd4_bus4 &sd4_bus8>;
- pinctrl-names = "default";
- vmmc-supply = <&ldo20_reg &buck8_reg>;
+ serial@13820000 {
status = "okay";
+ };
- num-slots = <1>;
- supports-highspeed;
- broken-cd;
- card-detect-delay = <200>;
- samsung,dw-mshc-ciu-div = <3>;
- samsung,dw-mshc-sdr-timing = <2 3>;
- samsung,dw-mshc-ddr-timing = <1 2>;
-
- slot@0 {
- reg = <0>;
- bus-width = <8>;
- };
+ serial@13830000 {
+ status = "okay";
};
regulator_p3v3 {
@@ -70,299 +53,12 @@
regulator-max-microvolt = <3300000>;
gpio = <&gpa1 1 1>;
enable-active-high;
- regulator-boot-on;
- };
-
- watchdog@10060000 {
- status = "okay";
- };
-
- rtc@10070000 {
- status = "okay";
- };
-
- g2d@10800000 {
- status = "okay";
- };
-
- camera {
- status = "okay";
- pinctrl-names = "default";
- pinctrl-0 = <>;
-
- fimc_0: fimc@11800000 {
- status = "okay";
- };
-
- fimc_1: fimc@11810000 {
- status = "okay";
- };
-
- fimc_2: fimc@11820000 {
- status = "okay";
- };
-
- fimc_3: fimc@11830000 {
- status = "okay";
- };
- };
-
- sdhci@12530000 {
- bus-width = <4>;
- pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
- pinctrl-names = "default";
- vmmc-supply = <&ldo4_reg &ldo21_reg>;
- status = "okay";
- };
-
- serial@13800000 {
- status = "okay";
- };
-
- serial@13810000 {
- status = "okay";
- };
-
- serial@13820000 {
- status = "okay";
- };
-
- serial@13830000 {
- status = "okay";
- };
-
- fixed-rate-clocks {
- xxti {
- compatible = "samsung,clock-xxti";
- clock-frequency = <0>;
- };
-
- xusbxti {
- compatible = "samsung,clock-xusbxti";
- clock-frequency = <24000000>;
- };
- };
-
- i2c@13860000 {
- pinctrl-0 = <&i2c0_bus>;
- pinctrl-names = "default";
- status = "okay";
-
- usb3503@08 {
- compatible = "smsc,usb3503";
- reg = <0x08>;
-
- intn-gpios = <&gpx3 0 0>;
- connect-gpios = <&gpx3 4 0>;
- reset-gpios = <&gpx3 5 0>;
- initial-mode = <1>;
- };
-
- max77686: pmic@09 {
- compatible = "maxim,max77686";
- reg = <0x09>;
- #clock-cells = <1>;
-
- voltage-regulators {
- ldo1_reg: LDO1 {
- regulator-name = "VDD_ALIVE_1.0V";
- regulator-min-microvolt = <1000000>;
- regulator-max-microvolt = <1000000>;
- regulator-always-on;
- };
-
- ldo2_reg: LDO2 {
- regulator-name = "VDDQ_M1_2_1.8V";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-always-on;
- };
-
- ldo3_reg: LDO3 {
- regulator-name = "VDDQ_EXT_1.8V";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-always-on;
- };
-
- ldo4_reg: LDO4 {
- regulator-name = "VDDQ_MMC2_2.8V";
- regulator-min-microvolt = <2800000>;
- regulator-max-microvolt = <2800000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- ldo5_reg: LDO5 {
- regulator-name = "VDDQ_MMC1_3_1.8V";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- ldo6_reg: LDO6 {
- regulator-name = "VDD10_MPLL_1.0V";
- regulator-min-microvolt = <1000000>;
- regulator-max-microvolt = <1000000>;
- regulator-always-on;
- };
-
- ldo7_reg: LDO7 {
- regulator-name = "VDD10_XPLL_1.0V";
- regulator-min-microvolt = <1000000>;
- regulator-max-microvolt = <1000000>;
- regulator-always-on;
- };
-
- ldo11_reg: LDO11 {
- regulator-name = "VDD18_ABB1_1.8V";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-always-on;
- };
-
- ldo12_reg: LDO12 {
- regulator-name = "VDD33_USB_3.3V";
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- ldo13_reg: LDO13 {
- regulator-name = "VDDQ_C2C_W_1.8V";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- ldo14_reg: LDO14 {
- regulator-name = "VDD18_ABB0_2_1.8V";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- ldo15_reg: LDO15 {
- regulator-name = "VDD10_HSIC_1.0V";
- regulator-min-microvolt = <1000000>;
- regulator-max-microvolt = <1000000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- ldo16_reg: LDO16 {
- regulator-name = "VDD18_HSIC_1.8V";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- ldo20_reg: LDO20 {
- regulator-name = "LDO20_1.8V";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-boot-on;
- };
-
- ldo21_reg: LDO21 {
- regulator-name = "LDO21_3.3V";
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- ldo25_reg: LDO25 {
- regulator-name = "VDDQ_LCD_1.8V";
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- buck1_reg: BUCK1 {
- regulator-name = "vdd_mif";
- regulator-min-microvolt = <1000000>;
- regulator-max-microvolt = <1000000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- buck2_reg: BUCK2 {
- regulator-name = "vdd_arm";
- regulator-min-microvolt = <900000>;
- regulator-max-microvolt = <1350000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- buck3_reg: BUCK3 {
- regulator-name = "vdd_int";
- regulator-min-microvolt = <1000000>;
- regulator-max-microvolt = <1000000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- buck4_reg: BUCK4 {
- regulator-name = "vdd_g3d";
- regulator-min-microvolt = <900000>;
- regulator-max-microvolt = <1100000>;
- regulator-microvolt-offset = <50000>;
- };
-
- buck5_reg: BUCK5 {
- regulator-name = "VDDQ_CKEM1_2_1.2V";
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <1200000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- buck6_reg: BUCK6 {
- regulator-name = "BUCK6_1.35V";
- regulator-min-microvolt = <1350000>;
- regulator-max-microvolt = <1350000>;
- regulator-always-on;
- regulator-boot-on;
- };
-
- buck7_reg: BUCK7 {
- regulator-name = "BUCK7_2.0V";
- regulator-min-microvolt = <2000000>;
- regulator-max-microvolt = <2000000>;
- regulator-always-on;
- };
-
- buck8_reg: BUCK8 {
- regulator-name = "BUCK8_2.8V";
- regulator-min-microvolt = <2800000>;
- regulator-max-microvolt = <2800000>;
- regulator-always-on;
- };
- };
- };
- };
-
- exynos-usbphy@125B0000 {
- status = "okay";
- };
-
- hsotg@12480000 {
- status = "okay";
- vusb_d-supply = <&ldo15_reg>;
- vusb_a-supply = <&ldo12_reg>;
+ regulator-always-on;
};
+};
- ehci@12580000 {
+&ehci {
+ port@1 {
status = "okay";
- port@1 {
- status = "okay";
- };
};
};
diff --git a/arch/arm/boot/dts/exynos4412-odroidx2.dts b/arch/arm/boot/dts/exynos4412-odroidx2.dts
new file mode 100644
index 000000000000..5b934dd2af35
--- /dev/null
+++ b/arch/arm/boot/dts/exynos4412-odroidx2.dts
@@ -0,0 +1,23 @@
+/*
+ * Hardkernel's Exynos4412 based ODROID-X2 board device tree source
+ *
+ * Copyright (c) 2012 Dongjin Kim <tobetter@gmail.com>
+ *
+ * Device tree source file for Hardkernel's ODROID-X2 board which is based
+ * on Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+#include "exynos4412-odroidx.dts"
+
+/ {
+ model = "Hardkernel ODROID-X2 board based on Exynos4412";
+ compatible = "hardkernel,odroid-x2", "samsung,exynos4412", "samsung,exynos4";
+
+ memory {
+ reg = <0x40000000 0x80000000>;
+ };
+};
--
1.9.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* [PATCH v2 5/5] ARM: dts: exynos4412-odroid-common: disable 'always on' for BUCK8 regulator
2014-06-25 13:26 [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support Marek Szyprowski
` (3 preceding siblings ...)
2014-06-25 13:26 ` [PATCH v2 4/5] ARM: dts: refactor Odroid DTS file and add support for Odroid X2 and U2/U3 Marek Szyprowski
@ 2014-06-25 13:26 ` Marek Szyprowski
2014-06-30 5:34 ` [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support Marek Szyprowski
5 siblings, 0 replies; 19+ messages in thread
From: Marek Szyprowski @ 2014-06-25 13:26 UTC (permalink / raw)
To: linux-samsung-soc
Cc: Marek Szyprowski, Kukjin Kim, Kamil Debski, Sylwester Nawrocki,
Tobias Jakobi, Daniel Drake
From: Kamil Debski <k.debski@samsung.com>
On Odroid U2/U3 BUCK8 is used for providing power to also to P3V3
source, which is also connected to LAN9730 chip's nRESET signal. To
reset lan chip on system reboot, the BUCK8 output should not be used in
'always on' mode. This change has no impact on X/X2 boards.
Signed-off-by: Kamil Debski <k.debski@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index f793f3b8f0b9..ad2cb32a3439 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -297,7 +297,6 @@
regulator-name = "BUCK8_2.8V";
regulator-min-microvolt = <2800000>;
regulator-max-microvolt = <2800000>;
- regulator-always-on;
};
};
};
--
1.9.2
^ permalink raw reply related [flat|nested] 19+ messages in thread* Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support
2014-06-25 13:26 [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support Marek Szyprowski
` (4 preceding siblings ...)
2014-06-25 13:26 ` [PATCH v2 5/5] ARM: dts: exynos4412-odroid-common: disable 'always on' for BUCK8 regulator Marek Szyprowski
@ 2014-06-30 5:34 ` Marek Szyprowski
2014-07-18 5:56 ` Olof Johansson
2014-07-18 15:40 ` Przemyslaw Marczak
5 siblings, 2 replies; 19+ messages in thread
From: Marek Szyprowski @ 2014-06-30 5:34 UTC (permalink / raw)
To: linux-samsung-soc
Cc: Kukjin Kim, Kamil Debski, Sylwester Nawrocki, Tobias Jakobi,
Daniel Drake, Przemyslaw Marczak
Hello,
On 2014-06-25 15:26, Marek Szyprowski wrote:
> Hello,
>
> This is the second version of the initial patch series adding support
> for Exynos 4412 based Odroid X2 and U2/U3/U3+ boards and improving
> support for Odroid X.
>
> Complete USB support for Odroid U2/U3/U3+ still requires some fixes in
> Exynos4 USB2 Phy driver and clock driver for CLKOUT:
> http://thread.gmane.org/gmane.linux.kernel/1731843/
> http://www.spinics.net/lists/linux-usb/msg109587.html
> The above changes however don't affect Odroid DTS files, but without
> them, usb3503 hub is not yet functional.
>
> Support for audio codec will be posted separately by Sylwester Nawrocki
> soon. Support for HDMI video output will be also posted separately
> together with the required ExynosDRM-HDMI fixes.
>
> If one is interested in more complete and open-source Odroid board
> support, there are also patches for u-boot project:
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/188295/focus=188610
Just to let everyone knows - updated Odroid patches for uboot has been
posted in the following thread:
http://www.mail-archive.com/u-boot@lists.denx.de/msg141234.html
You can also download them here:
http://patchwork.ozlabs.org/project/uboot/list/?submitter=23519
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 19+ messages in thread* Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support
2014-06-30 5:34 ` [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support Marek Szyprowski
@ 2014-07-18 5:56 ` Olof Johansson
2014-07-18 6:02 ` Olof Johansson
2014-07-18 6:06 ` Daniel Drake
2014-07-18 15:40 ` Przemyslaw Marczak
1 sibling, 2 replies; 19+ messages in thread
From: Olof Johansson @ 2014-07-18 5:56 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim, Kamil Debski,
Sylwester Nawrocki, Tobias Jakobi, Daniel Drake,
Przemyslaw Marczak
On Sun, Jun 29, 2014 at 10:34 PM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
> Hello,
>
>
> On 2014-06-25 15:26, Marek Szyprowski wrote:
>>
>> Hello,
>>
>> This is the second version of the initial patch series adding support
>> for Exynos 4412 based Odroid X2 and U2/U3/U3+ boards and improving
>> support for Odroid X.
>>
>> Complete USB support for Odroid U2/U3/U3+ still requires some fixes in
>> Exynos4 USB2 Phy driver and clock driver for CLKOUT:
>> http://thread.gmane.org/gmane.linux.kernel/1731843/
>> http://www.spinics.net/lists/linux-usb/msg109587.html
>> The above changes however don't affect Odroid DTS files, but without
>> them, usb3503 hub is not yet functional.
>>
>> Support for audio codec will be posted separately by Sylwester Nawrocki
>> soon. Support for HDMI video output will be also posted separately
>> together with the required ExynosDRM-HDMI fixes.
>>
>> If one is interested in more complete and open-source Odroid board
>> support, there are also patches for u-boot project:
>> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/188295/focus=188610
>
>
> Just to let everyone knows - updated Odroid patches for uboot has been
> posted in the following thread:
> http://www.mail-archive.com/u-boot@lists.denx.de/msg141234.html
> You can also download them here:
> http://patchwork.ozlabs.org/project/uboot/list/?submitter=23519
Anyone got a simple writeup on the steps needed to boot, bl1/2 needed,
expected offset into eMMC for where it goes, etc?
I gave the kernel (next-0717) a go here on my U3, and it boots (as you
mention, no USB comes up).
I do see a few KERN_ERR printks though:
[ERR] [ 0.000000] L2C: failed to init: -19
[ERR] [ 0.001302] missing device node for CPU 0
[ERR] [ 0.001344] missing device node for CPU 1
[ERR] [ 0.001366] missing device node for CPU 2
[ERR] [ 0.001386] missing device node for CPU 3
[ERR] [ 0.156490] max77686 0-0009: irq is not specified
[ERR] [ 1.339498] /i2c@13860000/usb3503@08: could not get
#clock-cells for /system-controller@10020000
[ERR] [ 1.348050] ERROR: could not get clock
/i2c@13860000/usb3503@08:refclk(0)
[ERR] [ 1.383055] max77686-rtc max77686-rtc: max77686_rtc_init_reg:
fail to write controlm reg(-6)
[ERR] [ 1.391108] max77686-rtc max77686-rtc: Failed to initialize RTC reg:-6
That can be fixed incrementally. I'll add the U3 to my boot farm
starting tonight. Thanks for submitting all this!
-Olof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support
2014-07-18 5:56 ` Olof Johansson
@ 2014-07-18 6:02 ` Olof Johansson
2014-07-18 6:06 ` Daniel Drake
1 sibling, 0 replies; 19+ messages in thread
From: Olof Johansson @ 2014-07-18 6:02 UTC (permalink / raw)
To: Marek Szyprowski
Cc: linux-samsung-soc@vger.kernel.org, Kukjin Kim, Kamil Debski,
Sylwester Nawrocki, Tobias Jakobi, Daniel Drake,
Przemyslaw Marczak
On Thu, Jul 17, 2014 at 10:56 PM, Olof Johansson <olof@lixom.net> wrote:
> I gave the kernel (next-0717) a go here on my U3, and it boots (as you
> mention, no USB comes up).
Btw, please update multi_v7_defconfig as well (as a separate patch,
since it needs to be merged directly by us). Right now it doesn't find
rootfs with that config.
-Olof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support
2014-07-18 5:56 ` Olof Johansson
2014-07-18 6:02 ` Olof Johansson
@ 2014-07-18 6:06 ` Daniel Drake
1 sibling, 0 replies; 19+ messages in thread
From: Daniel Drake @ 2014-07-18 6:06 UTC (permalink / raw)
To: Olof Johansson
Cc: Marek Szyprowski, linux-samsung-soc@vger.kernel.org, Kukjin Kim,
Kamil Debski, Sylwester Nawrocki, Tobias Jakobi,
Przemyslaw Marczak
Hi Olof,
Thanks for joining the party here :)
On Fri, Jul 18, 2014 at 6:56 AM, Olof Johansson <olof@lixom.net> wrote:
> Anyone got a simple writeup on the steps needed to boot, bl1/2 needed,
> expected offset into eMMC for where it goes, etc?
https://github.com/hardkernel/u-boot/blob/odroid-v2010.12/sd_fuse/sd_fusing.sh
is probably the best "writeup" :)
https://github.com/hardkernel/u-boot/tree/odroid-v2010.12/sd_fuse has
the blobs needed (they have not changed at all in the U3's history, so
the ones you have already will work fine).
Samsung guys are also upstreaming support into uboot, including a
README.odroid in the last commit with this info:
http://patchwork.ozlabs.org/project/uboot/list/?submitter=23519
> I gave the kernel (next-0717) a go here on my U3, and it boots (as you
> mention, no USB comes up).
Nice. USB works with the later patches floating around.
> I do see a few KERN_ERR printks though:
>
> [ERR] [ 0.000000] L2C: failed to init: -19
This one is fixed with the patch series "Enable L2 cache support on
Exynos4210/4x12 SoCs"
> [ERR] [ 0.001302] missing device node for CPU 0
> [ERR] [ 0.001344] missing device node for CPU 1
> [ERR] [ 0.001366] missing device node for CPU 2
> [ERR] [ 0.001386] missing device node for CPU 3
Not sure about these - I still get them with all the patches applied.
> [ERR] [ 0.156490] max77686 0-0009: irq is not specified
I submitted a patch for this, "ARM: dts: Enable PMIC interrupts on ODROID"
> [ERR] [ 1.339498] /i2c@13860000/usb3503@08: could not get
> #clock-cells for /system-controller@10020000
> [ERR] [ 1.348050] ERROR: could not get clock
> /i2c@13860000/usb3503@08:refclk(0)
I think these go away with the USB patches floating around.
> [ERR] [ 1.383055] max77686-rtc max77686-rtc: max77686_rtc_init_reg:
> fail to write controlm reg(-6)
> [ERR] [ 1.391108] max77686-rtc max77686-rtc: Failed to initialize RTC reg:-6
Fixed with "ARM: dts: ODROID i2c improvements"
Daniel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support
2014-06-30 5:34 ` [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support Marek Szyprowski
2014-07-18 5:56 ` Olof Johansson
@ 2014-07-18 15:40 ` Przemyslaw Marczak
2014-08-19 19:40 ` Olof Johansson
1 sibling, 1 reply; 19+ messages in thread
From: Przemyslaw Marczak @ 2014-07-18 15:40 UTC (permalink / raw)
To: Marek Szyprowski, linux-samsung-soc
Cc: Kukjin Kim, Kamil Debski, Sylwester Nawrocki, Tobias Jakobi,
Daniel Drake, Przemyslaw Marczak, Olof Johansson
Hello,
On 06/30/2014 07:34 AM, Marek Szyprowski wrote:
> Hello,
>
> On 2014-06-25 15:26, Marek Szyprowski wrote:
>> Hello,
>>
>> This is the second version of the initial patch series adding support
>> for Exynos 4412 based Odroid X2 and U2/U3/U3+ boards and improving
>> support for Odroid X.
>>
>> Complete USB support for Odroid U2/U3/U3+ still requires some fixes in
>> Exynos4 USB2 Phy driver and clock driver for CLKOUT:
>> http://thread.gmane.org/gmane.linux.kernel/1731843/
>> http://www.spinics.net/lists/linux-usb/msg109587.html
>> The above changes however don't affect Odroid DTS files, but without
>> them, usb3503 hub is not yet functional.
>>
>> Support for audio codec will be posted separately by Sylwester Nawrocki
>> soon. Support for HDMI video output will be also posted separately
>> together with the required ExynosDRM-HDMI fixes.
>>
>> If one is interested in more complete and open-source Odroid board
>> support, there are also patches for u-boot project:
>> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/188295/focus=188610
>>
>
> Just to let everyone knows - updated Odroid patches for uboot has been
> posted in the following thread:
> http://www.mail-archive.com/u-boot@lists.denx.de/msg141234.html
> You can also download them here:
> http://patchwork.ozlabs.org/project/uboot/list/?submitter=23519
>
> Best regards
Please follow the link to the new U-boot Odroid U3/X2 patches:
http://www.mail-archive.com/u-boot@lists.denx.de/msg142507.html
Regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak@samsung.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support
2014-07-18 15:40 ` Przemyslaw Marczak
@ 2014-08-19 19:40 ` Olof Johansson
2014-08-19 19:54 ` Daniel Drake
0 siblings, 1 reply; 19+ messages in thread
From: Olof Johansson @ 2014-08-19 19:40 UTC (permalink / raw)
To: Przemyslaw Marczak
Cc: Marek Szyprowski, linux-samsung-soc@vger.kernel.org, Kukjin Kim,
Kamil Debski, Sylwester Nawrocki, Tobias Jakobi, Daniel Drake
ODROID-U3 has been broken in mainline for quite a while. Have patches
been posted for this already?
http://arm-soc.lixom.net/bootlogs/mainline/v3.17-rc1/odroidu3-arm-exynos_defconfig.html
for one of the latest boots that failed.
-Olof
On Fri, Jul 18, 2014 at 8:40 AM, Przemyslaw Marczak
<p.marczak@samsung.com> wrote:
> Hello,
>
>
> On 06/30/2014 07:34 AM, Marek Szyprowski wrote:
>>
>> Hello,
>>
>> On 2014-06-25 15:26, Marek Szyprowski wrote:
>>>
>>> Hello,
>>>
>>> This is the second version of the initial patch series adding support
>>> for Exynos 4412 based Odroid X2 and U2/U3/U3+ boards and improving
>>> support for Odroid X.
>>>
>>> Complete USB support for Odroid U2/U3/U3+ still requires some fixes in
>>> Exynos4 USB2 Phy driver and clock driver for CLKOUT:
>>> http://thread.gmane.org/gmane.linux.kernel/1731843/
>>> http://www.spinics.net/lists/linux-usb/msg109587.html
>>> The above changes however don't affect Odroid DTS files, but without
>>> them, usb3503 hub is not yet functional.
>>>
>>> Support for audio codec will be posted separately by Sylwester Nawrocki
>>> soon. Support for HDMI video output will be also posted separately
>>> together with the required ExynosDRM-HDMI fixes.
>>>
>>> If one is interested in more complete and open-source Odroid board
>>> support, there are also patches for u-boot project:
>>>
>>> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/188295/focus=188610
>>>
>>
>> Just to let everyone knows - updated Odroid patches for uboot has been
>> posted in the following thread:
>> http://www.mail-archive.com/u-boot@lists.denx.de/msg141234.html
>> You can also download them here:
>> http://patchwork.ozlabs.org/project/uboot/list/?submitter=23519
>>
>> Best regards
>
>
> Please follow the link to the new U-boot Odroid U3/X2 patches:
>
> http://www.mail-archive.com/u-boot@lists.denx.de/msg142507.html
>
> Regards,
> --
> Przemyslaw Marczak
> Samsung R&D Institute Poland
> Samsung Electronics
> p.marczak@samsung.com
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support
2014-08-19 19:40 ` Olof Johansson
@ 2014-08-19 19:54 ` Daniel Drake
2014-08-19 20:26 ` Olof Johansson
0 siblings, 1 reply; 19+ messages in thread
From: Daniel Drake @ 2014-08-19 19:54 UTC (permalink / raw)
To: Olof Johansson
Cc: Przemyslaw Marczak, Marek Szyprowski,
linux-samsung-soc@vger.kernel.org, Kukjin Kim, Kamil Debski,
Sylwester Nawrocki, Tobias Jakobi
On Tue, Aug 19, 2014 at 8:40 PM, Olof Johansson <olof@lixom.net> wrote:
> ODROID-U3 has been broken in mainline for quite a while. Have patches
> been posted for this already?
>
> http://arm-soc.lixom.net/bootlogs/mainline/v3.17-rc1/odroidu3-arm-exynos_defconfig.html
> for one of the latest boots that failed.
Yes, discussed in the thread titled "[PATCH 1/2] ARM: dts: Enable PMIC
interrupts on ODROID"
Those patches weren't important for boot at the time of submission,
but it looks like something else changed (the max77686 driver?) that
makes them now required.
Daniel
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support
2014-08-19 19:54 ` Daniel Drake
@ 2014-08-19 20:26 ` Olof Johansson
2014-08-20 6:29 ` Marek Szyprowski
0 siblings, 1 reply; 19+ messages in thread
From: Olof Johansson @ 2014-08-19 20:26 UTC (permalink / raw)
To: Daniel Drake
Cc: Przemyslaw Marczak, Marek Szyprowski,
linux-samsung-soc@vger.kernel.org, Kukjin Kim, Kamil Debski,
Sylwester Nawrocki, Tobias Jakobi
On Tue, Aug 19, 2014 at 12:54 PM, Daniel Drake <drake@endlessm.com> wrote:
> On Tue, Aug 19, 2014 at 8:40 PM, Olof Johansson <olof@lixom.net> wrote:
>> ODROID-U3 has been broken in mainline for quite a while. Have patches
>> been posted for this already?
>>
>> http://arm-soc.lixom.net/bootlogs/mainline/v3.17-rc1/odroidu3-arm-exynos_defconfig.html
>> for one of the latest boots that failed.
>
> Yes, discussed in the thread titled "[PATCH 1/2] ARM: dts: Enable PMIC
> interrupts on ODROID"
> Those patches weren't important for boot at the time of submission,
> but it looks like something else changed (the max77686 driver?) that
> makes them now required.
Excellent, thanks. A bummer we didn't see this earlier, but let's get
the fix in asap.
-Olof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support
2014-08-19 20:26 ` Olof Johansson
@ 2014-08-20 6:29 ` Marek Szyprowski
2014-08-20 7:18 ` Javier Martinez Canillas
0 siblings, 1 reply; 19+ messages in thread
From: Marek Szyprowski @ 2014-08-20 6:29 UTC (permalink / raw)
To: Olof Johansson, Daniel Drake
Cc: Przemyslaw Marczak, linux-samsung-soc@vger.kernel.org, Kukjin Kim,
Kamil Debski, Sylwester Nawrocki, Tobias Jakobi
Hello,
On 2014-08-19 22:26, Olof Johansson wrote:
> On Tue, Aug 19, 2014 at 12:54 PM, Daniel Drake <drake@endlessm.com> wrote:
>> On Tue, Aug 19, 2014 at 8:40 PM, Olof Johansson <olof@lixom.net> wrote:
>>> ODROID-U3 has been broken in mainline for quite a while. Have patches
>>> been posted for this already?
>>>
>>> http://arm-soc.lixom.net/bootlogs/mainline/v3.17-rc1/odroidu3-arm-exynos_defconfig.html
>>> for one of the latest boots that failed.
>> Yes, discussed in the thread titled "[PATCH 1/2] ARM: dts: Enable PMIC
>> interrupts on ODROID"
>> Those patches weren't important for boot at the time of submission,
>> but it looks like something else changed (the max77686 driver?) that
>> makes them now required.
> Excellent, thanks. A bummer we didn't see this earlier, but let's get
> the fix in asap.
I've also posted a fix to MAX77686 driver, which restores v3.16-like
behavior
of PMIC driver. I hope it will get merged to one of v3.17 rc series.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support
2014-08-20 6:29 ` Marek Szyprowski
@ 2014-08-20 7:18 ` Javier Martinez Canillas
2014-08-20 9:22 ` Daniel Drake
0 siblings, 1 reply; 19+ messages in thread
From: Javier Martinez Canillas @ 2014-08-20 7:18 UTC (permalink / raw)
To: Marek Szyprowski, Bartlomiej Zolnierkiewicz
Cc: Olof Johansson, Daniel Drake, Przemyslaw Marczak,
linux-samsung-soc@vger.kernel.org, Kukjin Kim, Kamil Debski,
Sylwester Nawrocki, Tobias Jakobi
+Bartlomiej Zolnierkiewicz
Hello Marek,
On Wed, Aug 20, 2014 at 8:29 AM, Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>>>
>>> Yes, discussed in the thread titled "[PATCH 1/2] ARM: dts: Enable PMIC
>>> interrupts on ODROID"
>>> Those patches weren't important for boot at the time of submission,
>>> but it looks like something else changed (the max77686 driver?) that
>>> makes them now required.
>>
>> Excellent, thanks. A bummer we didn't see this earlier, but let's get
>> the fix in asap.
>
>
> I've also posted a fix to MAX77686 driver, which restores v3.16-like
> behavior
> of PMIC driver. I hope it will get merged to one of v3.17 rc series.
>
Bartlomiej posted a similar patch [0] before but as I said on that
thread, I'm not sure if is correct to make that DT property optional.
Or rather, if we need to make it optional then we should also change
the Documentation/devicetree/bindings/mfd/max77686.txt that list
"interrupts" DT property as required.
It's true that before converting the max77686 to use the regmap irq
API, the driver was loose on that regard but max77686_irq_init() in
max77686-irq.c was returning -ENODEV when the IRQ was not provided and
that error code was not checked in max77686_i2c_probe() which was a
bug IMHO.
More importantly I wonder if a design where a IRQ line is not
connected to the max77686 PMIC makes even sense. If such a design is
possible then the "interrupt" property should be optional but if not
then I think that the driver should fail to probe in that case. Yes,
it is a regression but also the Odroid DTS was not following the DT
binding and was just lucky that the driver was not checking the
required DT properties.
So I tend to say that Daniel's fix should be added as a -rc fix and we
should keep both the max77686 driver and its DT binding as it is now
but as I said, if from a hardware point of view makes sense to leave
that line unconnected then I don't oppose to this change.
>
> Best regards
> --
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
>
Best regards,
Javier
[0]: https://lkml.org/lkml/2014/8/7/374
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support
2014-08-20 7:18 ` Javier Martinez Canillas
@ 2014-08-20 9:22 ` Daniel Drake
0 siblings, 0 replies; 19+ messages in thread
From: Daniel Drake @ 2014-08-20 9:22 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Marek Szyprowski, Bartlomiej Zolnierkiewicz, Olof Johansson,
Przemyslaw Marczak, linux-samsung-soc@vger.kernel.org, Kukjin Kim,
Kamil Debski, Sylwester Nawrocki, Tobias Jakobi
On Wed, Aug 20, 2014 at 8:18 AM, Javier Martinez Canillas
<javier@dowhile0.org> wrote:
> More importantly I wonder if a design where a IRQ line is not
> connected to the max77686 PMIC makes even sense. If such a design is
> possible then the "interrupt" property should be optional but if not
> then I think that the driver should fail to probe in that case. Yes,
> it is a regression but also the Odroid DTS was not following the DT
> binding and was just lucky that the driver was not checking the
> required DT properties.
I think it would not be totally unreasonable to have such a design
with no IRQ line hookup - after all we just did a load of ODROID work
on 3.16 without this interrupt being available, and we didn't notice.
At the same time, I think its unlikely that someone wouldn't just hook
this up, it is sensible to put this kind of thing on the board even if
you don't have an immediate need for it, and all the reference designs
will have it.
No strong preference but I would vote for the slightly simpler option
of having the max77686 driver require the interrupt specified (like
now), until someone comes along with a board that physically lacks it.
Daniel
^ permalink raw reply [flat|nested] 19+ messages in thread