From: Lars-Peter Clausen <lars@metafoo.de>
To: Bard Liao <bardliao@realtek.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Cc: Oder Chiou <oder_chiou@realtek.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Flove <flove@realtek.com>
Subject: Re: [PATCH] ASoC: rt5640: add ASRC support
Date: Mon, 30 Jun 2014 12:45:06 +0200 [thread overview]
Message-ID: <53B13FB2.1090304@metafoo.de> (raw)
In-Reply-To: <ABFD875FF5FB574BA706497D987D48D75C87F7@RTITMBSV03.realtek.com.tw>
On 06/30/2014 08:09 AM, Bard Liao wrote:
>> -----Original Message-----
>> From: Lars-Peter Clausen [mailto:lars@metafoo.de]
>> Sent: Friday, June 27, 2014 10:05 PM
>> To: Bard Liao; broonie@kernel.org; lgirdwood@gmail.com
>> Cc: Oder Chiou; alsa-devel@alsa-project.org; Flove
>> Subject: Re: [alsa-devel] [PATCH] ASoC: rt5640: add ASRC support
>>
>>
>> I wonder if that shouldn't be something that is automatically
>> enabled/disabled based on the samplerates involved. Also for
>> enable/disable controls use a switch control rather than a enum.
>
> To turn on/off rt5640's ASRC function is not decided by only one
> condition. To make it flexible, I prefer to use a control to enable/
> disable ASRC function.
But the driver should be able to autodetect those conditions, shouldn't it?
> Do you mean SOC_SINGLE_EXT? I didn't find a _SWITCH control
> in soc.h
Yes SOC_SINGLE_EXT() will create a boolean switch if xmax == 1 (otherwise it
will create a integer control).
- Lars
next prev parent reply other threads:[~2014-06-30 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 10:58 [PATCH] ASoC: rt5640: add ASRC support bardliao
2014-06-27 14:05 ` Lars-Peter Clausen
2014-06-30 6:09 ` Bard Liao
2014-06-30 10:45 ` Lars-Peter Clausen [this message]
2014-06-30 14:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B13FB2.1090304@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.