From: Alexander Graf <agraf@suse.de>
To: reza.jelveh@gmail.com, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC
Date: Mon, 30 Jun 2014 14:09:39 +0200 [thread overview]
Message-ID: <53B15383.40603@suse.de> (raw)
In-Reply-To: <1404066076-32859-1-git-send-email-reza.jelveh@tuhh.de>
On 29.06.14 20:21, reza.jelveh@gmail.com wrote:
> This requires a custom ovmf image with sata controller for testing [0]
>
> [0]: http://reza.jelveh.me/assets/OVMF.fd.bz2
>
I guess this is supposed to be a cover letter? A few rules for cover
letters:
1) Cover letters only make sense for patch sets. This is a single
patch, so you don't need one
2) Because they come with patch sets and you number patch sets, cover
letters are [PATCH 0/n].
3) Usually cover letters contain git statistics. Try git format-patch
--cover-letter. It will give you a nice template.
The usual way to add the comment you have here to a patch you're trying
to submit it is to put volatile information (things that shouldn't end
up in the git log) behind a "---" line in the commit message. Everything
after that line gets ignored by git when the patch gets applied.
Alex
next prev parent reply other threads:[~2014-06-30 12:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 18:21 [Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC reza.jelveh
2014-06-29 18:21 ` reza.jelveh
2014-06-30 12:13 ` Alexander Graf
2014-06-30 12:09 ` Alexander Graf [this message]
2014-06-30 18:13 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B15383.40603@suse.de \
--to=agraf@suse.de \
--cc=jsnow@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=reza.jelveh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.