Re: [Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]

On 06/30/2014 06:09 AM, Alexander Graf wrote:
> 
> On 29.06.14 20:21, reza.jelveh@gmail.com wrote:
>> This requires a custom ovmf image with sata controller for testing [0]
>>
>> [0]: http://reza.jelveh.me/assets/OVMF.fd.bz2
>>
> 
> I guess this is supposed to be a cover letter? A few rules for cover
> letters:
> 
>   1) Cover letters only make sense for patch sets. This is a single
> patch, so you don't need one
>   2) Because they come with patch sets and you number patch sets, cover
> letters are [PATCH 0/n].
>   3) Usually cover letters contain git statistics. Try git format-patch
> --cover-letter. It will give you a nice template.
> 
> The usual way to add the comment you have here to a patch you're trying
> to submit it is to put volatile information (things that shouldn't end
> up in the git log) behind a "---" line in the commit message. Everything
> after that line gets ignored by git when the patch gets applied.

For more hints: http://wiki.qemu.org/Contribute/SubmitAPatch

(if anything said here isn't on that page, well, it's a wiki and we
should add it :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]