From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Cc: tim@xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v4 7/8] xen: arm: use superpages in p2m when pages are suitably aligned
Date: Tue, 01 Jul 2014 14:19:16 +0100 [thread overview]
Message-ID: <53B2B554.7090709@linaro.org> (raw)
In-Reply-To: <1404203222-30111-7-git-send-email-ian.campbell@citrix.com>
Hi Ian,
On 07/01/2014 09:27 AM, Ian Campbell wrote:
> +static int p2m_create_table(struct domain *d, lpae_t *entry,
> + int level_shift, bool_t flush_cache)
> {
> struct p2m_domain *p2m = &d->arch.p2m;
> struct page_info *page;
> - void *p;
> + lpae_t *p;
> lpae_t pte;
> + int splitting = entry->p2m.valid;
NIT: You've introduced p2m_valid earlier. I think you can use it here.
>
> - BUG_ON(entry->p2m.valid);
> + BUG_ON(entry->p2m.table);
I though I've asked it before. Should not you check the valid bit by
using p2m_table?
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-07-01 13:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 8:21 [PATCH v4 0/8] xen: arm: Use super pages in p2m Ian Campbell
2014-07-01 8:26 ` [PATCH v4 1/8] xen: arm: dump vcpu gic info in arch_dump_vcpu_info Ian Campbell
2014-07-01 8:26 ` [PATCH v4 2/8] tools/libxc: pull min/max_t into xc_private.h Ian Campbell
2014-07-01 8:26 ` [PATCH v4 3/8] tools: arm: allocate large pages to guests Ian Campbell
2014-07-01 8:26 ` [PATCH v4 4/8] xen: arm: only put_page for p2m operations which require it Ian Campbell
2014-07-01 8:26 ` [PATCH v4 5/8] xen: arm: handle superpage mappings in p2m_lookup Ian Campbell
2014-07-01 8:26 ` [PATCH v4 6/8] xen: arm: add some helpers for assessing p2m pte Ian Campbell
2014-07-01 13:17 ` Julien Grall
2014-07-01 8:27 ` [PATCH v4 7/8] xen: arm: use superpages in p2m when pages are suitably aligned Ian Campbell
2014-07-01 13:19 ` Julien Grall [this message]
2014-07-02 8:46 ` Ian Campbell
2014-07-01 8:27 ` [PATCH v4 8/8] xen: arm: allocate more than one bank for 1:1 domain 0 if needed Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B2B554.7090709@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.