Re: [Qemu-devel] [RFC PATCH 18/22] Network packets record/replay

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]

On 07/01/2014 05:31 AM, Pavel Dovgaluk wrote:
> These patches implement passing network packets to replay module in
> record mode. New virtual network adapter is impelemented to replay the

s/impelemented/implemented/

> packets when they are read from the log file.
> 
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@gmail.com>
> ---

Please thread your messages in-reply-to the cover letter.

> 
> diff --git a/net/clients.h b/net/clients.h
> index 2e8feda..d245a9f 100644
> --- a/net/clients.h
> +++ b/net/clients.h
> @@ -49,6 +49,10 @@ int net_init_bridge(const NetClientOptions *opts, const char *name,
>  
>  int net_init_l2tpv3(const NetClientOptions *opts, const char *name,
>                      NetClientState *peer);
> +                    
> +int net_init_replay(const NetClientOptions *opts, const char *name,
> +                 NetClientState *peer);

Indentation is off.


> --- /dev/null
> +++ b/net/net-replay.c
> @@ -0,0 +1,56 @@
> +#include "net/net.h"

Missing a copyright statement and declaration of license.  (We prefer
GPLv2+ for new files, unless you have a strong reason otherwise, but
whatever you pick must be compatible with GPLv2-only)

> +++ b/qapi-schema.json
> @@ -2145,6 +2145,15 @@
>      '*file': 'str' } }
>  
>  ##
> +# @NetdevReplayOptions
> +#
> +# Dump network traffic to the log in replay mode.
> +#
> +##

Missing a 'Since: 2.2' designation.  Is there any ability to control
which file is used as the logging destination?

> +{ 'type': 'NetdevReplayOptions',
> +  'data': { } }
> +

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]