All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Seunghun Lee <waydi1@gmail.com>,
	dedekind1@gmail.com, adrian.hunter@intel.com
Cc: linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UBIFS: fix some comments
Date: Tue, 01 Jul 2014 08:27:52 -0700	[thread overview]
Message-ID: <53B2D378.7010006@infradead.org> (raw)
In-Reply-To: <1404225925-3347-1-git-send-email-waydi1@gmail.com>

On 07/01/14 07:45, Seunghun Lee wrote:
> This patch fixes some comments about return type.
> 
> Signed-off-by: Seunghun Lee <waydi1@gmail.com>
> ---
>  fs/ubifs/recovery.c |    4 ++--
>  fs/ubifs/scan.c     |    5 ++---
>  2 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
> index c14adb2..933dda5 100644
> --- a/fs/ubifs/recovery.c
> +++ b/fs/ubifs/recovery.c
> @@ -629,8 +629,8 @@ static void drop_last_node(struct ubifs_scan_leb *sleb, int *offs)
>   *
>   * This function does a scan of a LEB, but caters for errors that might have
>   * been caused by the unclean unmount from which we are attempting to recover.
> - * Returns %0 in case of success, %-EUCLEAN if an unrecoverable corruption is
> - * found, and a negative error code in case of failure.
> + * Returns the scaned information on success and a negative error code on

                  scanned

> + * failure.
>   */
>  struct ubifs_scan_leb *ubifs_recover_leb(struct ubifs_info *c, int lnum,
>  					 int offs, void *sbuf, int jhead)
> diff --git a/fs/ubifs/scan.c b/fs/ubifs/scan.c
> index 58aa05d..327d84a 100644
> --- a/fs/ubifs/scan.c
> +++ b/fs/ubifs/scan.c
> @@ -131,7 +131,8 @@ int ubifs_scan_a_node(const struct ubifs_info *c, void *buf, int len, int lnum,
>   * @offs: offset to start at (usually zero)
>   * @sbuf: scan buffer (must be c->leb_size)
>   *
> - * This function returns %0 on success and a negative error code on failure.
> + * This function returns the scaned information on success and a negative error

                                scanned

> + * code on failure.
>   */
>  struct ubifs_scan_leb *ubifs_start_scan(const struct ubifs_info *c, int lnum,
>  					int offs, void *sbuf)


-- 
~Randy

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Seunghun Lee <waydi1@gmail.com>,
	dedekind1@gmail.com, adrian.hunter@intel.com
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] UBIFS: fix some comments
Date: Tue, 01 Jul 2014 08:27:52 -0700	[thread overview]
Message-ID: <53B2D378.7010006@infradead.org> (raw)
In-Reply-To: <1404225925-3347-1-git-send-email-waydi1@gmail.com>

On 07/01/14 07:45, Seunghun Lee wrote:
> This patch fixes some comments about return type.
> 
> Signed-off-by: Seunghun Lee <waydi1@gmail.com>
> ---
>  fs/ubifs/recovery.c |    4 ++--
>  fs/ubifs/scan.c     |    5 ++---
>  2 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
> index c14adb2..933dda5 100644
> --- a/fs/ubifs/recovery.c
> +++ b/fs/ubifs/recovery.c
> @@ -629,8 +629,8 @@ static void drop_last_node(struct ubifs_scan_leb *sleb, int *offs)
>   *
>   * This function does a scan of a LEB, but caters for errors that might have
>   * been caused by the unclean unmount from which we are attempting to recover.
> - * Returns %0 in case of success, %-EUCLEAN if an unrecoverable corruption is
> - * found, and a negative error code in case of failure.
> + * Returns the scaned information on success and a negative error code on

                  scanned

> + * failure.
>   */
>  struct ubifs_scan_leb *ubifs_recover_leb(struct ubifs_info *c, int lnum,
>  					 int offs, void *sbuf, int jhead)
> diff --git a/fs/ubifs/scan.c b/fs/ubifs/scan.c
> index 58aa05d..327d84a 100644
> --- a/fs/ubifs/scan.c
> +++ b/fs/ubifs/scan.c
> @@ -131,7 +131,8 @@ int ubifs_scan_a_node(const struct ubifs_info *c, void *buf, int len, int lnum,
>   * @offs: offset to start at (usually zero)
>   * @sbuf: scan buffer (must be c->leb_size)
>   *
> - * This function returns %0 on success and a negative error code on failure.
> + * This function returns the scaned information on success and a negative error

                                scanned

> + * code on failure.
>   */
>  struct ubifs_scan_leb *ubifs_start_scan(const struct ubifs_info *c, int lnum,
>  					int offs, void *sbuf)


-- 
~Randy

  parent reply	other threads:[~2014-07-01 15:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 14:45 [PATCH] UBIFS: fix some comments Seunghun Lee
2014-07-01 14:45 ` Seunghun Lee
2014-07-01 14:57 ` Artem Bityutskiy
2014-07-01 14:57   ` Artem Bityutskiy
2014-07-01 15:27 ` Randy Dunlap [this message]
2014-07-01 15:27   ` Randy Dunlap
2014-07-01 15:31   ` Artem Bityutskiy
2014-07-01 15:31     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B2D378.7010006@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=adrian.hunter@intel.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=waydi1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.