All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Ming Lei <ming.lei@canonical.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/3] linux-aio: introduce submit I/O at batch
Date: Tue, 01 Jul 2014 19:06:42 +0200	[thread overview]
Message-ID: <53B2EAA2.1010901@redhat.com> (raw)
In-Reply-To: <1404232537-28628-1-git-send-email-ming.lei@canonical.com>

Il 01/07/2014 18:35, Ming Lei ha scritto:
> Hi,
>
> The commit 580b6b2aa2(dataplane: use the QEMU block layer for I/O)
> introduces ~40% throughput regression on virtio-blk dataplane, and
> one of causes is that submitting I/O at batch is removed.
>
> This patchset trys to introduce this mechanism on block, at least,
> linux-aio can benefit from that.
>
> With these patches, it is observed that thoughout on virtio-blk
> dataplane can be improved a lot, see data in commit log of patch
> 3/3.
>
> It should be possible to apply the batch mechanism to other devices
> (such as virtio-scsi) too.
>
> V3:
> 	- only support submitting I/O at batch for raw format, pointed by
> 	Kevin

As I commented in the review, I would like evidence that this is 
necessary.  It should work for all formats IMO.

Paolo

      parent reply	other threads:[~2014-07-01 17:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 16:35 [Qemu-devel] [PATCH v3 0/3] linux-aio: introduce submit I/O at batch Ming Lei
2014-07-01 16:35 ` [Qemu-devel] [PATCH v3 1/4] block: block: introduce bdrv_io_plug() and bdrv_io_unplug() Ming Lei
2014-07-01 16:35 ` [Qemu-devel] [PATCH v3 2/4] block/raw_bsd.c: support io plug and unplug for raw format image Ming Lei
2014-07-01 16:35 ` [Qemu-devel] [PATCH v3 3/4] linux-aio: implement io plug and unplug Ming Lei
2014-07-01 16:35 ` [Qemu-devel] [PATCH v3 4/4] dataplane: submit I/O at batch Ming Lei
2014-07-01 17:15   ` Eric Blake
2014-07-01 17:06 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B2EAA2.1010901@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=ming.lei@canonical.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.