From: Eric Blake <eblake@redhat.com>
To: Ming Lei <ming.lei@canonical.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 4/4] dataplane: submit I/O at batch
Date: Tue, 01 Jul 2014 11:15:53 -0600 [thread overview]
Message-ID: <53B2ECC9.8000400@redhat.com> (raw)
In-Reply-To: <1404232537-28628-5-git-send-email-ming.lei@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 913 bytes --]
On 07/01/2014 10:35 AM, Ming Lei wrote:
> Before commit 580b6b2aa2(dataplane: use the Qemu block
> layer for I/O), dataplane for virtio-blk submits block
> I/O at batch.
s/at/as a/
>
> This commit 580b6b2aa2 replaces the custom linux AIO
> implementation(including I/O batch) with Qemu block
s/(/ (/
> layer, but this commit causes ~40% throughput regression
> on virtio-blk performance, and removing submitting I/O
> at batch is one of the cause.
s/at/as a/
>
> This patch applys the new introduced bdrv_io_plug() and
s/applys/applies/
s/new/newly/
> bdrv_io_unplug() interfaces to support submitting I/O
> at batch for Qemu block layer, and in my test, the change
s/at/as a/
> can improve thoughput by ~30% with 'aio=native'.
s/thoughput/throughput/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-07-01 17:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 16:35 [Qemu-devel] [PATCH v3 0/3] linux-aio: introduce submit I/O at batch Ming Lei
2014-07-01 16:35 ` [Qemu-devel] [PATCH v3 1/4] block: block: introduce bdrv_io_plug() and bdrv_io_unplug() Ming Lei
2014-07-01 16:35 ` [Qemu-devel] [PATCH v3 2/4] block/raw_bsd.c: support io plug and unplug for raw format image Ming Lei
2014-07-01 16:35 ` [Qemu-devel] [PATCH v3 3/4] linux-aio: implement io plug and unplug Ming Lei
2014-07-01 16:35 ` [Qemu-devel] [PATCH v3 4/4] dataplane: submit I/O at batch Ming Lei
2014-07-01 17:15 ` Eric Blake [this message]
2014-07-01 17:06 ` [Qemu-devel] [PATCH v3 0/3] linux-aio: introduce " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B2ECC9.8000400@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.