Re: [Qemu-devel] [RFC PATCH 02/22]

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]

On 07/01/2014 05:18 AM, Pavel Dovgaluk wrote:
> These patches modify virtual hardware to make them deterministic.
> We also implemented saving/restoring for several devices or fixed vm state
> of them to save the fields that we needed for deterministically restoring
> behavior of the devices.
> 
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@gmail.com>
> ---
> 

Please fix your git setup to include diffstats when sending mails.  It
is much easier to review a patch when someone has a feel for which files
are touched and how many lines are involved up front, than when they
have to read the entire email.

Please thread your mails in-reply-to the 0/22 cover letter.

For more tips:
http://wiki.qemu.org/Contribute/SubmitAPatch


> +++ b/include/hw/char/serial.h
> @@ -80,7 +80,7 @@ extern const MemoryRegionOps serial_io_ops;
>  
>  void serial_realize_core(SerialState *s, Error **errp);
>  void serial_exit_core(SerialState *s);
> -void serial_set_frequency(SerialState *s, uint32_t frequency);
> +//void serial_set_frequency(SerialState *s, uint32_t frequency);

No C99 comments (use /* */, not //).  If the code is dead, nuke the line
instead of commenting it out.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]