Re: [Qemu-devel] [PATCH v2 0/4] virtio-blk: fix issues with unified virtio-blk request handling

[Christian Borntraeger <borntraeger@de.ibm.com>]

On 01/07/14 17:25, Stefan Hajnoczi wrote:
> This series fixes issues recently introduced when unifying virtio-blk
> dataplane's request handling with non-dataplane virtio-blk.
> 
> The problems include broken memory allocation for dataplane requests and a
> performance regression for non-dataplane.  See the patches for details.
> 
> Stefan Hajnoczi (4):
>   virtio-blk: avoid dataplane VirtIOBlockReq early free
>   dataplane: do not free VirtQueueElement in vring_push()
>   virtio-blk: avoid g_slice_new0() for VirtIOBlockReq and
>     VirtQueueElement
>   virtio-blk: embed VirtQueueElement in VirtIOBlockReq
> 
>  hw/block/dataplane/virtio-blk.c     | 30 +++++++++++-----------
>  hw/block/virtio-blk.c               | 50 ++++++++++++++++++-------------------
>  hw/virtio/dataplane/vring.c         | 22 ++++++----------
>  include/hw/virtio/dataplane/vring.h |  3 +--
>  include/hw/virtio/virtio-blk.h      |  6 ++++-
>  5 files changed, 53 insertions(+), 58 deletions(-)
> 

I need patches 1 and 2 to make dataplane work.
For both patches
Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>

Would be good to see both patches in master soon. (no opinion about 3 and 4).

Christian