From: Roger Quadros <rogerq@ti.com>
To: paul@pwsan.com, rnayak@ti.com
Cc: tony@atomide.com, nm@ti.com, kishon@ti.com,
george.cherian@ti.com, balbi@ti.com, balajitk@ti.com,
nsekhar@ti.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: DRA7: hwmod: Fixup SATA hwmod
Date: Wed, 2 Jul 2014 14:24:06 +0300 [thread overview]
Message-ID: <53B3EBD6.1090709@ti.com> (raw)
In-Reply-To: <1403093816-10960-3-git-send-email-rogerq@ti.com>
Rajendra,
On 06/18/2014 03:16 PM, Roger Quadros wrote:
> Get rid of optional clock as that is now managed by the
> AHCI platform driver.
>
> Correct .mpu_rt_idx to 1 as the module register space (SYSCONFIG..)
> is passed as the second memory resource in the device tree.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Tested-by: Roger Quadros <rogerq@ti.com>
Need your Ack for this one as well. Thanks.
cheers,
-roger
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index cedef6b..bc42eab 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1292,9 +1292,6 @@ static struct omap_hwmod_class dra7xx_sata_hwmod_class = {
> };
>
> /* sata */
> -static struct omap_hwmod_opt_clk sata_opt_clks[] = {
> - { .role = "ref_clk", .clk = "sata_ref_clk" },
> -};
>
> static struct omap_hwmod dra7xx_sata_hwmod = {
> .name = "sata",
> @@ -1302,6 +1299,7 @@ static struct omap_hwmod dra7xx_sata_hwmod = {
> .clkdm_name = "l3init_clkdm",
> .flags = HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY,
> .main_clk = "func_48m_fclk",
> + .mpu_rt_idx = 1,
> .prcm = {
> .omap4 = {
> .clkctrl_offs = DRA7XX_CM_L3INIT_SATA_CLKCTRL_OFFSET,
> @@ -1309,8 +1307,6 @@ static struct omap_hwmod dra7xx_sata_hwmod = {
> .modulemode = MODULEMODE_SWCTRL,
> },
> },
> - .opt_clks = sata_opt_clks,
> - .opt_clks_cnt = ARRAY_SIZE(sata_opt_clks),
> };
>
> /*
>
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: <paul@pwsan.com>, <rnayak@ti.com>
Cc: <tony@atomide.com>, <nm@ti.com>, <kishon@ti.com>,
<george.cherian@ti.com>, <balbi@ti.com>, <balajitk@ti.com>,
<nsekhar@ti.com>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ARM: DRA7: hwmod: Fixup SATA hwmod
Date: Wed, 2 Jul 2014 14:24:06 +0300 [thread overview]
Message-ID: <53B3EBD6.1090709@ti.com> (raw)
In-Reply-To: <1403093816-10960-3-git-send-email-rogerq@ti.com>
Rajendra,
On 06/18/2014 03:16 PM, Roger Quadros wrote:
> Get rid of optional clock as that is now managed by the
> AHCI platform driver.
>
> Correct .mpu_rt_idx to 1 as the module register space (SYSCONFIG..)
> is passed as the second memory resource in the device tree.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Tested-by: Roger Quadros <rogerq@ti.com>
Need your Ack for this one as well. Thanks.
cheers,
-roger
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index cedef6b..bc42eab 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1292,9 +1292,6 @@ static struct omap_hwmod_class dra7xx_sata_hwmod_class = {
> };
>
> /* sata */
> -static struct omap_hwmod_opt_clk sata_opt_clks[] = {
> - { .role = "ref_clk", .clk = "sata_ref_clk" },
> -};
>
> static struct omap_hwmod dra7xx_sata_hwmod = {
> .name = "sata",
> @@ -1302,6 +1299,7 @@ static struct omap_hwmod dra7xx_sata_hwmod = {
> .clkdm_name = "l3init_clkdm",
> .flags = HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY,
> .main_clk = "func_48m_fclk",
> + .mpu_rt_idx = 1,
> .prcm = {
> .omap4 = {
> .clkctrl_offs = DRA7XX_CM_L3INIT_SATA_CLKCTRL_OFFSET,
> @@ -1309,8 +1307,6 @@ static struct omap_hwmod dra7xx_sata_hwmod = {
> .modulemode = MODULEMODE_SWCTRL,
> },
> },
> - .opt_clks = sata_opt_clks,
> - .opt_clks_cnt = ARRAY_SIZE(sata_opt_clks),
> };
>
> /*
>
next prev parent reply other threads:[~2014-07-02 11:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 12:16 [PATCH 0/2] ARM: DRA7: hwmod: fixes for 3.16 Roger Quadros
2014-06-18 12:16 ` Roger Quadros
2014-06-18 12:16 ` [PATCH 1/2] ARM: DRA7: hwmod: Add OCP2SCP3 module Roger Quadros
2014-06-18 12:16 ` Roger Quadros
2014-06-18 12:34 ` Rajendra Nayak
2014-06-18 12:34 ` Rajendra Nayak
2014-06-18 19:49 ` Roger Quadros
2014-06-18 19:49 ` Roger Quadros
2014-06-18 19:50 ` [PATCH v2 " Roger Quadros
2014-06-18 19:50 ` Roger Quadros
2014-07-02 11:23 ` Roger Quadros
2014-07-02 11:23 ` Roger Quadros
2014-07-03 8:20 ` Rajendra Nayak
2014-07-03 8:20 ` Rajendra Nayak
2014-06-19 5:48 ` [PATCH " Paul Walmsley
2014-06-20 11:20 ` Sekhar Nori
2014-06-20 11:20 ` Sekhar Nori
2014-06-25 17:46 ` Kishon Vijay Abraham I
2014-06-25 17:46 ` Kishon Vijay Abraham I
2014-06-26 9:39 ` Roger Quadros
2014-06-26 9:39 ` Roger Quadros
2014-06-18 12:16 ` [PATCH 2/2] ARM: DRA7: hwmod: Fixup SATA hwmod Roger Quadros
2014-06-18 12:16 ` Roger Quadros
2014-07-02 11:24 ` Roger Quadros [this message]
2014-07-02 11:24 ` Roger Quadros
2014-07-03 8:27 ` Rajendra Nayak
2014-07-03 8:27 ` Rajendra Nayak
2014-06-23 4:57 ` [PATCH 0/2] ARM: DRA7: hwmod: fixes for 3.16 Paul Walmsley
2014-06-23 14:46 ` Sekhar Nori
2014-06-23 14:46 ` Sekhar Nori
2014-06-23 16:34 ` Paul Walmsley
2014-06-24 5:05 ` Sekhar Nori
2014-06-24 5:05 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B3EBD6.1090709@ti.com \
--to=rogerq@ti.com \
--cc=balajitk@ti.com \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.