All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>,
	Tomasz Figa <t.figa@samsung.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Tomasz Stanisławski" <t.stanislaws@samsung.com>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"Mike Turquette" <mturquette@linaro.org>,
	"Wolfram Sang" <wsa@the-dreams.de>,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Lee Jones" <lee.jones@linaro.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: ABBA deadlock in Common Clock Framework
Date: Wed, 02 Jul 2014 14:41:54 +0200	[thread overview]
Message-ID: <53B3FE12.3000608@samsung.com> (raw)
In-Reply-To: <20140702114924.GC3679@tbergstrom-lnx.Nvidia.com>

On 02/07/14 13:49, Peter De Schrijver wrote:
> Or if you use notifiers which use i2c... See also
> http://comments.gmane.org/gmane.linux.kernel/1553699. One workaround is to
> always leave the clock of the i2c controller in a prepared state.

Keeping the clock always prepared might not be that bad, given
prepare/unprepare ops are empty on Exynos and I'd say chances
this ever changes are very low. Now we have just an overhead
of calling to the clock core before and after each single I2C
transfer.

--
Regards,
Sylwester

WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: ABBA deadlock in Common Clock Framework
Date: Wed, 02 Jul 2014 14:41:54 +0200	[thread overview]
Message-ID: <53B3FE12.3000608@samsung.com> (raw)
In-Reply-To: <20140702114924.GC3679@tbergstrom-lnx.Nvidia.com>

On 02/07/14 13:49, Peter De Schrijver wrote:
> Or if you use notifiers which use i2c... See also
> http://comments.gmane.org/gmane.linux.kernel/1553699. One workaround is to
> always leave the clock of the i2c controller in a prepared state.

Keeping the clock always prepared might not be that bad, given
prepare/unprepare ops are empty on Exynos and I'd say chances
this ever changes are very low. Now we have just an overhead
of calling to the clock core before and after each single I2C
transfer.

--
Regards,
Sylwester

  reply	other threads:[~2014-07-02 12:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02 10:59 ABBA deadlock in Common Clock Framework Tomasz Figa
2014-07-02 10:59 ` Tomasz Figa
2014-07-02 11:23 ` Russell King - ARM Linux
2014-07-02 11:23   ` Russell King - ARM Linux
2014-07-02 11:49 ` Peter De Schrijver
2014-07-02 11:49   ` Peter De Schrijver
2014-07-02 12:41   ` Sylwester Nawrocki [this message]
2014-07-02 12:41     ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B3FE12.3000608@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=a.hajda@samsung.com \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=pdeschrijver@nvidia.com \
    --cc=t.figa@samsung.com \
    --cc=t.stanislaws@samsung.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.