Re: [PATCH] do not use --symlink for autoreconf

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1700 bytes --]

On 07/02/2014 02:34 PM, Andre Naujoks wrote:
> On 02.07.2014 14:18, Marc Kleine-Budde wrote:
>> On 07/02/2014 02:12 PM, Andre Naujoks wrote:
>>> When packaging the can-utils, I understand, that the generation
>>> step for autoconf should be done beforehand. However using the
>>> --symlink option in the autoreconf step installs links instead of
>>> the actual files, which leads to a build failure when trying to
>>> build on another host with different autotools installed.
>>>
>>> Signed-off-by: Andre Naujoks <nautsch2@gmail.com>
>>
>> How do you package the can-utils? The usual steps are:
>>
>> ./autogen.sh ./configure make dist
> 
> with git archive. Something like
> 
> git archive --prefix=can-utils-`git describe --always --dirty`/ -o
> can-utils-`git describe --always --dirty`.tar.gz HEAD

AFAIK: git will not archive any files that are not in git, thus no files
generated by autoconf.sh.

> I was not aware of the dist target. Why do I have to configure before
> creating the dist? Isn't the configure step just for adaptations for
> the build-host and target?

Usually you're right, but wihtout the autogen.sh && ./configure run,
there are no makefiles that contian the code for make dist. Note: the
can-utils package hold a handcraftet Makefile for the people who don't
like autotools. And autotools will generate GNUmakefile, which has a
higher priority for gnu make.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 242 bytes --]