From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 1/3] xen/atomic: Introduce common atomic header and update includes
Date: Wed, 2 Jul 2014 15:07:36 +0100 [thread overview]
Message-ID: <53B41228.6030407@citrix.com> (raw)
In-Reply-To: <53B42CC1020000780001F96D@mail.emea.novell.com>
On 02/07/14 15:01, Jan Beulich wrote:
>>>> On 02.07.14 at 15:47, <andrew.cooper3@citrix.com> wrote:
>> --- a/xen/arch/x86/apic.c
>> +++ b/xen/arch/x86/apic.c
>> @@ -28,7 +28,7 @@
>> #include <xen/softirq.h>
>> #include <asm/mc146818rtc.h>
>> #include <asm/msr.h>
>> -#include <asm/atomic.h>
>> +#include <xen/atomic.h>
> I appreciate you having taken the time to replace all these, but - do
> we really need to do this replacement at this point? Especially arch
> code should be fine using the asm/ header instad of the xen/ one.
>
> Jan
>
Not strictly, but I figured it was cleaner to update everything at once
than to have a mix of common and arch specific includes.
(Also it didn't take long at all. `git grep ... | xargs sed` is a
remakably quick refactoring tool, and gcc will quickly tell you if it
went wrong)
~Andrew
next prev parent reply other threads:[~2014-07-02 14:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 13:47 [PATCH v2 0/3] Improvements to allow refcoutning of DOMCTL_{, un}pausedomain Andrew Cooper
2014-07-02 13:47 ` [PATCH v2 1/3] xen/atomic: Introduce common atomic header and update includes Andrew Cooper
2014-07-02 14:01 ` Jan Beulich
2014-07-02 14:07 ` Andrew Cooper [this message]
2014-07-02 13:47 ` [PATCH v2 2/3] xen/atomic: Implement atomic_{inc, dec}_bounded() Andrew Cooper
2014-07-02 14:05 ` Jan Beulich
2014-07-02 14:17 ` Andrew Cooper
2014-07-02 13:47 ` [PATCH v2 3/3] xen/common: Properly reference count DOMCTL_{, un}pausedomain hypercalls Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B41228.6030407@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.