All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: Roger Quadros <rogerq@ti.com>, balbi@ti.com, tony@atomide.com
Cc: kishon@ti.com, george.cherian@ti.com, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-usb@vger.kernel.org, Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH 1/8] CLK: ti: dra7: Initialize USB_DPLL
Date: Wed, 2 Jul 2014 17:23:30 +0300	[thread overview]
Message-ID: <53B415E2.9090203@ti.com> (raw)
In-Reply-To: <1394197751-28984-2-git-send-email-rogerq@ti.com>

On 03/07/2014 03:09 PM, Roger Quadros wrote:
> USB_DPLL must be initialized and locked at boot so that
> USB modules can work.
>
> Also program USB_DLL_M2 output to half rate.
>
> CC: Mike Turquette <mturquette@linaro.org>
> CC: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>   drivers/clk/ti/clk-7xx.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)

Hi,

Resurrecting this patch, as it seems the clock-parenting stuff via DT 
hasn't really moved that much forward.

Thus, this patch has been now queued for 3.17, thanks.

-Tero

>
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index 9977653..f89f3c2 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -18,6 +18,7 @@
>
>   #define DRA7_DPLL_ABE_DEFFREQ				361267200
>   #define DRA7_DPLL_GMAC_DEFFREQ				1000000000
> +#define DRA7_DPLL_USB_DEFFREQ				960000000
>
>
>   static struct ti_dt_clk dra7xx_clks[] = {
> @@ -328,5 +329,15 @@ int __init dra7xx_dt_clk_init(void)
>   	if (rc)
>   		pr_err("%s: failed to configure GMAC DPLL!\n", __func__);
>
> +	dpll_ck = clk_get_sys(NULL, "dpll_usb_ck");
> +	rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ);
> +	if (rc)
> +		pr_err("%s: failed to configure USB DPLL!\n", __func__);
> +
> +	dpll_ck = clk_get_sys(NULL, "dpll_usb_m2_ck");
> +	rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ/2);
> +	if (rc)
> +		pr_err("%s: failed to set USB_DPLL M2 OUT\n", __func__);
> +
>   	return rc;
>   }
>

WARNING: multiple messages have this Message-ID (diff)
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] CLK: ti: dra7: Initialize USB_DPLL
Date: Wed, 2 Jul 2014 17:23:30 +0300	[thread overview]
Message-ID: <53B415E2.9090203@ti.com> (raw)
In-Reply-To: <1394197751-28984-2-git-send-email-rogerq@ti.com>

On 03/07/2014 03:09 PM, Roger Quadros wrote:
> USB_DPLL must be initialized and locked at boot so that
> USB modules can work.
>
> Also program USB_DLL_M2 output to half rate.
>
> CC: Mike Turquette <mturquette@linaro.org>
> CC: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>   drivers/clk/ti/clk-7xx.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)

Hi,

Resurrecting this patch, as it seems the clock-parenting stuff via DT 
hasn't really moved that much forward.

Thus, this patch has been now queued for 3.17, thanks.

-Tero

>
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index 9977653..f89f3c2 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -18,6 +18,7 @@
>
>   #define DRA7_DPLL_ABE_DEFFREQ				361267200
>   #define DRA7_DPLL_GMAC_DEFFREQ				1000000000
> +#define DRA7_DPLL_USB_DEFFREQ				960000000
>
>
>   static struct ti_dt_clk dra7xx_clks[] = {
> @@ -328,5 +329,15 @@ int __init dra7xx_dt_clk_init(void)
>   	if (rc)
>   		pr_err("%s: failed to configure GMAC DPLL!\n", __func__);
>
> +	dpll_ck = clk_get_sys(NULL, "dpll_usb_ck");
> +	rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ);
> +	if (rc)
> +		pr_err("%s: failed to configure USB DPLL!\n", __func__);
> +
> +	dpll_ck = clk_get_sys(NULL, "dpll_usb_m2_ck");
> +	rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ/2);
> +	if (rc)
> +		pr_err("%s: failed to set USB_DPLL M2 OUT\n", __func__);
> +
>   	return rc;
>   }
>

WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: Roger Quadros <rogerq@ti.com>, <balbi@ti.com>, <tony@atomide.com>
Cc: <kishon@ti.com>, <george.cherian@ti.com>,
	<linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-usb@vger.kernel.org>,
	Mike Turquette <mturquette@linaro.org>
Subject: Re: [PATCH 1/8] CLK: ti: dra7: Initialize USB_DPLL
Date: Wed, 2 Jul 2014 17:23:30 +0300	[thread overview]
Message-ID: <53B415E2.9090203@ti.com> (raw)
In-Reply-To: <1394197751-28984-2-git-send-email-rogerq@ti.com>

On 03/07/2014 03:09 PM, Roger Quadros wrote:
> USB_DPLL must be initialized and locked at boot so that
> USB modules can work.
>
> Also program USB_DLL_M2 output to half rate.
>
> CC: Mike Turquette <mturquette@linaro.org>
> CC: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>   drivers/clk/ti/clk-7xx.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)

Hi,

Resurrecting this patch, as it seems the clock-parenting stuff via DT 
hasn't really moved that much forward.

Thus, this patch has been now queued for 3.17, thanks.

-Tero

>
> diff --git a/drivers/clk/ti/clk-7xx.c b/drivers/clk/ti/clk-7xx.c
> index 9977653..f89f3c2 100644
> --- a/drivers/clk/ti/clk-7xx.c
> +++ b/drivers/clk/ti/clk-7xx.c
> @@ -18,6 +18,7 @@
>
>   #define DRA7_DPLL_ABE_DEFFREQ				361267200
>   #define DRA7_DPLL_GMAC_DEFFREQ				1000000000
> +#define DRA7_DPLL_USB_DEFFREQ				960000000
>
>
>   static struct ti_dt_clk dra7xx_clks[] = {
> @@ -328,5 +329,15 @@ int __init dra7xx_dt_clk_init(void)
>   	if (rc)
>   		pr_err("%s: failed to configure GMAC DPLL!\n", __func__);
>
> +	dpll_ck = clk_get_sys(NULL, "dpll_usb_ck");
> +	rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ);
> +	if (rc)
> +		pr_err("%s: failed to configure USB DPLL!\n", __func__);
> +
> +	dpll_ck = clk_get_sys(NULL, "dpll_usb_m2_ck");
> +	rc = clk_set_rate(dpll_ck, DRA7_DPLL_USB_DEFFREQ/2);
> +	if (rc)
> +		pr_err("%s: failed to set USB_DPLL M2 OUT\n", __func__);
> +
>   	return rc;
>   }
>


  parent reply	other threads:[~2014-07-02 14:23 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 13:09 [PATCH 0/8] USB support for DRA7-evm Roger Quadros
2014-03-07 13:09 ` Roger Quadros
2014-03-07 13:09 ` Roger Quadros
2014-03-07 13:09 ` [PATCH 1/8] CLK: ti: dra7: Initialize USB_DPLL Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:43   ` Tero Kristo
2014-03-07 13:43     ` Tero Kristo
2014-03-07 13:43     ` Tero Kristo
2014-03-07 16:55     ` Tony Lindgren
2014-03-07 16:55       ` Tony Lindgren
     [not found]   ` <1394197751-28984-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-03-10 12:49     ` [PATCH v2 1/8] ARM: dts: " Roger Quadros
2014-03-10 12:49       ` Roger Quadros
2014-03-10 12:49       ` Roger Quadros
     [not found]       ` <1394455761-19226-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-03-10 13:28         ` Tero Kristo
2014-03-10 13:28           ` Tero Kristo
2014-03-10 13:28           ` Tero Kristo
2014-03-10 13:32           ` Roger Quadros
2014-03-10 13:32             ` Roger Quadros
2014-03-10 13:32             ` Roger Quadros
2014-07-02 14:23   ` Tero Kristo [this message]
2014-07-02 14:23     ` [PATCH 1/8] CLK: ti: " Tero Kristo
2014-07-02 14:23     ` Tero Kristo
2014-03-07 13:09 ` [PATCH 2/8] ARM: dts: dra7-clock: Add "l3init_960m_gfclk" clock gate Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:59   ` Tero Kristo
2014-03-07 13:59     ` Tero Kristo
2014-03-07 13:59     ` Tero Kristo
2014-03-10 11:05     ` Roger Quadros
2014-03-10 11:05       ` Roger Quadros
2014-03-10 11:05       ` Roger Quadros
2014-03-07 13:09 ` [PATCH 3/8] ARM: DRA7: hwmod: Add SYSCONFIG for usb_otg_ss Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:09 ` [PATCH 4/8] phy: omap-usb2: Use generic clock names "wkupclk" and "refclk" Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:09 ` [PATCH 5/8] phy: omap-usb2: Add clock names to Documentation binding Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 16:04   ` Felipe Balbi
2014-03-07 16:04     ` Felipe Balbi
2014-03-07 16:04     ` Felipe Balbi
2014-03-07 16:23     ` Kishon Vijay Abraham I
2014-03-07 16:23       ` Kishon Vijay Abraham I
2014-03-07 16:23       ` Kishon Vijay Abraham I
2014-03-07 16:24       ` Felipe Balbi
2014-03-07 16:24         ` Felipe Balbi
2014-03-07 16:24         ` Felipe Balbi
2014-03-07 13:09 ` [PATCH 6/8] ARM: dts: omap4+: Add clocks to USB2 PHY node Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:09 ` [PATCH 7/8] ARM: dts: dra7: Add USB related nodes Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-14 10:38   ` Kishon Vijay Abraham I
2014-03-14 10:38     ` Kishon Vijay Abraham I
2014-03-14 10:38     ` Kishon Vijay Abraham I
     [not found]     ` <5322DC0E.1020600-l0cyMroinI0@public.gmane.org>
2014-03-14 12:11       ` Roger Quadros
2014-03-14 12:11         ` Roger Quadros
2014-03-14 12:11         ` Roger Quadros
2014-03-14 14:54         ` Kishon Vijay Abraham I
2014-03-14 14:54           ` Kishon Vijay Abraham I
2014-03-14 14:54           ` Kishon Vijay Abraham I
2014-03-14 15:34           ` Roger Quadros
2014-03-14 15:34             ` Roger Quadros
2014-03-14 15:34             ` Roger Quadros
2014-03-14 19:48             ` Felipe Balbi
2014-03-14 19:48               ` Felipe Balbi
2014-03-14 19:48               ` Felipe Balbi
2014-03-07 13:09 ` [PATCH 8/8] dts: dra7-evm: add USB support Roger Quadros
2014-03-07 13:09   ` Roger Quadros
2014-03-07 13:09   ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B415E2.9090203@ti.com \
    --to=t-kristo@ti.com \
    --cc=balbi@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=george.cherian@ti.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=rogerq@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.