From: Roger Quadros <rogerq@ti.com>
To: Nishanth Menon <nm@ti.com>,
tony@atomide.com, kishon@ti.com, balbi@ti.com
Cc: nsekhar@ti.com, george.cherian@ti.com,
linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Rajendra Nayak <rnayak@ti.com>,
Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH 1/6] ARM: dts: dra7-evm: Make VDDA_1V8_PHY supply always on
Date: Wed, 2 Jul 2014 17:37:00 +0300 [thread overview]
Message-ID: <53B4190C.6040709@ti.com> (raw)
In-Reply-To: <53B403AF.60505@ti.com>
On 07/02/2014 04:05 PM, Nishanth Menon wrote:
> On 07/02/2014 07:03 AM, Roger Quadros wrote:
>> After clarification from the hardware team it was found that
>> this 1.8V PHY supply can't be switched OFF when SoC is Active.
>> It can only be switched off when in PORz (power on reset).
>
> I dont think folks know the reasoning why hardware team decided that
> the voltage rail cannot be switched off -> I suggest adding the
> following information as well.
>
> Since isolation is not present in the design for these PHY IPs to
> allow for the PHY rail to be switched off, there is a very high risk
> of IP reliability and additional leakage paths which can result in
> additional power consumption.
>
> Only scenario where this rail can be switched off is part of Power on
> reset sequencing, but it needs to be kept always-on during operation.
This sort of information should be in the TRM instead, but doesn't harm to be in the commit message so I'll do that.
Thanks.
cheers,
-roger
>
>>
>> This patch is required for proper functionality of USB, SATA
>> and PCIe on DRA7-evm.
>>
>> CC: Rajendra Nayak <rnayak@ti.com>
>> CC: Tero Kristo <t-kristo@ti.com>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> arch/arm/boot/dts/dra7-evm.dts | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>> index 4adc280..8308954 100644
>> --- a/arch/arm/boot/dts/dra7-evm.dts
>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>> @@ -240,6 +240,7 @@
>> regulator-name = "ldo3";
>> regulator-min-microvolt = <1800000>;
>> regulator-max-microvolt = <1800000>;
>> + regulator-always-on;
>> regulator-boot-on;
>> };
>>
>>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Nishanth Menon <nm@ti.com>, <tony@atomide.com>, <kishon@ti.com>,
<balbi@ti.com>
Cc: <nsekhar@ti.com>, <george.cherian@ti.com>,
<linux-omap@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Rajendra Nayak <rnayak@ti.com>,
Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH 1/6] ARM: dts: dra7-evm: Make VDDA_1V8_PHY supply always on
Date: Wed, 2 Jul 2014 17:37:00 +0300 [thread overview]
Message-ID: <53B4190C.6040709@ti.com> (raw)
In-Reply-To: <53B403AF.60505@ti.com>
On 07/02/2014 04:05 PM, Nishanth Menon wrote:
> On 07/02/2014 07:03 AM, Roger Quadros wrote:
>> After clarification from the hardware team it was found that
>> this 1.8V PHY supply can't be switched OFF when SoC is Active.
>> It can only be switched off when in PORz (power on reset).
>
> I dont think folks know the reasoning why hardware team decided that
> the voltage rail cannot be switched off -> I suggest adding the
> following information as well.
>
> Since isolation is not present in the design for these PHY IPs to
> allow for the PHY rail to be switched off, there is a very high risk
> of IP reliability and additional leakage paths which can result in
> additional power consumption.
>
> Only scenario where this rail can be switched off is part of Power on
> reset sequencing, but it needs to be kept always-on during operation.
This sort of information should be in the TRM instead, but doesn't harm to be in the commit message so I'll do that.
Thanks.
cheers,
-roger
>
>>
>> This patch is required for proper functionality of USB, SATA
>> and PCIe on DRA7-evm.
>>
>> CC: Rajendra Nayak <rnayak@ti.com>
>> CC: Tero Kristo <t-kristo@ti.com>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> arch/arm/boot/dts/dra7-evm.dts | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>> index 4adc280..8308954 100644
>> --- a/arch/arm/boot/dts/dra7-evm.dts
>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>> @@ -240,6 +240,7 @@
>> regulator-name = "ldo3";
>> regulator-min-microvolt = <1800000>;
>> regulator-max-microvolt = <1800000>;
>> + regulator-always-on;
>> regulator-boot-on;
>> };
>>
>>
>
>
next prev parent reply other threads:[~2014-07-02 14:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 12:03 [PATCH 0/6] omap: phy: dra7-evm PHY fixes for 3.16 Roger Quadros
2014-07-02 12:03 ` Roger Quadros
2014-07-02 12:03 ` [PATCH 1/6] ARM: dts: dra7-evm: Make VDDA_1V8_PHY supply always on Roger Quadros
2014-07-02 12:03 ` Roger Quadros
2014-07-02 13:05 ` Nishanth Menon
2014-07-02 13:05 ` Nishanth Menon
2014-07-02 14:37 ` Roger Quadros [this message]
2014-07-02 14:37 ` Roger Quadros
2014-07-03 9:40 ` [PATCH v2 " Roger Quadros
2014-07-03 9:40 ` Roger Quadros
2014-07-02 12:03 ` [PATCH 2/6] phy: core: Fix error path in phy_create() Roger Quadros
2014-07-02 12:03 ` Roger Quadros
2014-07-02 12:03 ` [PATCH 3/6] phy: core: Support regulator supply for PHY power Roger Quadros
2014-07-02 12:03 ` Roger Quadros
2014-07-02 12:32 ` Sergei Shtylyov
2014-07-03 8:02 ` Roger Quadros
2014-07-03 8:02 ` Roger Quadros
2014-07-03 9:42 ` [PATCH v2 " Roger Quadros
2014-07-03 9:42 ` Roger Quadros
2014-07-02 12:03 ` [PATCH 4/6] phy: core: Add phy-supply to DT binding documentation Roger Quadros
2014-07-02 12:03 ` Roger Quadros
2014-07-02 12:03 ` [PATCH 5/6] phy: omap-usb2: Balance pm_runtime_enable() on probe failure Roger Quadros
2014-07-02 12:03 ` Roger Quadros
2014-07-03 13:31 ` Kishon Vijay Abraham I
2014-07-03 13:31 ` Kishon Vijay Abraham I
2014-07-03 16:50 ` Roger Quadros
2014-07-03 16:50 ` Roger Quadros
2014-07-02 12:03 ` [PATCH 6/6] ARM: dts: dra7-evm: Add regulator information to USB2 PHYs Roger Quadros
2014-07-02 12:03 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B4190C.6040709@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=rnayak@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.