All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tang Chen <tangchen@cn.fujitsu.com>
To: <gleb@kernel.org>
Cc: Tang Chen <tangchen@cn.fujitsu.com>, <mtosatti@redhat.com>,
	<kvm@vger.kernel.org>, <laijs@cn.fujitsu.com>,
	<isimatu.yasuaki@jp.fujitsu.com>, <guz.fnst@cn.fujitsu.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page.
Date: Thu, 3 Jul 2014 09:17:59 +0800	[thread overview]
Message-ID: <53B4AF47.1080008@cn.fujitsu.com> (raw)
In-Reply-To: <1404291637-15048-1-git-send-email-tangchen@cn.fujitsu.com>

Hi Gleb,

On 07/02/2014 05:00 PM, Tang Chen wrote:
> Hi Gleb, Marcelo,
>
> Please help to review this patch-set.
>
> NOTE: This patch-set doesn't work properly.
>
>
> ept identity pagetable and apic access page in kvm are pinned in memory.
> As a result, they cannot be migrated/hot-removed.
>
> But actually they don't need to be pinned in memory.
>
> This patch-set introduces two new vcpu requests: KVM_REQ_MIGRATE_EPT and KVM_REQ_MIGRATE_APIC.
> These two requests are made when the two pages are migrated by the mmu_notifier
> to reset the related variable to unusable value. And will also be made when
> ept violation happens to reset new pages.
>
>
> [Known problem]
> After this patch-set applied, the two pages can be migrated/hot-removed.
> But after migrating apic access page, the guest died.
>
> The host physical address of apic access page is stored in VMCS. I reset
> it to 0 to stop guest from accessing it when it is unmapped by
> kvm_mmu_notifier_invalidate_page(). And reset it to new page's host physical
> address in tdp_page_fault(). But it seems that guest will access apic page
> directly by the host physical address.

Would you please to give some advice about this problem ?

Thanks.

  parent reply	other threads:[~2014-07-03  1:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02  9:00 [PATCH 0/4] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Tang Chen
2014-07-02  9:00 ` [PATCH 1/4] kvm: Add gfn_to_page_no_pin() Tang Chen
2014-07-02  9:00 ` [PATCH 2/4] kvm: Add macro VMX_APIC_ACCESS_PAGE_ADDR Tang Chen
2014-07-02 16:24   ` Gleb Natapov
2014-07-03  1:19     ` Tang Chen
2014-07-02  9:00 ` [PATCH 3/4] kvm, memory-hotplug: Update ept identity pagetable when it is migrated Tang Chen
2014-07-02 16:34   ` Gleb Natapov
2014-07-03  1:19     ` Tang Chen
2014-07-04  2:36     ` Tang Chen
2014-07-04  9:49       ` Gleb Natapov
2014-07-02  9:00 ` [PATCH 4/4] kvm, mem-hotplug: Update apic access page " Tang Chen
2014-07-03 13:55   ` Gleb Natapov
2014-07-04  2:18     ` Tang Chen
2014-07-04  2:18     ` Tang Chen
2014-07-04 10:13       ` Gleb Natapov
2014-07-07  6:17         ` Tang Chen
2014-07-07  9:52         ` Tang Chen
2014-07-07 11:42           ` Nadav Amit
2014-07-07 11:54             ` Gleb Natapov
2014-07-07 12:10               ` Nadav Amit
2014-07-07 12:15                 ` Gleb Natapov
     [not found]                   ` <1408522330-18009-1-git-send-email-namit@cs.technion.ac.il>
2014-08-20  8:44                     ` [PATCH] KVM: x86: Warn on APIC base relocation Nadav Amit
2014-07-08  1:44                 ` [PATCH 4/4] kvm, mem-hotplug: Update apic access page when it is migrated Tang Chen
2014-07-08  6:46                   ` Nadav Amit
2014-07-07 10:35   ` Wanpeng Li
2014-07-08  9:40     ` Tang Chen
2014-07-03  1:17 ` Tang Chen [this message]
2014-07-03  6:04   ` [PATCH 0/4] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Gleb Natapov
2014-07-04  6:41     ` Tang Chen
  -- strict thread matches above, loose matches on Subject: below --
2014-07-02  9:00 Tang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B4AF47.1080008@cn.fujitsu.com \
    --to=tangchen@cn.fujitsu.com \
    --cc=gleb@kernel.org \
    --cc=guz.fnst@cn.fujitsu.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=kvm@vger.kernel.org \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.