From: Nadav Amit <nadav.amit@gmail.com>
To: Tang Chen <tangchen@cn.fujitsu.com>, Gleb Natapov <gleb@kernel.org>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org, laijs@cn.fujitsu.com,
isimatu.yasuaki@jp.fujitsu.com, guz.fnst@cn.fujitsu.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] kvm, mem-hotplug: Update apic access page when it is migrated.
Date: Mon, 07 Jul 2014 14:42:27 +0300 [thread overview]
Message-ID: <53BA87A3.5020205@gmail.com> (raw)
In-Reply-To: <53BA6DD3.9040400@cn.fujitsu.com>
Tang,
Running some (unrelated) tests I see that KVM does not handle APIC base
relocation correctly. When the base is changed, kvm_lapic_set_base just
changes lapic->base_address without taking further action (i.e.,
modifying the VMCS apic address in VMX).
This patch follows KVM bad behavior by using the constant
VMX_APIC_ACCESS_PAGE_ADDR instead of lapic->base_address.
Anyhow, I didn't see anything that would make my life (in fixing the
lapic base issue) too difficult. Yet, feel free in making it more
"fix-friendly".
Thanks,
Nadav
On 7/7/14, 12:52 PM, Tang Chen wrote:
> Hi Gleb,
>
> The guest hang problem has been solved.
>
> When mmu_notifier is called, I set VMCS APIC_ACCESS_ADDR to the new value
> instead of setting it to 0. And only update kvm->arch.apic_access_page in
> the next ept violation.
>
> The guest is running well now.
>
> I'll post the new patches tomorrow. ;)
>
> Thanks.
>
next prev parent reply other threads:[~2014-07-07 11:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 9:00 [PATCH 0/4] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Tang Chen
2014-07-02 9:00 ` [PATCH 1/4] kvm: Add gfn_to_page_no_pin() Tang Chen
2014-07-02 9:00 ` [PATCH 2/4] kvm: Add macro VMX_APIC_ACCESS_PAGE_ADDR Tang Chen
2014-07-02 16:24 ` Gleb Natapov
2014-07-03 1:19 ` Tang Chen
2014-07-02 9:00 ` [PATCH 3/4] kvm, memory-hotplug: Update ept identity pagetable when it is migrated Tang Chen
2014-07-02 16:34 ` Gleb Natapov
2014-07-03 1:19 ` Tang Chen
2014-07-04 2:36 ` Tang Chen
2014-07-04 9:49 ` Gleb Natapov
2014-07-02 9:00 ` [PATCH 4/4] kvm, mem-hotplug: Update apic access page " Tang Chen
2014-07-03 13:55 ` Gleb Natapov
2014-07-04 2:18 ` Tang Chen
2014-07-04 2:18 ` Tang Chen
2014-07-04 10:13 ` Gleb Natapov
2014-07-07 6:17 ` Tang Chen
2014-07-07 9:52 ` Tang Chen
2014-07-07 11:42 ` Nadav Amit [this message]
2014-07-07 11:54 ` Gleb Natapov
2014-07-07 12:10 ` Nadav Amit
2014-07-07 12:15 ` Gleb Natapov
[not found] ` <1408522330-18009-1-git-send-email-namit@cs.technion.ac.il>
2014-08-20 8:44 ` [PATCH] KVM: x86: Warn on APIC base relocation Nadav Amit
2014-07-08 1:44 ` [PATCH 4/4] kvm, mem-hotplug: Update apic access page when it is migrated Tang Chen
2014-07-08 6:46 ` Nadav Amit
2014-07-07 10:35 ` Wanpeng Li
2014-07-08 9:40 ` Tang Chen
2014-07-03 1:17 ` [PATCH 0/4] kvm, mem-hotplug: Do not pin ept identity pagetable and apic access page Tang Chen
2014-07-03 6:04 ` Gleb Natapov
2014-07-04 6:41 ` Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BA87A3.5020205@gmail.com \
--to=nadav.amit@gmail.com \
--cc=gleb@kernel.org \
--cc=guz.fnst@cn.fujitsu.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kvm@vger.kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.