* [PATCH] ext4: remove readpage() check up for mmap file [not found] <1404273488-4612-1-git-send-email-zhenzhang.zhang@huawei.com> @ 2014-07-02 4:01 ` Zhang Zhen 2014-07-02 15:15 ` Zwisler, Ross 0 siblings, 1 reply; 3+ messages in thread From: Zhang Zhen @ 2014-07-02 4:01 UTC (permalink / raw) To: linux-ext4; +Cc: tytso, Jan Kara There is no kind of file does not supply page reading function. Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> --- fs/ext4/file.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 8695f70..f5c0a17 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -202,8 +202,6 @@ static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma) { struct address_space *mapping = file->f_mapping; - if (!mapping->a_ops->readpage) - return -ENOEXEC; file_accessed(file); vma->vm_ops = &ext4_file_vm_ops; return 0; -- 1.8.1.2 . ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: remove readpage() check up for mmap file 2014-07-02 4:01 ` [PATCH] ext4: remove readpage() check up for mmap file Zhang Zhen @ 2014-07-02 15:15 ` Zwisler, Ross 2014-07-03 1:37 ` Zhang Zhen 0 siblings, 1 reply; 3+ messages in thread From: Zwisler, Ross @ 2014-07-02 15:15 UTC (permalink / raw) To: zhenzhang.zhang@huawei.com Cc: linux-ext4@vger.kernel.org, jack@suse.cz, tytso@mit.edu On Wed, 2014-07-02 at 12:01 +0800, Zhang Zhen wrote: > There is no kind of file does not supply page reading function. > > Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> > --- > fs/ext4/file.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/ext4/file.c b/fs/ext4/file.c > index 8695f70..f5c0a17 100644 > --- a/fs/ext4/file.c > +++ b/fs/ext4/file.c > @@ -202,8 +202,6 @@ static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma) > { > struct address_space *mapping = file->f_mapping; Assuming this change is correct, the 'mapping' variable is now unused and can also be deleted. > > - if (!mapping->a_ops->readpage) > - return -ENOEXEC; > file_accessed(file); > vma->vm_ops = &ext4_file_vm_ops; > return 0; ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext4: remove readpage() check up for mmap file 2014-07-02 15:15 ` Zwisler, Ross @ 2014-07-03 1:37 ` Zhang Zhen 0 siblings, 0 replies; 3+ messages in thread From: Zhang Zhen @ 2014-07-03 1:37 UTC (permalink / raw) To: Zwisler, Ross Cc: linux-ext4@vger.kernel.org, jack@suse.cz, tytso@mit.edu, wangnan0 On 2014/7/2 23:15, Zwisler, Ross wrote: > On Wed, 2014-07-02 at 12:01 +0800, Zhang Zhen wrote: >> There is no kind of file does not supply page reading function. >> >> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> >> --- >> fs/ext4/file.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/fs/ext4/file.c b/fs/ext4/file.c >> index 8695f70..f5c0a17 100644 >> --- a/fs/ext4/file.c >> +++ b/fs/ext4/file.c >> @@ -202,8 +202,6 @@ static int ext4_file_mmap(struct file *file, struct vm_area_struct *vma) >> { >> struct address_space *mapping = file->f_mapping; > > Assuming this change is correct, the 'mapping' variable is now unused and can > also be deleted. > Hi, Thank you for your correction, sorry for my mistake. I will send a new patch. >> >> - if (!mapping->a_ops->readpage) >> - return -ENOEXEC; >> file_accessed(file); >> vma->vm_ops = &ext4_file_vm_ops; >> return 0; > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-03 1:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1404273488-4612-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-07-02 4:01 ` [PATCH] ext4: remove readpage() check up for mmap file Zhang Zhen
2014-07-02 15:15 ` Zwisler, Ross
2014-07-03 1:37 ` Zhang Zhen
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.