Installing an OS with VLAN enabled to an ISCSI LUN (from ibft)

Installing an OS with VLAN enabled to an ISCSI LUN (from ibft)

[Praveen_Paladugu-DYMqY+WieiM]

When installing OS to a VLAN enabled iscsi LUN (extracted from iBFT), "/tmp/net.{xyz}.has_ibft_config" is not being set properly. 

Then anaconda installer requires 'BOOTPROTO="ibft"' populated in ifcfg of the vlan interface (ex: ibft0.20), for it to properly populate the kernel parameters post installation. The setting 'BOOTPROTO="ibft"' is populated by write-ifcfg.sh script only if the corresponding interface has a file /tmp/net.{xyz}.has_inft_config


To get around this issue, in ibft_to_cmdline() function in net-lib.sh file, I made the following changes to populate the has_ibft_config file for the vlan interface(ex: ibft0.20):

diff -up dracut-033/modules.d/40network/net-lib.sh.old dracut-033/modules.d/40network/net-lib.sh
--- dracut-033/modules.d/40network/net-lib.sh.old	2014-06-10 10:21:32.326572725 -0500
+++ dracut-033/modules.d/40network/net-lib.sh	2014-06-10 10:24:28.523422425 -0500
@@ -248,15 +248,19 @@ ibft_to_cmdline() {
                    case "$vlan" in
                        [0-9]*)
                            echo "vlan=$dev.$vlan:$dev"
+                           echo $mac > /tmp/net.${dev}.${vlan}.has_ibft_config
                            ;;
                        *)
                            echo "vlan=$vlan:$dev"
+                           echo $mac > /tmp/net.${dev}.has_ibft_config
                            ;;
                    esac
                fi
+            else
+                echo $mac > /tmp/net.${dev}.has_ibft_config
+                
             fi
 
-            echo $mac > /tmp/net.${dev}.has_ibft_config
         done
     ) >> /etc/cmdline.d/40-ibft.conf
 }


 


Thank you
Praveen K Paladugu
Dell Linux Engineering

RE: Installing an OS with VLAN enabled to an ISCSI LUN (from ibft)

[Praveen_Paladugu-DYMqY+WieiM]

Any comments here?

Thank you
Praveen K Paladugu
Dell Linux Engineering

Re: Installing an OS with VLAN enabled to an ISCSI LUN (from ibft)

[Harald Hoyer]

On 10.06.2014 17:35, Praveen_Paladugu-DYMqY+WieiM@public.gmane.org wrote:
> 
> When installing OS to a VLAN enabled iscsi LUN (extracted from iBFT), "/tmp/net.{xyz}.has_ibft_config" is not being set properly. 
> 
> Then anaconda installer requires 'BOOTPROTO="ibft"' populated in ifcfg of the vlan interface (ex: ibft0.20), for it to properly populate the kernel parameters post installation. The setting 'BOOTPROTO="ibft"' is populated by write-ifcfg.sh script only if the corresponding interface has a file /tmp/net.{xyz}.has_inft_config
> 
> 
> To get around this issue, in ibft_to_cmdline() function in net-lib.sh file, I made the following changes to populate the has_ibft_config file for the vlan interface(ex: ibft0.20):
> 
> diff -up dracut-033/modules.d/40network/net-lib.sh.old dracut-033/modules.d/40network/net-lib.sh
> --- dracut-033/modules.d/40network/net-lib.sh.old	2014-06-10 10:21:32.326572725 -0500
> +++ dracut-033/modules.d/40network/net-lib.sh	2014-06-10 10:24:28.523422425 -0500
> @@ -248,15 +248,19 @@ ibft_to_cmdline() {
>                     case "$vlan" in
>                         [0-9]*)
>                             echo "vlan=$dev.$vlan:$dev"
> +                           echo $mac > /tmp/net.${dev}.${vlan}.has_ibft_config
>                             ;;
>                         *)
>                             echo "vlan=$vlan:$dev"
> +                           echo $mac > /tmp/net.${dev}.has_ibft_config

shouldn't that be:
echo $mac > /tmp/net.${vlan}.has_ibft_config

>                             ;;
>                     esac
>                 fi
> +            else
> +                echo $mac > /tmp/net.${dev}.has_ibft_config
> +                
>              fi
>  
> -            echo $mac > /tmp/net.${dev}.has_ibft_config

what if vlan==0? I would not do this hunk, but only the first one.

RE: Installing an OS with VLAN enabled to an ISCSI LUN (from ibft)

[Praveen_Paladugu-DYMqY+WieiM]

With the current version of Dracut, the below command for all the cases: with vlan populated/not, numerical/not, zero/non-zero.
echo $mac > /tmp/net.${dev}.has_ibft_config



The intent of the patch was to run the below command for all the cases, except when there is a valid numerical vlan detected. 
echo $mac > /tmp/net.${vlan}.has_ibft_config. As long as that happens, I am fine.


Not sure how/why vlan 0 has to be handled differently. 


Thank you
Praveen K Paladugu
Dell Linux Engineering

RE: Installing an OS with VLAN enabled to an ISCSI LUN (from ibft)

[Praveen_Paladugu-DYMqY+WieiM]

Harald, 

This is to confirm the patch https://github.com/haraldh/dracut/commit/f4eb0d98048d51a0782d4a7137f699de174a65e4 works for me. 

Thanks for picking it up. 


Thank you
Praveen K Paladugu
Dell Linux Engineering