Re: [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h

[Tomasz Figa <tomasz.figa@gmail.com>]

Hi Sachin,

On 04.07.2014 10:29, Sachin Kamat wrote:
> On Mon, Jun 23, 2014 at 5:30 PM, Sachin Kamat <sachin.kamat@samsung.com> wrote:
>> PINCTRL_EXYNOS is always selected by Exynos platform in its
>> machine Kconfig. Thus the code in the else part is never used.
>> Remove it.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
>> ---
>>  arch/arm/mach-exynos/common.h |    4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
>> index 1ee91763fa7c..3371669dabc6 100644
>> --- a/arch/arm/mach-exynos/common.h
>> +++ b/arch/arm/mach-exynos/common.h
>> @@ -125,11 +125,7 @@ void exynos_init_late(void);
>>
>>  void exynos_firmware_init(void);
>>
>> -#ifdef CONFIG_PINCTRL_EXYNOS
>>  extern u32 exynos_get_eint_wake_mask(void);
>> -#else
>> -static inline u32 exynos_get_eint_wake_mask(void) { return 0xffffffff; }
>> -#endif
>>
>>  #ifdef CONFIG_PM_SLEEP
>>  extern void __init exynos_pm_init(void);
>> --
>> 1.7.9.5
>>
> 
> Ping..
> 

For this change alone:

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

However I can see much more unused code in that header, more
specifically prototypes of mct_init() (replaced with DT-based init) and
most of other *init*() functions (which are now all in one file). Do you
plan to remove them as well?

Best regards,
Tomasz