* [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h @ 2014-06-23 12:00 Sachin Kamat 2014-07-04 8:29 ` Sachin Kamat 0 siblings, 1 reply; 6+ messages in thread From: Sachin Kamat @ 2014-06-23 12:00 UTC (permalink / raw) To: linux-samsung-soc; +Cc: kgene.kim, tomasz.figa PINCTRL_EXYNOS is always selected by Exynos platform in its machine Kconfig. Thus the code in the else part is never used. Remove it. Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> --- arch/arm/mach-exynos/common.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h index 1ee91763fa7c..3371669dabc6 100644 --- a/arch/arm/mach-exynos/common.h +++ b/arch/arm/mach-exynos/common.h @@ -125,11 +125,7 @@ void exynos_init_late(void); void exynos_firmware_init(void); -#ifdef CONFIG_PINCTRL_EXYNOS extern u32 exynos_get_eint_wake_mask(void); -#else -static inline u32 exynos_get_eint_wake_mask(void) { return 0xffffffff; } -#endif #ifdef CONFIG_PM_SLEEP extern void __init exynos_pm_init(void); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h 2014-06-23 12:00 [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h Sachin Kamat @ 2014-07-04 8:29 ` Sachin Kamat 2014-07-04 8:33 ` Tomasz Figa 0 siblings, 1 reply; 6+ messages in thread From: Sachin Kamat @ 2014-07-04 8:29 UTC (permalink / raw) To: linux-samsung-soc; +Cc: Kukjin Kim, Tomasz Figa On Mon, Jun 23, 2014 at 5:30 PM, Sachin Kamat <sachin.kamat@samsung.com> wrote: > PINCTRL_EXYNOS is always selected by Exynos platform in its > machine Kconfig. Thus the code in the else part is never used. > Remove it. > > Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> > --- > arch/arm/mach-exynos/common.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h > index 1ee91763fa7c..3371669dabc6 100644 > --- a/arch/arm/mach-exynos/common.h > +++ b/arch/arm/mach-exynos/common.h > @@ -125,11 +125,7 @@ void exynos_init_late(void); > > void exynos_firmware_init(void); > > -#ifdef CONFIG_PINCTRL_EXYNOS > extern u32 exynos_get_eint_wake_mask(void); > -#else > -static inline u32 exynos_get_eint_wake_mask(void) { return 0xffffffff; } > -#endif > > #ifdef CONFIG_PM_SLEEP > extern void __init exynos_pm_init(void); > -- > 1.7.9.5 > Ping.. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h 2014-07-04 8:29 ` Sachin Kamat @ 2014-07-04 8:33 ` Tomasz Figa 2014-07-04 8:43 ` Sachin Kamat 2014-07-04 21:53 ` Kukjin Kim 0 siblings, 2 replies; 6+ messages in thread From: Tomasz Figa @ 2014-07-04 8:33 UTC (permalink / raw) To: Sachin Kamat, linux-samsung-soc; +Cc: Kukjin Kim Hi Sachin, On 04.07.2014 10:29, Sachin Kamat wrote: > On Mon, Jun 23, 2014 at 5:30 PM, Sachin Kamat <sachin.kamat@samsung.com> wrote: >> PINCTRL_EXYNOS is always selected by Exynos platform in its >> machine Kconfig. Thus the code in the else part is never used. >> Remove it. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> >> --- >> arch/arm/mach-exynos/common.h | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h >> index 1ee91763fa7c..3371669dabc6 100644 >> --- a/arch/arm/mach-exynos/common.h >> +++ b/arch/arm/mach-exynos/common.h >> @@ -125,11 +125,7 @@ void exynos_init_late(void); >> >> void exynos_firmware_init(void); >> >> -#ifdef CONFIG_PINCTRL_EXYNOS >> extern u32 exynos_get_eint_wake_mask(void); >> -#else >> -static inline u32 exynos_get_eint_wake_mask(void) { return 0xffffffff; } >> -#endif >> >> #ifdef CONFIG_PM_SLEEP >> extern void __init exynos_pm_init(void); >> -- >> 1.7.9.5 >> > > Ping.. > For this change alone: Reviewed-by: Tomasz Figa <t.figa@samsung.com> However I can see much more unused code in that header, more specifically prototypes of mct_init() (replaced with DT-based init) and most of other *init*() functions (which are now all in one file). Do you plan to remove them as well? Best regards, Tomasz ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h 2014-07-04 8:33 ` Tomasz Figa @ 2014-07-04 8:43 ` Sachin Kamat 2014-07-04 8:55 ` Sachin Kamat 2014-07-04 21:53 ` Kukjin Kim 1 sibling, 1 reply; 6+ messages in thread From: Sachin Kamat @ 2014-07-04 8:43 UTC (permalink / raw) To: Tomasz Figa; +Cc: linux-samsung-soc, Kukjin Kim Hi Tomasz, On Fri, Jul 4, 2014 at 2:03 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Sachin, > > On 04.07.2014 10:29, Sachin Kamat wrote: >> On Mon, Jun 23, 2014 at 5:30 PM, Sachin Kamat <sachin.kamat@samsung.com> wrote: >>> PINCTRL_EXYNOS is always selected by Exynos platform in its >>> machine Kconfig. Thus the code in the else part is never used. >>> Remove it. >>> >>> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> >>> --- >>> arch/arm/mach-exynos/common.h | 4 ---- >>> 1 file changed, 4 deletions(-) >>> >>> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h >>> index 1ee91763fa7c..3371669dabc6 100644 >>> --- a/arch/arm/mach-exynos/common.h >>> +++ b/arch/arm/mach-exynos/common.h >>> @@ -125,11 +125,7 @@ void exynos_init_late(void); >>> >>> void exynos_firmware_init(void); >>> >>> -#ifdef CONFIG_PINCTRL_EXYNOS >>> extern u32 exynos_get_eint_wake_mask(void); >>> -#else >>> -static inline u32 exynos_get_eint_wake_mask(void) { return 0xffffffff; } >>> -#endif >>> >>> #ifdef CONFIG_PM_SLEEP >>> extern void __init exynos_pm_init(void); >>> -- >>> 1.7.9.5 >>> >> >> Ping.. >> > > For this change alone: > > Reviewed-by: Tomasz Figa <t.figa@samsung.com> Thanks. > > However I can see much more unused code in that header, more > specifically prototypes of mct_init() (replaced with DT-based init) and > most of other *init*() functions (which are now all in one file). Do you > plan to remove them as well? Sure. I will remove those too. Regards, Sachin. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h 2014-07-04 8:43 ` Sachin Kamat @ 2014-07-04 8:55 ` Sachin Kamat 0 siblings, 0 replies; 6+ messages in thread From: Sachin Kamat @ 2014-07-04 8:55 UTC (permalink / raw) To: Tomasz Figa; +Cc: linux-samsung-soc, Kukjin Kim Hi Tomasz, On Fri, Jul 4, 2014 at 2:13 PM, Sachin Kamat <sachin.kamat@samsung.com> wrote: > Hi Tomasz, > > On Fri, Jul 4, 2014 at 2:03 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: >> Hi Sachin, >> >> On 04.07.2014 10:29, Sachin Kamat wrote: >>> On Mon, Jun 23, 2014 at 5:30 PM, Sachin Kamat <sachin.kamat@samsung.com> wrote: >>>> PINCTRL_EXYNOS is always selected by Exynos platform in its >>>> machine Kconfig. Thus the code in the else part is never used. >>>> Remove it. >>>> >>>> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> >>>> --- >>>> arch/arm/mach-exynos/common.h | 4 ---- >>>> 1 file changed, 4 deletions(-) >>>> >>>> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h >>>> index 1ee91763fa7c..3371669dabc6 100644 >>>> --- a/arch/arm/mach-exynos/common.h >>>> +++ b/arch/arm/mach-exynos/common.h >>>> @@ -125,11 +125,7 @@ void exynos_init_late(void); >>>> >>>> void exynos_firmware_init(void); >>>> >>>> -#ifdef CONFIG_PINCTRL_EXYNOS >>>> extern u32 exynos_get_eint_wake_mask(void); >>>> -#else >>>> -static inline u32 exynos_get_eint_wake_mask(void) { return 0xffffffff; } >>>> -#endif >>>> >>>> #ifdef CONFIG_PM_SLEEP >>>> extern void __init exynos_pm_init(void); >>>> -- >>>> 1.7.9.5 >>>> >>> >>> Ping.. >>> >> >> For this change alone: >> >> Reviewed-by: Tomasz Figa <t.figa@samsung.com> > > Thanks. > >> >> However I can see much more unused code in that header, more >> specifically prototypes of mct_init() (replaced with DT-based init) and >> most of other *init*() functions (which are now all in one file). Do you >> plan to remove them as well? > > Sure. I will remove those too. Some of the things that you suggested are already taken care of in the patch at [1]. So will keep my patch in the current format and later if something else is needed will send separate patch to avoid merge conflicts. What say? [1] https://lkml.org/lkml/2014/6/25/375 Regards, Sachin. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h 2014-07-04 8:33 ` Tomasz Figa 2014-07-04 8:43 ` Sachin Kamat @ 2014-07-04 21:53 ` Kukjin Kim 1 sibling, 0 replies; 6+ messages in thread From: Kukjin Kim @ 2014-07-04 21:53 UTC (permalink / raw) To: Tomasz Figa; +Cc: Sachin Kamat, linux-samsung-soc, Kukjin Kim On 07/04/14 17:33, Tomasz Figa wrote: > Hi Sachin, > > On 04.07.2014 10:29, Sachin Kamat wrote: >> On Mon, Jun 23, 2014 at 5:30 PM, Sachin Kamat<sachin.kamat@samsung.com> wrote: >>> PINCTRL_EXYNOS is always selected by Exynos platform in its >>> machine Kconfig. Thus the code in the else part is never used. >>> Remove it. >>> >>> Signed-off-by: Sachin Kamat<sachin.kamat@samsung.com> >>> --- >>> arch/arm/mach-exynos/common.h | 4 ---- >>> 1 file changed, 4 deletions(-) >>> >>> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h >>> index 1ee91763fa7c..3371669dabc6 100644 >>> --- a/arch/arm/mach-exynos/common.h >>> +++ b/arch/arm/mach-exynos/common.h >>> @@ -125,11 +125,7 @@ void exynos_init_late(void); >>> >>> void exynos_firmware_init(void); >>> >>> -#ifdef CONFIG_PINCTRL_EXYNOS >>> extern u32 exynos_get_eint_wake_mask(void); >>> -#else >>> -static inline u32 exynos_get_eint_wake_mask(void) { return 0xffffffff; } >>> -#endif >>> >>> #ifdef CONFIG_PM_SLEEP >>> extern void __init exynos_pm_init(void); >>> -- >>> 1.7.9.5 >>> >> >> Ping.. >> > > For this change alone: > > Reviewed-by: Tomasz Figa<t.figa@samsung.com> > Applied, thanks. - Kukjin > However I can see much more unused code in that header, more > specifically prototypes of mct_init() (replaced with DT-based init) and > most of other *init*() functions (which are now all in one file). Do you > plan to remove them as well? ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-04 21:54 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-06-23 12:00 [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h Sachin Kamat 2014-07-04 8:29 ` Sachin Kamat 2014-07-04 8:33 ` Tomasz Figa 2014-07-04 8:43 ` Sachin Kamat 2014-07-04 8:55 ` Sachin Kamat 2014-07-04 21:53 ` Kukjin Kim
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.