Re: [xen-unstable test] 28813: regressions - trouble: blocked/broken/fail/pass

[Jim Fehlig <jfehlig@suse.com>]

Ian Campbell wrote:
> On Fri, 2014-07-04 at 11:35 +0100, xen.org wrote:
>   
>> flight 28813 xen-unstable real [real]
>> http://www.chiark.greenend.org.uk/~xensrcts/logs/28813/
>>
>> Regressions :-(
>>
>> Tests which did not succeed and are blocking,
>> including tests which could not be run:
>>  build-i386-libvirt            5 libvirt-build             fail REGR. vs. 27467
>>  build-amd64-libvirt           5 libvirt-build             fail REGR. vs. 27467
>>  build-armhf-libvirt           5 libvirt-build             fail REGR. vs. 27467
>>     
>
> http://www.chiark.greenend.org.uk/~xensrcts/logs/28813/build-amd64-libvirt/5.ts-libvirt-build.log shows:
>
>   CC     libxl/libvirt_driver_libxl_impl_la-libxl_driver.lo
> libxl/libxl_domain.c: In function 'libxlDomainSetVcpuAffinities':
> libxl/libxl_domain.c:1032:9: error: too few arguments to function 'libxl_set_vcpuaffinity'
> In file included from libxl/libxl_domain.h:27:0,
>                  from libxl/libxl_domain.c:28:
> /home/osstest/build.28813.build-amd64-libvirt/xendist/usr/local/include/libxl.h:1180:5: note: declared here
>
>
> And http://www.chiark.greenend.org.uk/~xensrcts/logs/28813/build-amd64-libvirt/info.html shows:
>                 revision_libvirt
>         b963ca06d4b99e8db71c85b8800aae3c99de6bcb
>
> So I suppose:
>         commit 9375ba2a6e0c1dba9e9e6feb1b4a698b64c47085
>         Author: Dario Faggioli <dario.faggioli@citrix.com>
>         Date:   Fri Dec 20 16:01:46 2013 +0100
>         
>             libxl: correctly handle affinity reset in virDomainPinVcpu[Flags]
>
> wasn't as effective as we had hoped :-(
>
> I suppose the issue is that this patch was only against
> src/libxl/libxl_driver.c and not libxl/libxl_domain.c
>   

Dario's patch re-defined the functions, with the intent of not needing
to adjust all call sites

# ifdef LIBXL_HAVE_VCPUINFO_SOFT_AFFINITY
#  define libxl_set_vcpuaffinity(ctx, domid, vcpuid, map) \
    libxl_set_vcpuaffinity((ctx), (domid), (vcpuid), (map), NULL)
#  define libxl_set_vcpuaffinity_all(ctx, domid, max_vcpus, map) \
    libxl_set_vcpuaffinity_all((ctx), (domid), (max_vcpus), (map), NULL)
# endif

I'll have to look at this later in the weekend.  It is a holiday here
and I'm about to head out the door.

Regards,
Jim