All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
	kvm@vger.kernel.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>
Subject: Re: [PATCH for-2.1] target-i386: Add "kvmclock-stable-bit" feature bit name
Date: Sat, 05 Jul 2014 11:54:10 +0200	[thread overview]
Message-ID: <53B7CB42.5060609@redhat.com> (raw)
In-Reply-To: <1404503074-6381-1-git-send-email-ehabkost@redhat.com>

Il 04/07/2014 21:44, Eduardo Habkost ha scritto:
> KVM_FEATURE_CLOCKSOURCE_STABLE_BIT is enabled by default and supported
> by KVM. But not having a name defined makes QEMU treat it as an unknown
> and unmigratable feature flag (as any unknown feature may possibly
> require state to be migrated), and disable it by default on "-cpu host".
>
> As a side-effect, the new name also makes the flag configurable,
> allowing the user to disable it (which may be useful for testing or for
> compatibility with old kernels).
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 45c662d..6d008ab 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -241,7 +241,7 @@ static const char *kvm_feature_name[] = {
>      NULL, NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
> -    NULL, NULL, NULL, NULL,
> +    "kvmclock-stable-bit", NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
>  };
>
>

Applied to uq/master, thanks.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
	kvm@vger.kernel.org
Cc: Igor Mammedov <imammedo@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.1] target-i386: Add "kvmclock-stable-bit" feature bit name
Date: Sat, 05 Jul 2014 11:54:10 +0200	[thread overview]
Message-ID: <53B7CB42.5060609@redhat.com> (raw)
In-Reply-To: <1404503074-6381-1-git-send-email-ehabkost@redhat.com>

Il 04/07/2014 21:44, Eduardo Habkost ha scritto:
> KVM_FEATURE_CLOCKSOURCE_STABLE_BIT is enabled by default and supported
> by KVM. But not having a name defined makes QEMU treat it as an unknown
> and unmigratable feature flag (as any unknown feature may possibly
> require state to be migrated), and disable it by default on "-cpu host".
>
> As a side-effect, the new name also makes the flag configurable,
> allowing the user to disable it (which may be useful for testing or for
> compatibility with old kernels).
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  target-i386/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index 45c662d..6d008ab 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -241,7 +241,7 @@ static const char *kvm_feature_name[] = {
>      NULL, NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
> -    NULL, NULL, NULL, NULL,
> +    "kvmclock-stable-bit", NULL, NULL, NULL,
>      NULL, NULL, NULL, NULL,
>  };
>
>

Applied to uq/master, thanks.

Paolo

  reply	other threads:[~2014-07-05  9:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-04 19:44 [PATCH for-2.1] target-i386: Add "kvmclock-stable-bit" feature bit name Eduardo Habkost
2014-07-04 19:44 ` [Qemu-devel] " Eduardo Habkost
2014-07-05  9:54 ` Paolo Bonzini [this message]
2014-07-05  9:54   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B7CB42.5060609@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.