From: Guenter Roeck <linux@roeck-us.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org, Nick <xerofoify@gmail.com>
Subject: Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
Date: Mon, 07 Jul 2014 20:03:54 -0700 [thread overview]
Message-ID: <53BB5F9A.2060105@roeck-us.net> (raw)
In-Reply-To: <1404153930-26568-1-git-send-email-linux@roeck-us.net>
ping ...
Ben, I know this is not perfect, but on the other side it is simple
and would be easy to backport. With this in place, a complete/clean
fix would not be as urgent. Any chance to get it applied ?
Nick, this doesn't fix the allyesconfig build - it still fails with
relocation errors. But it does fix the allmodconfig build.
Thanks,
Guenter
On 06/30/2014 11:45 AM, Guenter Roeck wrote:
> powerpc:allmodconfig has been failing for some time with the following
> error.
>
> arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
> arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
> make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
>
> A number of attempts to fix the problem by moving around code have been
> unsuccessful and resulted in failed builds for some configurations and
> the discovery of toolchain bugs.
>
> Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
> While this is less than perfect, it avoids substantial code changes
> which would otherwise be necessary just to make COMPILE_TEST builds
> happy and might have undesired side effects.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/powerpc/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index bd6dd6e..fefe7c8 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -414,7 +414,7 @@ config KEXEC
> config CRASH_DUMP
> bool "Build a kdump crash kernel"
> depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
> - select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
> + select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
> help
> Build a kernel suitable for use as a kdump capture kernel.
> The same kernel binary can be used as production kernel and dump
> @@ -1017,6 +1017,7 @@ endmenu
> if PPC64
> config RELOCATABLE
> bool "Build a relocatable kernel"
> + depends on !COMPILE_TEST
> select NONSTATIC_KERNEL
> help
> This builds a kernel image that is capable of running anywhere
>
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Nick <xerofoify@gmail.com>
Subject: Re: [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64
Date: Mon, 07 Jul 2014 20:03:54 -0700 [thread overview]
Message-ID: <53BB5F9A.2060105@roeck-us.net> (raw)
In-Reply-To: <1404153930-26568-1-git-send-email-linux@roeck-us.net>
ping ...
Ben, I know this is not perfect, but on the other side it is simple
and would be easy to backport. With this in place, a complete/clean
fix would not be as urgent. Any chance to get it applied ?
Nick, this doesn't fix the allyesconfig build - it still fails with
relocation errors. But it does fix the allmodconfig build.
Thanks,
Guenter
On 06/30/2014 11:45 AM, Guenter Roeck wrote:
> powerpc:allmodconfig has been failing for some time with the following
> error.
>
> arch/powerpc/kernel/exceptions-64s.S: Assembler messages:
> arch/powerpc/kernel/exceptions-64s.S:1312: Error: attempt to move .org backwards
> make[1]: *** [arch/powerpc/kernel/head_64.o] Error 1
>
> A number of attempts to fix the problem by moving around code have been
> unsuccessful and resulted in failed builds for some configurations and
> the discovery of toolchain bugs.
>
> Fix the problem by disabling RELOCATABLE for COMPILE_TEST builds instead.
> While this is less than perfect, it avoids substantial code changes
> which would otherwise be necessary just to make COMPILE_TEST builds
> happy and might have undesired side effects.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> arch/powerpc/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index bd6dd6e..fefe7c8 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -414,7 +414,7 @@ config KEXEC
> config CRASH_DUMP
> bool "Build a kdump crash kernel"
> depends on PPC64 || 6xx || FSL_BOOKE || (44x && !SMP)
> - select RELOCATABLE if PPC64 || 44x || FSL_BOOKE
> + select RELOCATABLE if (PPC64 && !COMPILE_TEST) || 44x || FSL_BOOKE
> help
> Build a kernel suitable for use as a kdump capture kernel.
> The same kernel binary can be used as production kernel and dump
> @@ -1017,6 +1017,7 @@ endmenu
> if PPC64
> config RELOCATABLE
> bool "Build a relocatable kernel"
> + depends on !COMPILE_TEST
> select NONSTATIC_KERNEL
> help
> This builds a kernel image that is capable of running anywhere
>
next prev parent reply other threads:[~2014-07-08 3:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 18:45 [PATCH] powerpc: Disable RELOCATABLE for COMPILE_TEST with PPC64 Guenter Roeck
2014-06-30 18:45 ` Guenter Roeck
2014-07-01 0:55 ` Stephen Rothwell
2014-07-01 0:55 ` Stephen Rothwell
2014-07-01 2:22 ` Guenter Roeck
2014-07-01 2:22 ` Guenter Roeck
2014-07-04 19:51 ` Guenter Roeck
2014-07-04 19:51 ` Guenter Roeck
2014-07-08 3:03 ` Guenter Roeck [this message]
2014-07-08 3:03 ` Guenter Roeck
2014-07-08 3:10 ` Benjamin Herrenschmidt
2014-07-08 3:10 ` Benjamin Herrenschmidt
2014-07-13 6:02 ` Nick Krause
2014-07-13 6:02 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BB5F9A.2060105@roeck-us.net \
--to=linux@roeck-us.net \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.