From: George Dunlap <george.dunlap@eu.citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH 2/2] make: Make "src-tarball" target actually make a source tarball
Date: Tue, 8 Jul 2014 12:00:11 +0100 [thread overview]
Message-ID: <53BBCF3B.3030507@eu.citrix.com> (raw)
In-Reply-To: <21435.48893.415492.386853@mariner.uk.xensource.com>
On 07/08/2014 10:50 AM, Ian Jackson wrote:
> George Dunlap writes ("Re: [PATCH 2/2] make: Make "src-tarball" target actually make a source tarball"):
>> On 07/03/2014 09:29 AM, Ian Campbell wrote:
>>> FWIW I think you could avoid much of this pushd/popd stuff with tar -C
>>> and git --git-dir= (perhaps --work-dir, not sure for git archive).
>>
>> The --git-dir think seemed to work differently enough to hg's "-C"
>> option that I didn't really trust it. If you think it's better I can
>> try to work it out.
>
> Firstly, thanks for cleaning up this area, which sorely needs it.
>
> Please don't. I wouldn't really trust it either :-).
>
> Instead of pushd/popd, you might consider ( ).
Well I've rewritten it with --git-dir already, and it looks a lot
cleaner. I'll send that version and you can see what you think.
(May be a few days.)
-George
next prev parent reply other threads:[~2014-07-08 11:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 16:15 [PATCH 1/2] make: Check tools/qemu-xen[-traditional] for qemu before downloading George Dunlap
2014-07-02 16:15 ` [PATCH 2/2] make: Make "src-tarball" target actually make a source tarball George Dunlap
2014-07-03 8:29 ` Ian Campbell
2014-07-03 12:48 ` George Dunlap
2014-07-03 13:46 ` Ian Campbell
2014-07-08 9:50 ` Ian Jackson
2014-07-08 11:00 ` George Dunlap [this message]
2014-07-03 11:22 ` Anthony PERARD
2014-07-03 11:25 ` George Dunlap
2014-07-03 8:25 ` [PATCH 1/2] make: Check tools/qemu-xen[-traditional] for qemu before downloading Ian Campbell
2014-07-03 9:04 ` George Dunlap
2014-07-03 9:10 ` Ian Campbell
2014-07-08 9:57 ` Ian Jackson
2014-07-08 10:57 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BBCF3B.3030507@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.