* [PATCH] ARM: Samsung: ADC: Move to clk_prepare_enable/clk_disable_unprepare
@ 2014-06-30 19:08 ` Vasily Khoruzhick
0 siblings, 0 replies; 6+ messages in thread
From: Vasily Khoruzhick @ 2014-06-30 19:08 UTC (permalink / raw)
To: Kukjin Kim, linux-arm-kernel, linux-samsung-soc, Ben Dooks
Cc: Vasily Khoruzhick
Use clk_prepare_enable/clk_disable_unprepare to make the driver
work properly with common clock framework.
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
arch/arm/plat-samsung/adc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/plat-samsung/adc.c b/arch/arm/plat-samsung/adc.c
index 79690f2..c5831b49 100644
--- a/arch/arm/plat-samsung/adc.c
+++ b/arch/arm/plat-samsung/adc.c
@@ -389,7 +389,7 @@ static int s3c_adc_probe(struct platform_device *pdev)
if (ret)
return ret;
- clk_enable(adc->clk);
+ clk_prepare_enable(adc->clk);
tmp = adc->prescale | S3C2410_ADCCON_PRSCEN;
@@ -413,7 +413,7 @@ static int s3c_adc_remove(struct platform_device *pdev)
{
struct adc_device *adc = platform_get_drvdata(pdev);
- clk_disable(adc->clk);
+ clk_disable_unprepare(adc->clk);
regulator_disable(adc->vdd);
return 0;
@@ -436,7 +436,7 @@ static int s3c_adc_suspend(struct device *dev)
disable_irq(adc->irq);
spin_unlock_irqrestore(&adc->lock, flags);
- clk_disable(adc->clk);
+ clk_disable_unprepare(adc->clk);
regulator_disable(adc->vdd);
return 0;
@@ -454,7 +454,7 @@ static int s3c_adc_resume(struct device *dev)
ret = regulator_enable(adc->vdd);
if (ret)
return ret;
- clk_enable(adc->clk);
+ clk_prepare_enable(adc->clk);
enable_irq(adc->irq);
tmp = adc->prescale | S3C2410_ADCCON_PRSCEN;
--
2.0.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: Samsung: ADC: Move to clk_prepare_enable/clk_disable_unprepare
@ 2014-06-30 19:08 ` Vasily Khoruzhick
0 siblings, 0 replies; 6+ messages in thread
From: Vasily Khoruzhick @ 2014-06-30 19:08 UTC (permalink / raw)
To: linux-arm-kernel
Use clk_prepare_enable/clk_disable_unprepare to make the driver
work properly with common clock framework.
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
arch/arm/plat-samsung/adc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/plat-samsung/adc.c b/arch/arm/plat-samsung/adc.c
index 79690f2..c5831b49 100644
--- a/arch/arm/plat-samsung/adc.c
+++ b/arch/arm/plat-samsung/adc.c
@@ -389,7 +389,7 @@ static int s3c_adc_probe(struct platform_device *pdev)
if (ret)
return ret;
- clk_enable(adc->clk);
+ clk_prepare_enable(adc->clk);
tmp = adc->prescale | S3C2410_ADCCON_PRSCEN;
@@ -413,7 +413,7 @@ static int s3c_adc_remove(struct platform_device *pdev)
{
struct adc_device *adc = platform_get_drvdata(pdev);
- clk_disable(adc->clk);
+ clk_disable_unprepare(adc->clk);
regulator_disable(adc->vdd);
return 0;
@@ -436,7 +436,7 @@ static int s3c_adc_suspend(struct device *dev)
disable_irq(adc->irq);
spin_unlock_irqrestore(&adc->lock, flags);
- clk_disable(adc->clk);
+ clk_disable_unprepare(adc->clk);
regulator_disable(adc->vdd);
return 0;
@@ -454,7 +454,7 @@ static int s3c_adc_resume(struct device *dev)
ret = regulator_enable(adc->vdd);
if (ret)
return ret;
- clk_enable(adc->clk);
+ clk_prepare_enable(adc->clk);
enable_irq(adc->irq);
tmp = adc->prescale | S3C2410_ADCCON_PRSCEN;
--
2.0.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: Samsung: ADC: Move to clk_prepare_enable/clk_disable_unprepare
2014-06-30 19:08 ` Vasily Khoruzhick
@ 2014-07-08 11:49 ` Tomasz Figa
-1 siblings, 0 replies; 6+ messages in thread
From: Tomasz Figa @ 2014-07-08 11:49 UTC (permalink / raw)
To: Vasily Khoruzhick, Kukjin Kim, linux-arm-kernel,
linux-samsung-soc, Ben Dooks
Hi Vasily,
On 30.06.2014 21:08, Vasily Khoruzhick wrote:
> Use clk_prepare_enable/clk_disable_unprepare to make the driver
> work properly with common clock framework.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> arch/arm/plat-samsung/adc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
--
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: Samsung: ADC: Move to clk_prepare_enable/clk_disable_unprepare
@ 2014-07-08 11:49 ` Tomasz Figa
0 siblings, 0 replies; 6+ messages in thread
From: Tomasz Figa @ 2014-07-08 11:49 UTC (permalink / raw)
To: linux-arm-kernel
Hi Vasily,
On 30.06.2014 21:08, Vasily Khoruzhick wrote:
> Use clk_prepare_enable/clk_disable_unprepare to make the driver
> work properly with common clock framework.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> arch/arm/plat-samsung/adc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
--
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] ARM: Samsung: ADC: Move to clk_prepare_enable/clk_disable_unprepare
2014-07-08 11:49 ` Tomasz Figa
@ 2014-07-08 14:17 ` Kukjin Kim
-1 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2014-07-08 14:17 UTC (permalink / raw)
To: 'Tomasz Figa', 'Vasily Khoruzhick',
linux-arm-kernel, linux-samsung-soc, 'Ben Dooks'
Tomasz Figa wrote:
>
> Hi Vasily,
>
> On 30.06.2014 21:08, Vasily Khoruzhick wrote:
> > Use clk_prepare_enable/clk_disable_unprepare to make the driver
> > work properly with common clock framework.
> >
> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> > ---
> > arch/arm/plat-samsung/adc.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>
Looks good to me, will apply.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: Samsung: ADC: Move to clk_prepare_enable/clk_disable_unprepare
@ 2014-07-08 14:17 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2014-07-08 14:17 UTC (permalink / raw)
To: linux-arm-kernel
Tomasz Figa wrote:
>
> Hi Vasily,
>
> On 30.06.2014 21:08, Vasily Khoruzhick wrote:
> > Use clk_prepare_enable/clk_disable_unprepare to make the driver
> > work properly with common clock framework.
> >
> > Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> > ---
> > arch/arm/plat-samsung/adc.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>
Looks good to me, will apply.
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-08 14:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-30 19:08 [PATCH] ARM: Samsung: ADC: Move to clk_prepare_enable/clk_disable_unprepare Vasily Khoruzhick
2014-06-30 19:08 ` Vasily Khoruzhick
2014-07-08 11:49 ` Tomasz Figa
2014-07-08 11:49 ` Tomasz Figa
2014-07-08 14:17 ` Kukjin Kim
2014-07-08 14:17 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.