All of lore.kernel.org
 help / color / mirror / Atom feed
* [refpolicy] [PATCH] ftp: fix labels in /var/lock/subsys/
@ 2014-07-05 16:42 Nicolas Iooss
  2014-07-08 12:55 ` Christopher J. PeBenito
  0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Iooss @ 2014-07-05 16:42 UTC (permalink / raw)
  To: refpolicy

In the pattern "/var/lock/subsys/*.ftpd", the star is applied to the
slash instead to the dot.  This means that the pattern matches these
files:

* "Xftpd" in "/var/lock/subsys/" (where X is whatever character)
* "subsysXftpd" in "/var/lock/" (where X is whatever character)

"/var/lock/subsys/vsftpd", which has been used by vsftpd, is therefore
not matched by the pattern.

As "*." looks like a typo, this patch replaces it with ".*".
---
 ftp.fc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ftp.fc b/ftp.fc
index ddb75c1..fa132af 100644
--- a/ftp.fc
+++ b/ftp.fc
@@ -19,7 +19,7 @@
 
 /usr/libexec/webmin/vsftpd/webalizer/xfer_log	--	gen_context(system_u:object_r:xferlog_t,s0)
 
-/var/lock/subsys/*.ftpd	--	gen_context(system_u:object_r:ftpd_lock_t,s0)
+/var/lock/subsys/.*ftpd	--	gen_context(system_u:object_r:ftpd_lock_t,s0)
 
 /var/log/muddleftpd\.log.*	--	gen_context(system_u:object_r:xferlog_t,s0)
 /var/log/proftpd(/.*)?	gen_context(system_u:object_r:xferlog_t,s0)
-- 
2.0.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [refpolicy] [PATCH] ftp: fix labels in /var/lock/subsys/
  2014-07-05 16:42 [refpolicy] [PATCH] ftp: fix labels in /var/lock/subsys/ Nicolas Iooss
@ 2014-07-08 12:55 ` Christopher J. PeBenito
  0 siblings, 0 replies; 2+ messages in thread
From: Christopher J. PeBenito @ 2014-07-08 12:55 UTC (permalink / raw)
  To: refpolicy

On 7/5/2014 12:42 PM, Nicolas Iooss wrote:
> In the pattern "/var/lock/subsys/*.ftpd", the star is applied to the
> slash instead to the dot.  This means that the pattern matches these
> files:
> 
> * "Xftpd" in "/var/lock/subsys/" (where X is whatever character)
> * "subsysXftpd" in "/var/lock/" (where X is whatever character)
> 
> "/var/lock/subsys/vsftpd", which has been used by vsftpd, is therefore
> not matched by the pattern.
> 
> As "*." looks like a typo, this patch replaces it with ".*".

Merged.


> ---
>  ftp.fc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ftp.fc b/ftp.fc
> index ddb75c1..fa132af 100644
> --- a/ftp.fc
> +++ b/ftp.fc
> @@ -19,7 +19,7 @@
>  
>  /usr/libexec/webmin/vsftpd/webalizer/xfer_log	--	gen_context(system_u:object_r:xferlog_t,s0)
>  
> -/var/lock/subsys/*.ftpd	--	gen_context(system_u:object_r:ftpd_lock_t,s0)
> +/var/lock/subsys/.*ftpd	--	gen_context(system_u:object_r:ftpd_lock_t,s0)
>  
>  /var/log/muddleftpd\.log.*	--	gen_context(system_u:object_r:xferlog_t,s0)
>  /var/log/proftpd(/.*)?	gen_context(system_u:object_r:xferlog_t,s0)
> 

-- 
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-08 12:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-05 16:42 [refpolicy] [PATCH] ftp: fix labels in /var/lock/subsys/ Nicolas Iooss
2014-07-08 12:55 ` Christopher J. PeBenito

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.