All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: KY Srinivasan <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>
Cc: "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hyperv: Add netpoll support
Date: Tue, 08 Jul 2014 22:16:52 +0200	[thread overview]
Message-ID: <53BC51B4.4010703@nod.at> (raw)
In-Reply-To: <b2835410139848be8811403e3d7fa708@BY2PR03MB299.namprd03.prod.outlook.com>

Am 08.07.2014 22:03, schrieb KY Srinivasan:
> The VCPU the channel is bound to is available in the channel state. You could use the following code
> Fragment to ensure that the call is made on the "right" cpu:
> 
> smp_call_function_single(dev->channel->target_cpu,
>                                          netvsc_channel_cb, dev->channel, true);

This won't work as netpoll runs with IRQs disabled.
->ndo_poll_controller() has to make sure that SKBs can be received and transmitted
while IRQs are off. I thought calling the channel callback by hand would be enough
to receive SKBs.

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: KY Srinivasan <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>
Cc: "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] hyperv: Add netpoll support
Date: Tue, 08 Jul 2014 22:16:52 +0200	[thread overview]
Message-ID: <53BC51B4.4010703@nod.at> (raw)
In-Reply-To: <b2835410139848be8811403e3d7fa708@BY2PR03MB299.namprd03.prod.outlook.com>

Am 08.07.2014 22:03, schrieb KY Srinivasan:
> The VCPU the channel is bound to is available in the channel state. You could use the following code
> Fragment to ensure that the call is made on the "right" cpu:
> 
> smp_call_function_single(dev->channel->target_cpu,
>                                          netvsc_channel_cb, dev->channel, true);

This won't work as netpoll runs with IRQs disabled.
->ndo_poll_controller() has to make sure that SKBs can be received and transmitted
while IRQs are off. I thought calling the channel callback by hand would be enough
to receive SKBs.

Thanks,
//richard

  reply	other threads:[~2014-07-08 20:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08  9:32 [PATCH] hyperv: Add netpoll support Richard Weinberger
2014-07-08 17:55 ` Haiyang Zhang
2014-07-08 17:55   ` Haiyang Zhang
2014-07-08 18:40   ` Richard Weinberger
2014-07-08 18:40     ` Richard Weinberger
2014-07-08 18:51     ` Haiyang Zhang
2014-07-08 18:51       ` Haiyang Zhang
2014-07-08 18:01 ` KY Srinivasan
2014-07-08 18:01   ` KY Srinivasan
2014-07-08 18:39   ` Richard Weinberger
2014-07-08 18:39     ` Richard Weinberger
2014-07-08 20:03     ` KY Srinivasan
2014-07-08 20:03       ` KY Srinivasan
2014-07-08 20:16       ` Richard Weinberger [this message]
2014-07-08 20:16         ` Richard Weinberger
2014-07-08 22:47         ` Francois Romieu
2014-07-08 22:53           ` Richard Weinberger
2014-07-08 22:53             ` Richard Weinberger
2014-07-08 23:43             ` Francois Romieu
2014-07-08 23:43               ` Francois Romieu
2014-07-09  7:59               ` Richard Weinberger
2014-07-09  7:59                 ` Richard Weinberger
2014-07-08 23:08           ` Richard Weinberger
2014-07-08 23:08             ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BC51B4.4010703@nod.at \
    --to=richard@nod.at \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.