From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V8 1/6] power: reset: Add generic SYSCON register mapped reset
Date: Tue, 08 Jul 2014 20:54:20 -0700 [thread overview]
Message-ID: <53BCBCEC.7010306@roeck-us.net> (raw)
In-Reply-To: <1404872153-3594-2-git-send-email-fkan@apm.com>
On 07/08/2014 07:15 PM, Feng Kan wrote:
> Add a generic SYSCON register mapped reset mechanism.
>
> Signed-off-by: Feng Kan <fkan@apm.com>
> ---
> drivers/power/reset/Kconfig | 6 +++
> drivers/power/reset/Makefile | 1 +
> drivers/power/reset/syscon-reboot.c | 91 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 98 insertions(+)
> create mode 100644 drivers/power/reset/syscon-reboot.c
>
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index bdcf517..5877b38 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -80,3 +80,9 @@ config POWER_RESET_KEYSTONE
> help
> Reboot support for the KEYSTONE SoCs.
>
> +config POWER_RESET_SYSCON
> + bool "Generic SYSCON regmap reset driver"
> + depends on ARM || ARM64 || COMPILE_TEST
As written, this driver is really not generic but very arm specific.
I don't think COMPILE_TEST is a good idea either, since arm_pm_restart
is only defined for the arm architecture. Did you try compiling allmodconfig
or allyesconfig for, say, x86_64 with this patch applied ?
I think this might benefit from using [1], which would make it really
generic.
Guenter
[1] http://www.spinics.net/lists/kernel/msg1780939.html
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Feng Kan <fkan@apm.com>,
dbaryshkov@gmail.com, catalin.marinas@arm.com,
dwmw2@infradead.org, arnd@arndb.de, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, patches@apm.com
Subject: Re: [PATCH V8 1/6] power: reset: Add generic SYSCON register mapped reset
Date: Tue, 08 Jul 2014 20:54:20 -0700 [thread overview]
Message-ID: <53BCBCEC.7010306@roeck-us.net> (raw)
In-Reply-To: <1404872153-3594-2-git-send-email-fkan@apm.com>
On 07/08/2014 07:15 PM, Feng Kan wrote:
> Add a generic SYSCON register mapped reset mechanism.
>
> Signed-off-by: Feng Kan <fkan@apm.com>
> ---
> drivers/power/reset/Kconfig | 6 +++
> drivers/power/reset/Makefile | 1 +
> drivers/power/reset/syscon-reboot.c | 91 +++++++++++++++++++++++++++++++++++++
> 3 files changed, 98 insertions(+)
> create mode 100644 drivers/power/reset/syscon-reboot.c
>
> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index bdcf517..5877b38 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -80,3 +80,9 @@ config POWER_RESET_KEYSTONE
> help
> Reboot support for the KEYSTONE SoCs.
>
> +config POWER_RESET_SYSCON
> + bool "Generic SYSCON regmap reset driver"
> + depends on ARM || ARM64 || COMPILE_TEST
As written, this driver is really not generic but very arm specific.
I don't think COMPILE_TEST is a good idea either, since arm_pm_restart
is only defined for the arm architecture. Did you try compiling allmodconfig
or allyesconfig for, say, x86_64 with this patch applied ?
I think this might benefit from using [1], which would make it really
generic.
Guenter
[1] http://www.spinics.net/lists/kernel/msg1780939.html
next prev parent reply other threads:[~2014-07-09 3:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 2:15 [PATCH V8 0/6] Add X-Gene platform reboot mechanism Feng Kan
2014-07-09 2:15 ` Feng Kan
2014-07-09 2:15 ` [PATCH V8 1/6] power: reset: Add generic SYSCON register mapped reset Feng Kan
2014-07-09 2:15 ` Feng Kan
2014-07-09 3:54 ` Guenter Roeck [this message]
2014-07-09 3:54 ` Guenter Roeck
2014-07-09 21:15 ` Feng Kan
2014-07-09 21:15 ` Feng Kan
2014-07-09 21:15 ` Feng Kan
2014-07-09 21:27 ` Guenter Roeck
2014-07-09 21:27 ` Guenter Roeck
2014-07-09 2:15 ` [PATCH V8 2/6] Documentation: power: reset: Add documentation for generic SYSCON reboot driver Feng Kan
2014-07-09 2:15 ` Feng Kan
2014-07-09 2:15 ` [PATCH V8 3/6] Documentation: arm64: add SCU dts binding documentation to linux kernel Feng Kan
2014-07-09 2:15 ` Feng Kan
2014-07-09 2:15 ` [PATCH V8 4/6] arm64: dts: Add X-Gene reboot driver dts node Feng Kan
2014-07-09 2:15 ` Feng Kan
2014-07-09 2:15 ` [PATCH V8 5/6] arm64: Select reboot driver for X-Gene platform Feng Kan
2014-07-09 2:15 ` Feng Kan
2014-07-09 2:15 ` [PATCH V8 6/6] power: reset: Remove X-Gene reboot driver Feng Kan
2014-07-09 2:15 ` Feng Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BCBCEC.7010306@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.