Re: [PATCH] xen/arm: Implement domain_get_maximum_gpfn

[Julien Grall <julien.grall@linaro.org>]

Hi Ian,

On 07/01/2014 05:57 PM, Stefano Stabellini wrote:
> On Tue, 1 Jul 2014, Julien Grall wrote:
>> The function domain_get_maximum_gpfn is returning the maximum gpfn ever
>> mapped in the guest. We can use d->arch.p2m.max_mapped_gfn for this purpose.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

Following the discussion on this thread, I will send a patch to fix
xc_dom_gnttab_hvm_seed at least for ARM. Not sure what to do on x86, I
may keep the same behavior.

I think this patch is still relevant and won't break things as we don't
have platform with 48bits PA support.

Ian, do I have your ack on this patch?

>>  xen/arch/arm/mm.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
>> index 03a0533..2d40f07 100644
>> --- a/xen/arch/arm/mm.c
>> +++ b/xen/arch/arm/mm.c
>> @@ -947,7 +947,7 @@ int page_is_ram_type(unsigned long mfn, unsigned long mem_type)
>>  
>>  unsigned long domain_get_maximum_gpfn(struct domain *d)
>>  {
>> -    return -ENOSYS;
>> +    return d->arch.p2m.max_mapped_gfn;
>>  }
>>  
>>  void share_xen_page_with_guest(struct page_info *page,
>> -- 
>> 1.7.10.4
>>

Regards,

-- 
Julien Grall