Re: [PATCH] xen/arm: Implement domain_get_maximum_gpfn

[Julien Grall <julien.grall@linaro.org>]

Hi Ian,

On 16/07/14 17:02, Ian Campbell wrote:
> On Wed, 2014-07-09 at 12:38 +0100, Julien Grall wrote:
>> Hi Ian,
>>
>> On 07/01/2014 05:57 PM, Stefano Stabellini wrote:
>>> On Tue, 1 Jul 2014, Julien Grall wrote:
>>>> The function domain_get_maximum_gpfn is returning the maximum gpfn ever
>>>> mapped in the guest. We can use d->arch.p2m.max_mapped_gfn for this purpose.
>>>>
>>>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>>
>>> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>
>> Following the discussion on this thread, I will send a patch to fix
>> xc_dom_gnttab_hvm_seed at least for ARM. Not sure what to do on x86, I
>> may keep the same behavior.
>>
>> I think this patch is still relevant and won't break things as we don't
>> have platform with 48bits PA support.
>>
>> Ian, do I have your ack on this patch?
>
> Oops, when I first saw this I read the first para and stopped, sorry.
>
> I'd much prefer to just have the fix to xc_dom_gnttab_hvm_seed for ARM
> and continue to punt on this interface until it is actually needed by
> something unavoidable on the guest side (and simultaneously hope that
> day never comes...).

This hypercall is used in 2 difference locations: domain save, and dump 
core.

I expect to have both working on Xen ARM soon. I will also send a fix 
when I will find time for xc_dom_gnttab_hvm_seed.

Regards,

-- 
Julien Grall