All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] xen/dt: Allow only IRQ translation that are mapped to main GIC
@ 2014-07-08 11:02 Julien Grall
  2014-07-09 12:33 ` Julien Grall
  0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2014-07-08 11:02 UTC (permalink / raw)
  To: xen-devel; +Cc: stefano.stabellini, Julien Grall, tim, ian.campbell

Xen is only able to handle one GIC controller. Some platform may contain
other interrupt controller.

Make sure to only translate IRQ mapped into the GIC handled by Xen.

Signed-off-by: Julien Grall <julien.grall@linaro.org>

---
    Changes in v2:
        - Fix compilation...
---
 xen/common/device_tree.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
index 310635e..7178c77 100644
--- a/xen/common/device_tree.c
+++ b/xen/common/device_tree.c
@@ -1444,6 +1444,8 @@ int dt_irq_translate(const struct dt_raw_irq *raw,
     ASSERT(dt_irq_xlate != NULL);
 
     /* TODO: Retrieve the right irq_xlate. This is only work for the gic */
+    if ( raw->controller != dt_interrupt_controller )
+        return -EINVAL;
 
     return dt_irq_xlate(raw->specifier, raw->size,
                         &out_irq->irq, &out_irq->type);
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] xen/dt: Allow only IRQ translation that are mapped to main GIC
  2014-07-08 11:02 [PATCH v2] xen/dt: Allow only IRQ translation that are mapped to main GIC Julien Grall
@ 2014-07-09 12:33 ` Julien Grall
  0 siblings, 0 replies; 2+ messages in thread
From: Julien Grall @ 2014-07-09 12:33 UTC (permalink / raw)
  To: xen-devel; +Cc: stefano.stabellini, tim, ian.campbell

On 07/08/2014 12:02 PM, Julien Grall wrote:
> Xen is only able to handle one GIC controller. Some platform may contain
> other interrupt controller.
> 
> Make sure to only translate IRQ mapped into the GIC handled by Xen.
> 
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> ---
>     Changes in v2:
>         - Fix compilation...

Please ignore this patch. The problem is bigger than I though. I will
send a proper series later.

> ---
>  xen/common/device_tree.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 310635e..7178c77 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -1444,6 +1444,8 @@ int dt_irq_translate(const struct dt_raw_irq *raw,
>      ASSERT(dt_irq_xlate != NULL);
>  
>      /* TODO: Retrieve the right irq_xlate. This is only work for the gic */
> +    if ( raw->controller != dt_interrupt_controller )
> +        return -EINVAL;
>  
>      return dt_irq_xlate(raw->specifier, raw->size,
>                          &out_irq->irq, &out_irq->type);
> 


-- 
Julien Grall

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-09 12:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-08 11:02 [PATCH v2] xen/dt: Allow only IRQ translation that are mapped to main GIC Julien Grall
2014-07-09 12:33 ` Julien Grall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.