Re: [Qemu-devel] [PATCH v9 05/14] blockjob: Add "ready" field

[Max Reitz <mreitz@redhat.com>]

On 07.07.2014 20:53, Eric Blake wrote:
> On 07/05/2014 11:47 AM, Max Reitz wrote:
>> When a block job signals readiness, this is currently reported only
>> through QMP. If qemu wants to use block jobs for internal tasks, there
>> needs to be another way to correctly detect when a block job may be
>> completed.
>>
>> For this reason, introduce a bool "ready" which is set when the block
>> job may be completed.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   blockjob.c               | 3 +++
>>   include/block/blockjob.h | 5 +++++
>>   qapi/block-core.json     | 4 +++-
>>   3 files changed, 11 insertions(+), 1 deletion(-)
>>
>> +++ b/qapi/block-core.json
>> @@ -505,12 +505,14 @@
>>   #
>>   # @io-status: the status of the job (since 1.3)
>>   #
>> +# @ready: true if the job may be completed (since 2.1)
> Isn't this 2.2 now, or are you still shooting for calling this a bug fix
> in 2.1 hard freeze?

Ah, right, I forgot. This should be 2.2, of course.

Max

> Depending on the answer,
> Reviewed-by: Eric Blake <eblake@redhat.com>