From: Paolo Bonzini <pbonzini@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 03/14] qcow2: Optimize bdrv_make_empty()
Date: Wed, 09 Jul 2014 23:22:08 +0200 [thread overview]
Message-ID: <53BDB280.6080408@redhat.com> (raw)
In-Reply-To: <1404582448-23840-4-git-send-email-mreitz@redhat.com>
Il 05/07/2014 19:47, Max Reitz ha scritto:
> bdrv_make_empty() is currently only called if the current image
> represents an external snapshot that has been committed to its base
> image; it is therefore unlikely to have internal snapshots. In this
> case, bdrv_make_empty() can be greatly sped up by creating an empty L1
> table and dropping all data clusters at once by recreating the refcount
> structure accordingly instead of normally discarding all clusters.
>
> If there are snapshots, fall back to the simple implementation (discard
> all clusters).
How much of this code could be reused by bdrv_create?
Paolo
next prev parent reply other threads:[~2014-07-09 21:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 17:47 [Qemu-devel] [PATCH v9 00/14] qemu-img: Implement commit like QMP Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 01/14] qcow2: Allow "full" discard Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 02/14] qcow2: Implement bdrv_make_empty() Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 03/14] qcow2: Optimize bdrv_make_empty() Max Reitz
2014-07-09 21:22 ` Paolo Bonzini [this message]
2014-07-09 21:38 ` Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 04/14] blockjob: Introduce block_job_complete_sync() Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 05/14] blockjob: Add "ready" field Max Reitz
2014-07-07 18:53 ` Eric Blake
2014-07-09 20:21 ` Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 06/14] block/mirror: Improve progress report Max Reitz
2014-07-07 19:13 ` Eric Blake
2014-07-09 21:24 ` Paolo Bonzini
2014-07-09 21:36 ` Eric Blake
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 07/14] qemu-img: Implement commit like QMP Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 08/14] qemu-img: Empty image after commit Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 09/14] qemu-img: Enable progress output for commit Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 10/14] qemu-img: Specify backing file " Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 11/14] iotests: Add _filter_qemu_img_map Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 12/14] iotests: Add test for backing-chain commits Max Reitz
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 13/14] iotests: Add test for qcow2's bdrv_make_empty Max Reitz
2014-07-07 19:15 ` Eric Blake
2014-07-05 17:47 ` [Qemu-devel] [PATCH v9 14/14] iotests: Omit length/offset test in 040 and 041 Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BDB280.6080408@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.