From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>, Roy Franz <roy.franz@linaro.org>
Cc: keir <keir@xen.org>, tim <tim@xen.org>,
xen-devel <xen-devel@lists.xen.org>,
Stefano Stabellini <stefano.stabellini@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
linaro-uefi <linaro-uefi@lists.linaro.org>
Subject: Re: [Linaro-uefi] [PATCH RFC 19/19] Add EFI stub for ARM64
Date: Thu, 10 Jul 2014 10:21:38 +0100 [thread overview]
Message-ID: <53BE5B22.60804@linaro.org> (raw)
In-Reply-To: <1404979994.11981.23.camel@dagon.hellion.org.uk>
Hi Ian & Roy,
On 10/07/14 09:13, Ian Campbell wrote:
>>> Probably the easiest thing to do there is to create
>>> xen/arch/arm/efi/stub.c and do the fshort-char trick for that entire
>>> folder, since I don't think our build system makes it especially easy to
>>> change CFLAGS for individual object files.
>>
>> Yes and yes. I will likely end up with some single file directories due to the
>> build option differences. Is there a XEN build system expert that I can ask
>> for help if needed? (Or should I just post to the list?)
>
> I'm not sure anyone is an expert on this stuff but feel free to prod me
> either here or on #xenarm.
>
> I think you just need something like, in xen/arch/arm/Makefile
> subdir-$(arm64) += efi # or CONFIG_EFI etc
> and in xen/arch/arm/efi/Makefile:
> CFLAGS += -fshort-wchar
> obj-y += foo.o etc.o
>
> much the same for xen/common/efi.
The Xen buildsystem doesn't provide CFLAGS facilities as the Kernel, but
the Makefile has a syntax to append data in variables for a specific target.
If your efi.c is in xen/arch/arm/, you need to add in xen/arch/arm/Makefile:
efi.o: CFLAGS += -fshort-wchar
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-07-10 9:21 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 1:25 [PATCH RFC 00/19] arm64 EFI stub Roy Franz
2014-06-28 1:25 ` [PATCH RFC 01/19] HACK: Add -fshort-wchar to global build Roy Franz
2014-06-30 11:13 ` Jan Beulich
2014-06-28 1:25 ` [PATCH RFC 02/19] Create efi-shared.[ch], and move string functions Roy Franz
2014-06-30 11:15 ` Jan Beulich
2014-07-02 11:49 ` Ian Campbell
2014-07-02 11:55 ` Ian Campbell
2014-07-09 18:31 ` Roy Franz
2014-06-28 1:25 ` [PATCH RFC 03/19] Move more functions from boot.c to efi-shared.c Roy Franz
2014-06-28 1:25 ` [PATCH RFC 04/19] rename printErrMsg to PrintErrMesgExit Roy Franz
2014-06-28 1:25 ` [PATCH RFC 05/19] Add PrintErrMesg function that doesn't exit Roy Franz
2014-06-28 1:25 ` [PATCH RFC 06/19] Refactor read_file() so it can be shared Roy Franz
2014-06-28 1:25 ` [PATCH RFC 07/19] move read_file() to efi-shared.c Roy Franz
2014-06-28 1:25 ` [PATCH RFC 08/19] Move removal of leading spaces from split_value to get_value() Roy Franz
2014-06-28 1:25 ` [PATCH RFC 09/19] replace split_value() with truncate_string() Roy Franz
2014-06-28 1:25 ` [PATCH RFC 10/19] move truncate_string() to efi-shared.c Roy Franz
2014-06-28 1:25 ` [PATCH RFC 11/19] add read_config_file() function for XEN EFI config file Roy Franz
2014-06-28 1:25 ` [PATCH RFC 12/19] create handle_cmdline() function Roy Franz
2014-06-28 1:25 ` [PATCH RFC 13/19] Refactor get_argv() for sharing Roy Franz
2014-06-28 1:25 ` [PATCH RFC 14/19] Move get_argv() and handle_cmdline() to efi-shared.c Roy Franz
2014-06-28 1:25 ` [PATCH RFC 15/19] Add PE/COFF header in head.S Roy Franz
2014-07-02 12:02 ` Ian Campbell
2014-07-09 18:35 ` Roy Franz
2014-06-28 1:25 ` [PATCH RFC 16/19] create ARM EFI headers, based on x86 Roy Franz
2014-06-28 1:25 ` [PATCH RFC 17/19] Remove x86 specific defintions from efibind.h Roy Franz
2014-07-02 12:03 ` Ian Campbell
2014-07-09 18:27 ` Roy Franz
2014-07-10 7:59 ` Ian Campbell
2014-06-28 1:25 ` [PATCH RFC 18/19] Add assembler use support for efibind.h Roy Franz
2014-06-28 1:25 ` [PATCH RFC 19/19] Add EFI stub for ARM64 Roy Franz
2014-07-02 12:34 ` Ian Campbell
2014-07-09 19:15 ` Roy Franz
2014-07-10 8:13 ` Ian Campbell
2014-07-10 9:21 ` Julien Grall [this message]
2014-07-10 9:33 ` [Linaro-uefi] " Ian Campbell
2014-06-28 15:34 ` [PATCH RFC 00/19] arm64 EFI stub Roy Franz
2014-06-29 16:42 ` [Linaro-uefi] " Julien Grall
2014-06-30 11:12 ` Jan Beulich
2014-07-02 11:52 ` Ian Campbell
2014-07-02 12:31 ` Ian Campbell
2014-07-09 18:24 ` Roy Franz
2014-07-10 7:58 ` Ian Campbell
2014-07-10 17:33 ` Roy Franz
2014-07-11 8:57 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BE5B22.60804@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=linaro-uefi@lists.linaro.org \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.