From: Alexander Graf <agraf@suse.de>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>, kvm@vger.kernel.org
Subject: Re: [PATCH] powerpc/kvm: Create proper names for the kvm_host_state PMU fields
Date: Thu, 10 Jul 2014 12:16:10 +0200 [thread overview]
Message-ID: <53BE67EA.8000206@suse.de> (raw)
In-Reply-To: <1404984871-15145-1-git-send-email-mpe@ellerman.id.au>
On 10.07.14 11:34, Michael Ellerman wrote:
> We have two arrays in kvm_host_state that contain register values for
> the PMU. Currently we only create an asm-offsets symbol for the base of
> the arrays, and do the array offset in the assembly code.
>
> Creating an asm-offsets symbol for each field individually makes the
> code much nicer to read, particularly for the MMCRx/SIxR/SDAR fields, and
> might have helped us notice the recent double restore bug we had in this
> code.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Alexander Graf <agraf@suse.de>
I still think this whole code path should just be C though.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@ozlabs.org
Cc: kvm@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc/kvm: Create proper names for the kvm_host_state PMU fields
Date: Thu, 10 Jul 2014 12:16:10 +0200 [thread overview]
Message-ID: <53BE67EA.8000206@suse.de> (raw)
In-Reply-To: <1404984871-15145-1-git-send-email-mpe@ellerman.id.au>
On 10.07.14 11:34, Michael Ellerman wrote:
> We have two arrays in kvm_host_state that contain register values for
> the PMU. Currently we only create an asm-offsets symbol for the base of
> the arrays, and do the array offset in the assembly code.
>
> Creating an asm-offsets symbol for each field individually makes the
> code much nicer to read, particularly for the MMCRx/SIxR/SDAR fields, and
> might have helped us notice the recent double restore bug we had in this
> code.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Alexander Graf <agraf@suse.de>
I still think this whole code path should just be C though.
Alex
next prev parent reply other threads:[~2014-07-10 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 9:34 [PATCH] powerpc/kvm: Create proper names for the kvm_host_state PMU fields Michael Ellerman
2014-07-10 9:34 ` Michael Ellerman
2014-07-10 10:16 ` Alexander Graf [this message]
2014-07-10 10:16 ` Alexander Graf
2014-07-11 4:46 ` Michael Ellerman
2014-07-11 4:46 ` Michael Ellerman
2014-12-23 7:12 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BE67EA.8000206@suse.de \
--to=agraf@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.