* [PATCH] rbd.cc: Check io-size avoid floating point exception.
@ 2014-06-12 8:15 Ma, Jianpeng
2014-07-11 1:01 ` Josh Durgin
0 siblings, 1 reply; 2+ messages in thread
From: Ma, Jianpeng @ 2014-06-12 8:15 UTC (permalink / raw)
To: ceph-devel@vger.kernel.org
In func do_bench_write if io_size is zero,it can cause floating point execption.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
---
src/rbd.cc | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/rbd.cc b/src/rbd.cc
index d6658e3..c068ed6 100644
--- a/src/rbd.cc
+++ b/src/rbd.cc
@@ -2038,6 +2038,14 @@ int main(int argc, const char **argv)
return EXIT_FAILURE;
}
} else if (ceph_argparse_withlonglong(args, i, &bench_io_size, &err, "--io-size", (char*)NULL)) {
+ if (!err.str().empty()) {
+ cerr << "rbd: " << err.str() << std::endl;
+ return EXIT_FAILURE;
+ }
+ if (bench_io_size == 0) {
+ cerr << "rbd: io-size must be > 0" << std::endl;
+ return EXIT_FAILURE;
+ }
} else if (ceph_argparse_withlonglong(args, i, &bench_io_threads, &err, "--io-threads", (char*)NULL)) {
} else if (ceph_argparse_withlonglong(args, i, &bench_bytes, &err, "--io-total", (char*)NULL)) {
} else if (ceph_argparse_witharg(args, i, &bench_pattern, &err, "--io-pattern", (char*)NULL)) {
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] rbd.cc: Check io-size avoid floating point exception.
2014-06-12 8:15 [PATCH] rbd.cc: Check io-size avoid floating point exception Ma, Jianpeng
@ 2014-07-11 1:01 ` Josh Durgin
0 siblings, 0 replies; 2+ messages in thread
From: Josh Durgin @ 2014-07-11 1:01 UTC (permalink / raw)
To: Ma, Jianpeng, ceph-devel@vger.kernel.org
On 06/12/2014 01:15 AM, Ma, Jianpeng wrote:
> In func do_bench_write if io_size is zero,it can cause floating point execption.
>
> Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Applied, thanks!
Josh
> ---
> src/rbd.cc | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/src/rbd.cc b/src/rbd.cc
> index d6658e3..c068ed6 100644
> --- a/src/rbd.cc
> +++ b/src/rbd.cc
> @@ -2038,6 +2038,14 @@ int main(int argc, const char **argv)
> return EXIT_FAILURE;
> }
> } else if (ceph_argparse_withlonglong(args, i, &bench_io_size, &err, "--io-size", (char*)NULL)) {
> + if (!err.str().empty()) {
> + cerr << "rbd: " << err.str() << std::endl;
> + return EXIT_FAILURE;
> + }
> + if (bench_io_size == 0) {
> + cerr << "rbd: io-size must be > 0" << std::endl;
> + return EXIT_FAILURE;
> + }
> } else if (ceph_argparse_withlonglong(args, i, &bench_io_threads, &err, "--io-threads", (char*)NULL)) {
> } else if (ceph_argparse_withlonglong(args, i, &bench_bytes, &err, "--io-total", (char*)NULL)) {
> } else if (ceph_argparse_witharg(args, i, &bench_pattern, &err, "--io-pattern", (char*)NULL)) {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-11 1:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-12 8:15 [PATCH] rbd.cc: Check io-size avoid floating point exception Ma, Jianpeng
2014-07-11 1:01 ` Josh Durgin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.