From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.1? 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock
Date: Fri, 11 Jul 2014 13:37:59 +0200 [thread overview]
Message-ID: <53BFCC97.8070402@de.ibm.com> (raw)
In-Reply-To: <1405077612-7806-1-git-send-email-stefanha@redhat.com>
On 11/07/14 13:20, Stefan Hajnoczi wrote:
> These patches convert thread-pool.c from EventNotifier to QEMUBH. They then
> solve the deadlock when nested aio_poll() calls are made.
>
> Please speak out whether you want this in QEMU 2.1 or not. I'm not aware of
> the nested aio_poll() deadlock ever having been reported, so maybe we can defer
> to QEMU 2.2.
>
> Stefan Hajnoczi (2):
> thread-pool: avoid per-thread-pool EventNotifier
> thread-pool: avoid deadlock in nested aio_poll() calls
>
> thread-pool.c | 44 +++++++++++++++++++++++++++++++-------------
> 1 file changed, 31 insertions(+), 13 deletions(-)
>
Seems to work ok and saves an fd. I think its still better scheduled for 2.2
Christian
prev parent reply other threads:[~2014-07-11 11:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 11:20 [Qemu-devel] [PATCH for-2.1? 0/2] thread-pool: avoid fd usage and fix nested aio_poll() deadlock Stefan Hajnoczi
2014-07-11 11:20 ` [Qemu-devel] [PATCH for-2.1? 1/2] thread-pool: avoid per-thread-pool EventNotifier Stefan Hajnoczi
2014-07-11 11:20 ` [Qemu-devel] [PATCH for-2.1? 2/2] thread-pool: avoid deadlock in nested aio_poll() calls Stefan Hajnoczi
2014-07-14 8:36 ` Paolo Bonzini
2014-07-14 10:49 ` Paolo Bonzini
2014-07-15 14:37 ` Stefan Hajnoczi
2014-07-15 15:21 ` Paolo Bonzini
2014-07-17 12:56 ` Stefan Hajnoczi
2014-07-15 14:23 ` Stefan Hajnoczi
2014-07-11 11:37 ` Christian Borntraeger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BFCC97.8070402@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.