From: Rik van Riel <riel@redhat.com>
To: Maxim Patlasov <MPatlasov@parallels.com>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, mhocko@suse.cz, linux-mm@kvack.org,
kosaki.motohiro@jp.fujitsu.com, fengguang.wu@intel.com,
jweiner@redhat.com
Subject: Re: [PATCH] mm/page-writeback.c: fix divide by zero in bdi_dirty_limits
Date: Fri, 11 Jul 2014 10:49:57 -0400 [thread overview]
Message-ID: <53BFF995.5020602@redhat.com> (raw)
In-Reply-To: <20140711081656.15654.19946.stgit@localhost.localdomain>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/11/2014 04:18 AM, Maxim Patlasov wrote:
> Under memory pressure, it is possible for dirty_thresh, calculated
> by global_dirty_limits() in balance_dirty_pages(), to equal zero.
> Then, if strictlimit is true, bdi_dirty_limits() tries to resolve
> the proportion:
>
> bdi_bg_thresh : bdi_thresh = background_thresh : dirty_thresh
>
> by dividing by zero.
>
> Signed-off-by: Maxim Patlasov <mpatlasov@parallels.com>
Acked-by: Rik van Riel <riel@redhat.com>
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTv/mVAAoJEM553pKExN6Dw8UH/1KgQrLYDTVQIzvaXNxPwxOv
xXqrWAnFf+mOflA/Tu/TqOwPUV20YSWTAuJU/NbyLSR0Ak15beCjH4ObifpgZgR+
k9lvJNHEk6XUQH0nERsHcwbNZMGtLBAvyw1oRCVXm6V1IVpbpp0IckP29KP5Ibs4
FChNNna/h7zOTpgysTtuKDO6JGuPy+sCjK5aNVH0jSTd4ENtTD1HtfkgtU/OZVyS
m8afzJ0sp/A1sQGy+41ZorR3I0dAmtX3Qtx335QjrZQAy8bT3jCLBLjEHW9xQhCh
afuZhfHdrXHiNh8RZnLgeFWiVzYHDc6ytoD7aZQsxaFZIlyccVRzc7SvarrT4ys=
=jTrs
-----END PGP SIGNATURE-----
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Maxim Patlasov <MPatlasov@parallels.com>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, mhocko@suse.cz, linux-mm@kvack.org,
kosaki.motohiro@jp.fujitsu.com, fengguang.wu@intel.com,
jweiner@redhat.com
Subject: Re: [PATCH] mm/page-writeback.c: fix divide by zero in bdi_dirty_limits
Date: Fri, 11 Jul 2014 10:49:57 -0400 [thread overview]
Message-ID: <53BFF995.5020602@redhat.com> (raw)
In-Reply-To: <20140711081656.15654.19946.stgit@localhost.localdomain>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 07/11/2014 04:18 AM, Maxim Patlasov wrote:
> Under memory pressure, it is possible for dirty_thresh, calculated
> by global_dirty_limits() in balance_dirty_pages(), to equal zero.
> Then, if strictlimit is true, bdi_dirty_limits() tries to resolve
> the proportion:
>
> bdi_bg_thresh : bdi_thresh = background_thresh : dirty_thresh
>
> by dividing by zero.
>
> Signed-off-by: Maxim Patlasov <mpatlasov@parallels.com>
Acked-by: Rik van Riel <riel@redhat.com>
- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQEcBAEBAgAGBQJTv/mVAAoJEM553pKExN6Dw8UH/1KgQrLYDTVQIzvaXNxPwxOv
xXqrWAnFf+mOflA/Tu/TqOwPUV20YSWTAuJU/NbyLSR0Ak15beCjH4ObifpgZgR+
k9lvJNHEk6XUQH0nERsHcwbNZMGtLBAvyw1oRCVXm6V1IVpbpp0IckP29KP5Ibs4
FChNNna/h7zOTpgysTtuKDO6JGuPy+sCjK5aNVH0jSTd4ENtTD1HtfkgtU/OZVyS
m8afzJ0sp/A1sQGy+41ZorR3I0dAmtX3Qtx335QjrZQAy8bT3jCLBLjEHW9xQhCh
afuZhfHdrXHiNh8RZnLgeFWiVzYHDc6ytoD7aZQsxaFZIlyccVRzc7SvarrT4ys=
=jTrs
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-07-11 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 8:18 [PATCH] mm/page-writeback.c: fix divide by zero in bdi_dirty_limits Maxim Patlasov
2014-07-11 8:18 ` Maxim Patlasov
2014-07-11 14:49 ` Rik van Riel [this message]
2014-07-11 14:49 ` Rik van Riel
2014-07-11 22:27 ` Andrew Morton
2014-07-11 22:27 ` Andrew Morton
2014-07-14 8:06 ` Maxim Patlasov
2014-07-14 8:06 ` Maxim Patlasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BFF995.5020602@redhat.com \
--to=riel@redhat.com \
--cc=MPatlasov@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jweiner@redhat.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.