All of lore.kernel.org
 help / color / mirror / Atom feed
* master - test: Test failing due to too few PVs
@ 2014-07-10 23:54 Jonathan Brassow
  2014-07-11 14:52 ` Zdenek Kabelac
  0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Brassow @ 2014-07-10 23:54 UTC (permalink / raw)
  To: lvm-devel

Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=f33d75e2e586a88ddeb20d860765f091098b8ab5
Commit:        f33d75e2e586a88ddeb20d860765f091098b8ab5
Parent:        3063b48602220b0aa5e1ad7a91dc4ca60d717e36
Author:        Jonathan Brassow <jbrassow@redhat.com>
AuthorDate:    Thu Jul 10 18:52:55 2014 -0500
Committer:     Jonathan Brassow <jbrassow@redhat.com>
CommitterDate: Thu Jul 10 18:53:46 2014 -0500

test: Test failing due to too few PVs

Commit 33d69162e4b45e7926d4c0e4a425fedb4246088e reduced the number of
PVs to a level where the test could not function.  (It is impossible
to replace 3 PVs of a 4-way RAID1 LV if there are only 5 PVs.)
---
 test/shell/lvconvert-raid.sh    |    2 +-
 test/shell/lvconvert-raid456.sh |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/shell/lvconvert-raid.sh b/test/shell/lvconvert-raid.sh
index 6f17303..bcf3874 100644
--- a/test/shell/lvconvert-raid.sh
+++ b/test/shell/lvconvert-raid.sh
@@ -24,7 +24,7 @@ get_image_pvs() {
 ########################################################
 aux have_raid 1 3 0 || skip
 
-aux prepare_pvs 5
+aux prepare_pvs 9
 vgcreate -s 256k $vg $(cat DEVICES)
 
 ###########################################
diff --git a/test/shell/lvconvert-raid456.sh b/test/shell/lvconvert-raid456.sh
index 1ead128..833b10e 100644
--- a/test/shell/lvconvert-raid456.sh
+++ b/test/shell/lvconvert-raid456.sh
@@ -25,7 +25,7 @@ get_image_pvs() {
 aux raid456_replace_works || skip
 aux have_raid 1 3 0 || skip
 
-aux prepare_pvs 6
+aux prepare_pvs 7  # 7 devices for 2 dev replacement of 5-dev RAID6
 vgcreate -s 256k $vg $(cat DEVICES)
 
 # RAID 4/5/6 (can replace up to 'parity' devices)



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* master - test: Test failing due to too few PVs
  2014-07-10 23:54 master - test: Test failing due to too few PVs Jonathan Brassow
@ 2014-07-11 14:52 ` Zdenek Kabelac
  0 siblings, 0 replies; 2+ messages in thread
From: Zdenek Kabelac @ 2014-07-11 14:52 UTC (permalink / raw)
  To: lvm-devel

Dne 11.7.2014 01:54, Jonathan Brassow napsal(a):
> Gitweb:        http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=f33d75e2e586a88ddeb20d860765f091098b8ab5
> Commit:        f33d75e2e586a88ddeb20d860765f091098b8ab5
> Parent:        3063b48602220b0aa5e1ad7a91dc4ca60d717e36
> Author:        Jonathan Brassow <jbrassow@redhat.com>
> AuthorDate:    Thu Jul 10 18:52:55 2014 -0500
> Committer:     Jonathan Brassow <jbrassow@redhat.com>
> CommitterDate: Thu Jul 10 18:53:46 2014 -0500
>
> test: Test failing due to too few PVs
>
> Commit 33d69162e4b45e7926d4c0e4a425fedb4246088e reduced the number of
> PVs to a level where the test could not function.  (It is impossible
> to replace 3 PVs of a 4-way RAID1 LV if there are only 5 PVs.)
> ---

Oops those changes leaked from my local repo patches when I'm doing
some tests for failing conditions.

Thanks for noticing and restoring.

Zdenek



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-11 14:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-10 23:54 master - test: Test failing due to too few PVs Jonathan Brassow
2014-07-11 14:52 ` Zdenek Kabelac

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.