* [PATCH] ASoC: rockchips: fix build error
@ 2014-07-11 13:07 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2014-07-11 13:07 UTC (permalink / raw)
To: alsa-devel
Cc: broonie, Arnd Bergmann, lgirdwood, linux-arm-kernel, Jianqun Xu
The newly added rockchip_i2s driver is lacking an include of
linux/module.h, causing a build error in some cases:
../sound/soc/rockchip/rockchip_i2s.c:526:20: error: expected declaration specifiers or '...' before string constant
MODULE_DESCRIPTION("ROCKCHIP IIS ASoC Interface");
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Jianqun Xu <xjq@rock-chips.com>
---
sound/soc/rockchip/rockchip_i2s.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
index af1d8eb94f04..c3e53feba5b9 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -13,6 +13,7 @@
#include <linux/delay.h>
#include <linux/of_gpio.h>
#include <linux/clk.h>
+#include <linux/module.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
#include <sound/pcm_params.h>
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ASoC: rockchips: fix build error
@ 2014-07-11 13:07 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2014-07-11 13:07 UTC (permalink / raw)
To: linux-arm-kernel
The newly added rockchip_i2s driver is lacking an include of
linux/module.h, causing a build error in some cases:
../sound/soc/rockchip/rockchip_i2s.c:526:20: error: expected declaration specifiers or '...' before string constant
MODULE_DESCRIPTION("ROCKCHIP IIS ASoC Interface");
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Jianqun Xu <xjq@rock-chips.com>
---
sound/soc/rockchip/rockchip_i2s.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
index af1d8eb94f04..c3e53feba5b9 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -13,6 +13,7 @@
#include <linux/delay.h>
#include <linux/of_gpio.h>
#include <linux/clk.h>
+#include <linux/module.h>
#include <linux/pm_runtime.h>
#include <linux/regmap.h>
#include <sound/pcm_params.h>
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ASoC: rockchips: fix build error
2014-07-11 13:07 ` Arnd Bergmann
@ 2014-07-11 13:48 ` Mark Brown
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-07-11 13:48 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: alsa-devel, Jianqun Xu, lgirdwood, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 223 bytes --]
On Fri, Jul 11, 2014 at 03:07:08PM +0200, Arnd Bergmann wrote:
> The newly added rockchip_i2s driver is lacking an include of
> linux/module.h, causing a build error in some cases:
A fix for this has already been applied.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ASoC: rockchips: fix build error
@ 2014-07-11 13:48 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2014-07-11 13:48 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jul 11, 2014 at 03:07:08PM +0200, Arnd Bergmann wrote:
> The newly added rockchip_i2s driver is lacking an include of
> linux/module.h, causing a build error in some cases:
A fix for this has already been applied.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140711/57585e75/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: rockchips: fix build error
2014-07-11 13:48 ` Mark Brown
@ 2014-07-12 0:59 ` Jianqun
-1 siblings, 0 replies; 6+ messages in thread
From: Jianqun @ 2014-07-12 0:59 UTC (permalink / raw)
To: Mark Brown, Arnd Bergmann; +Cc: alsa-devel, lgirdwood, linux-arm-kernel
On 2014年07月11日 21:48, Mark Brown wrote:
> On Fri, Jul 11, 2014 at 03:07:08PM +0200, Arnd Bergmann wrote:
>> The newly added rockchip_i2s driver is lacking an include of
>> linux/module.h, causing a build error in some cases:
>
> A fix for this has already been applied.
>
Thank you very much :), it's great help for a begainner.
--
-------------
许 剑 群 Jay
Rockchip Electronics Co.Ltd
****************************************************************************
*IMPORTANT NOTICE:*This email is from Fuzhou Rockchip Electronics Co.,
Ltd .The contents of this email and any attachments may contain
information that is privileged, confidential and/or exempt from
disclosure under applicable law and relevant NDA. If you are not the
intended recipient, you are hereby notified that any disclosure,
copying, distribution, or use of the information is STRICTLY PROHIBITED.
Please immediately contact the sender as soon as possible and destroy
the material in its entirety in any format. Thank you.
****************************************************************************
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ASoC: rockchips: fix build error
@ 2014-07-12 0:59 ` Jianqun
0 siblings, 0 replies; 6+ messages in thread
From: Jianqun @ 2014-07-12 0:59 UTC (permalink / raw)
To: linux-arm-kernel
On 2014?07?11? 21:48, Mark Brown wrote:
> On Fri, Jul 11, 2014 at 03:07:08PM +0200, Arnd Bergmann wrote:
>> The newly added rockchip_i2s driver is lacking an include of
>> linux/module.h, causing a build error in some cases:
>
> A fix for this has already been applied.
>
Thank you very much :), it's great help for a begainner.
--
-------------
? ? ? Jay
Rockchip Electronics Co.Ltd
****************************************************************************
*IMPORTANT NOTICE:*This email is from Fuzhou Rockchip Electronics Co.,
Ltd .The contents of this email and any attachments may contain
information that is privileged, confidential and/or exempt from
disclosure under applicable law and relevant NDA. If you are not the
intended recipient, you are hereby notified that any disclosure,
copying, distribution, or use of the information is STRICTLY PROHIBITED.
Please immediately contact the sender as soon as possible and destroy
the material in its entirety in any format. Thank you.
****************************************************************************
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-07-12 0:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-11 13:07 [PATCH] ASoC: rockchips: fix build error Arnd Bergmann
2014-07-11 13:07 ` Arnd Bergmann
2014-07-11 13:48 ` Mark Brown
2014-07-11 13:48 ` Mark Brown
2014-07-12 0:59 ` Jianqun
2014-07-12 0:59 ` Jianqun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.