From: Daniel Borkmann <dborkman@redhat.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Christoph Schulz <develop@kristov.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-ppp@vger.kernel.org, paulus@samba.org, isdn@linux-pingi.de
Subject: Re: [PATCH net-next] net: ppp: don't call sk_chk_filter twice
Date: Sat, 12 Jul 2014 10:23:06 +0000 [thread overview]
Message-ID: <53C10C8A.70706@redhat.com> (raw)
In-Reply-To: <CAADnVQLQR9fYVGfxfnwpirXt4CwBUzr36tJL+aEoo0err7cppw@mail.gmail.com>
On 07/12/2014 05:59 AM, Alexei Starovoitov wrote:
> On Fri, Jul 11, 2014 at 9:10 AM, Christoph Schulz <develop@kristov.de> wrote:
>> From: Christoph Schulz <develop@kristov.de>
>>
>> Commit 568f194e8bd16c353ad50f9ab95d98b20578a39d ("net: ppp: use
>> sk_unattached_filter api") causes sk_chk_filter() to be called twice when
>> setting a pass or active filter. The first call is from within get_filter().
>> The second one is through the call chain
>>
>> ppp_ioctl() --> sk_unattached_filter_create()
>> --> __sk_prepare_filter()
>> --> sk_chk_filter()
>>
>> However, sk_chk_filter() is not idempotent as it sometimes replaces filter
>> codes. So running it a second time over the same filter does not work and
>
> It's a good thing not to call sk_chk_filter() twice, but the commit
> log is incorrect.
> sk_chk_filter() doesn't replace filter codes anymore.
Exactly.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Christoph Schulz <develop@kristov.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-ppp@vger.kernel.org, paulus@samba.org, isdn@linux-pingi.de
Subject: Re: [PATCH net-next] net: ppp: don't call sk_chk_filter twice
Date: Sat, 12 Jul 2014 12:23:06 +0200 [thread overview]
Message-ID: <53C10C8A.70706@redhat.com> (raw)
In-Reply-To: <CAADnVQLQR9fYVGfxfnwpirXt4CwBUzr36tJL+aEoo0err7cppw@mail.gmail.com>
On 07/12/2014 05:59 AM, Alexei Starovoitov wrote:
> On Fri, Jul 11, 2014 at 9:10 AM, Christoph Schulz <develop@kristov.de> wrote:
>> From: Christoph Schulz <develop@kristov.de>
>>
>> Commit 568f194e8bd16c353ad50f9ab95d98b20578a39d ("net: ppp: use
>> sk_unattached_filter api") causes sk_chk_filter() to be called twice when
>> setting a pass or active filter. The first call is from within get_filter().
>> The second one is through the call chain
>>
>> ppp_ioctl() --> sk_unattached_filter_create()
>> --> __sk_prepare_filter()
>> --> sk_chk_filter()
>>
>> However, sk_chk_filter() is not idempotent as it sometimes replaces filter
>> codes. So running it a second time over the same filter does not work and
>
> It's a good thing not to call sk_chk_filter() twice, but the commit
> log is incorrect.
> sk_chk_filter() doesn't replace filter codes anymore.
Exactly.
next prev parent reply other threads:[~2014-07-12 10:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 7:10 [PATCH net-next] net: ppp: don't call sk_chk_filter twice Christoph Schulz
2014-07-11 7:10 ` Christoph Schulz
2014-07-12 3:59 ` Alexei Starovoitov
2014-07-12 3:59 ` Alexei Starovoitov
2014-07-12 10:23 ` Daniel Borkmann [this message]
2014-07-12 10:23 ` Daniel Borkmann
2014-07-12 13:49 ` [PATCH net-next] net: filter: sk_chk_filter() no longer mangles filter Eric Dumazet
2014-07-12 13:49 ` Eric Dumazet
2014-07-12 15:23 ` Daniel Borkmann
2014-07-12 15:23 ` Daniel Borkmann
2014-07-13 1:29 ` Alexei Starovoitov
2014-07-13 1:29 ` Alexei Starovoitov
2014-07-14 6:28 ` David Miller
2014-07-14 6:28 ` David Miller
2014-07-12 21:11 ` [PATCH net-next] net: ppp: don't call sk_chk_filter twice Christoph Schulz
2014-07-12 21:11 ` Christoph Schulz
2014-07-13 1:44 ` Alexei Starovoitov
2014-07-13 1:44 ` Alexei Starovoitov
2014-07-13 7:03 ` Christoph Schulz
2014-07-13 7:03 ` Christoph Schulz
2014-07-13 10:27 ` Daniel Borkmann
2014-07-13 10:27 ` Daniel Borkmann
2014-07-13 13:06 ` Christoph Schulz
2014-07-13 13:06 ` Christoph Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C10C8A.70706@redhat.com \
--to=dborkman@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=develop@kristov.de \
--cc=isdn@linux-pingi.de \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.