From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Kukjin Kim <kgene.kim@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
t.figa@samsung.com, Maurus Cuelenaere <mcuelenaere@gmail.com>,
lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ASoC: s3c64xx/smartq: use dynamic registration
Date: Sun, 13 Jul 2014 15:36:52 +0200 [thread overview]
Message-ID: <53C28B74.6010401@metafoo.de> (raw)
In-Reply-To: <20140712194903.GB6800@sirena.org.uk>
On 07/12/2014 09:49 PM, Mark Brown wrote:
> On Sat, Jul 12, 2014 at 05:27:59PM +0200, Lars-Peter Clausen wrote:
>> On 07/11/2014 03:45 PM, Arnd Bergmann wrote:
>
>>> As a prerequisite for moving s3c64xx into multiplatform configurations,
>>> we need to change the smartq audio driver to stop using hardcoded
>>> gpio numbers from the header file, and instead pass the gpio data
>>> through platform_data.
>
>> This should be using the gpiod API. The gpiod API allows you to pass the
>> GPIOs without having to add a platform_data struct.
>
> OTOH that's a more invasive change that's harder to do mechanically -
> I'm not sure it's sensible to insist on someone doing it for generic
> cleanups (rather than actively working with the particular platform).
I don't think it is more invasive than using platform data. I did the same
recently for jz4740 qi-lb60[1] and the changes in the patch are fairly trivial.
The non-descriptor API is deprecated, so this even if this patch is applied as
is sooner or later somebody will mechanically convert it to the descriptor API.
- Lars
[1]
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit?id=218e18a3728507ee82ed2eb10c789671a00e34bd
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 2/4] ASoC: s3c64xx/smartq: use dynamic registration
Date: Sun, 13 Jul 2014 15:36:52 +0200 [thread overview]
Message-ID: <53C28B74.6010401@metafoo.de> (raw)
In-Reply-To: <20140712194903.GB6800@sirena.org.uk>
On 07/12/2014 09:49 PM, Mark Brown wrote:
> On Sat, Jul 12, 2014 at 05:27:59PM +0200, Lars-Peter Clausen wrote:
>> On 07/11/2014 03:45 PM, Arnd Bergmann wrote:
>
>>> As a prerequisite for moving s3c64xx into multiplatform configurations,
>>> we need to change the smartq audio driver to stop using hardcoded
>>> gpio numbers from the header file, and instead pass the gpio data
>>> through platform_data.
>
>> This should be using the gpiod API. The gpiod API allows you to pass the
>> GPIOs without having to add a platform_data struct.
>
> OTOH that's a more invasive change that's harder to do mechanically -
> I'm not sure it's sensible to insist on someone doing it for generic
> cleanups (rather than actively working with the particular platform).
I don't think it is more invasive than using platform data. I did the same
recently for jz4740 qi-lb60[1] and the changes in the patch are fairly trivial.
The non-descriptor API is deprecated, so this even if this patch is applied as
is sooner or later somebody will mechanically convert it to the descriptor API.
- Lars
[1]
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit?id=218e18a3728507ee82ed2eb10c789671a00e34bd
next prev parent reply other threads:[~2014-07-13 13:37 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 13:45 [PATCH] ASoC: s3c64xx/smartq: use dynamic registration Arnd Bergmann
2014-07-11 13:45 ` Arnd Bergmann
2014-07-11 13:45 ` [PATCH 0/4] ASoC: samsung updates from arm testing Arnd Bergmann
2014-07-11 13:45 ` Arnd Bergmann
2014-07-11 13:54 ` Mark Brown
2014-07-11 13:54 ` Mark Brown
2014-07-12 12:35 ` Arnd Bergmann
2014-07-12 12:35 ` Arnd Bergmann
2014-07-11 13:45 ` [PATCH 1/4] ASoC: samsung: add explicit i2c/spi dependencies Arnd Bergmann
2014-07-11 13:45 ` Arnd Bergmann
2014-07-14 18:51 ` Mark Brown
2014-07-14 18:51 ` Mark Brown
2014-07-11 13:45 ` [PATCH 2/4] ASoC: s3c64xx/smartq: use dynamic registration Arnd Bergmann
2014-07-11 13:45 ` Arnd Bergmann
2014-07-12 15:27 ` Lars-Peter Clausen
2014-07-12 15:27 ` [alsa-devel] " Lars-Peter Clausen
2014-07-12 19:49 ` Mark Brown
2014-07-12 19:49 ` [alsa-devel] " Mark Brown
2014-07-13 13:36 ` Lars-Peter Clausen [this message]
2014-07-13 13:36 ` Lars-Peter Clausen
2014-07-14 12:15 ` Arnd Bergmann
2014-07-14 12:15 ` [alsa-devel] " Arnd Bergmann
2014-07-14 12:40 ` Lars-Peter Clausen
2014-07-14 12:40 ` [alsa-devel] " Lars-Peter Clausen
2014-07-14 15:46 ` Arnd Bergmann
2014-07-14 15:46 ` [alsa-devel] " Arnd Bergmann
2014-07-14 16:18 ` Lars-Peter Clausen
2014-07-14 16:18 ` [alsa-devel] " Lars-Peter Clausen
2014-07-14 18:23 ` Arnd Bergmann
2014-07-14 18:23 ` [alsa-devel] " Arnd Bergmann
2014-07-14 18:32 ` Lars-Peter Clausen
2014-07-14 18:32 ` [alsa-devel] " Lars-Peter Clausen
2014-07-14 18:36 ` Mark Brown
2014-07-14 18:36 ` [alsa-devel] " Mark Brown
2014-07-15 7:19 ` Arnd Bergmann
2014-07-15 7:19 ` Arnd Bergmann
2014-07-15 7:36 ` Alexandre Courbot
2014-07-15 7:36 ` Alexandre Courbot
2014-07-15 7:58 ` Lars-Peter Clausen
2014-07-15 7:58 ` [alsa-devel] " Lars-Peter Clausen
2014-07-15 9:14 ` Alexandre Courbot
2014-07-15 9:14 ` Alexandre Courbot
2014-07-16 3:00 ` Alexandre Courbot
2014-07-16 3:00 ` Alexandre Courbot
2014-07-16 7:12 ` Thierry Reding
2014-07-16 7:12 ` Thierry Reding
2014-07-16 7:28 ` Alexandre Courbot
2014-07-16 7:28 ` Alexandre Courbot
2014-07-16 7:51 ` Thierry Reding
2014-07-16 7:51 ` Thierry Reding
2014-07-16 8:50 ` Rob Jones
2014-07-16 8:50 ` Rob Jones
2014-07-16 11:09 ` Thierry Reding
2014-07-16 11:09 ` Thierry Reding
2014-07-23 15:20 ` Linus Walleij
2014-07-23 15:20 ` Linus Walleij
2014-07-17 4:28 ` Alexandre Courbot
2014-07-17 4:28 ` Alexandre Courbot
2014-07-17 7:44 ` Thierry Reding
2014-07-17 7:44 ` Thierry Reding
2014-07-17 8:55 ` Alexandre Courbot
2014-07-17 8:55 ` Alexandre Courbot
2014-07-17 10:17 ` Mark Brown
2014-07-17 10:17 ` Mark Brown
2014-07-17 10:41 ` Thierry Reding
2014-07-17 10:41 ` Thierry Reding
2014-07-17 10:58 ` Lars-Peter Clausen
2014-07-17 10:58 ` Lars-Peter Clausen
2014-07-17 11:05 ` Mark Brown
2014-07-17 11:05 ` Mark Brown
2014-07-21 3:36 ` Alexandre Courbot
2014-07-21 3:36 ` Alexandre Courbot
2014-07-21 10:04 ` Mark Brown
2014-07-21 10:04 ` [alsa-devel] " Mark Brown
2014-07-21 14:19 ` Alexandre Courbot
2014-07-21 14:19 ` Alexandre Courbot
2014-07-16 9:48 ` Mark Brown
2014-07-16 9:48 ` Mark Brown
2014-07-24 15:10 ` Alexandre Courbot
2014-07-24 15:10 ` Alexandre Courbot
2014-07-15 10:39 ` Mark Brown
2014-07-15 10:39 ` Mark Brown
2014-07-14 15:58 ` Mark Brown
2014-07-14 15:58 ` [alsa-devel] " Mark Brown
2014-07-11 13:45 ` [PATCH 2/4] ASoC: samsung/smartq: " Arnd Bergmann
2014-07-11 13:45 ` Arnd Bergmann
2014-07-11 13:45 ` [PATCH 3/4] ASoC: samsung: s3c24xx dmaengine follow-up Arnd Bergmann
2014-07-11 13:45 ` Arnd Bergmann
2014-07-14 18:51 ` Mark Brown
2014-07-14 18:51 ` Mark Brown
2014-07-11 13:45 ` [PATCH 4/4] ASoC: samsung: remove unused DMA data Arnd Bergmann
2014-07-11 13:45 ` Arnd Bergmann
2014-07-14 18:54 ` Mark Brown
2014-07-14 18:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C28B74.6010401@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=kgene.kim@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mcuelenaere@gmail.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.