From: Daniel Borkmann <dborkman@redhat.com>
To: Christoph Schulz <develop@kristov.de>
Cc: Varka Bhadram <varkabhadram@gmail.com>,
netdev@vger.kernel.org, linux-ppp@vger.kernel.org,
paulus@samba.org, isdn@linux-pingi.de
Subject: Re: [PATCH net 1/1] net: ppp: fix creating PPP pass and active filters
Date: Sun, 13 Jul 2014 18:51:45 +0000 [thread overview]
Message-ID: <53C2D541.8080900@redhat.com> (raw)
In-Reply-To: <20140713180735.209671xd9qjsgmo7@berry.schulz.ip-v6.eu>
On 07/13/2014 06:07 PM, Christoph Schulz wrote:
> Hello!
>
> Varka Bhadram schrieb am Sun, 13 Jul 2014 20:24:34 +0530:
>
>> checkpatch warnings on this patch
>
> Yes, I know. But could you please give me a hint how to indent this properly such that it doesn't conflict with any formatting rules I possibly don't even know about?
>
> + err = sk_unattached_filter_create(&is->pass_filter,
> + &fprog);
I think going with the first variant is just fine.
> Can I use
>
> + err = sk_unattached_filter_create(
> + &is->pass_filter, &fprog);
>
> or similar? I do not want to rename variables to fit the line into 80 characteres...
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <dborkman@redhat.com>
To: Christoph Schulz <develop@kristov.de>
Cc: Varka Bhadram <varkabhadram@gmail.com>,
netdev@vger.kernel.org, linux-ppp@vger.kernel.org,
paulus@samba.org, isdn@linux-pingi.de
Subject: Re: [PATCH net 1/1] net: ppp: fix creating PPP pass and active filters
Date: Sun, 13 Jul 2014 20:51:45 +0200 [thread overview]
Message-ID: <53C2D541.8080900@redhat.com> (raw)
In-Reply-To: <20140713180735.209671xd9qjsgmo7@berry.schulz.ip-v6.eu>
On 07/13/2014 06:07 PM, Christoph Schulz wrote:
> Hello!
>
> Varka Bhadram schrieb am Sun, 13 Jul 2014 20:24:34 +0530:
>
>> checkpatch warnings on this patch
>
> Yes, I know. But could you please give me a hint how to indent this properly such that it doesn't conflict with any formatting rules I possibly don't even know about?
>
> + err = sk_unattached_filter_create(&is->pass_filter,
> + &fprog);
I think going with the first variant is just fine.
> Can I use
>
> + err = sk_unattached_filter_create(
> + &is->pass_filter, &fprog);
>
> or similar? I do not want to rename variables to fit the line into 80 characteres...
next prev parent reply other threads:[~2014-07-13 18:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 12:59 [PATCH net 1/1] net: ppp: fix creating PPP pass and active filters Christoph Schulz
2014-07-13 12:59 ` Christoph Schulz
2014-07-13 14:54 ` Varka Bhadram
2014-07-13 14:54 ` Varka Bhadram
2014-07-13 16:07 ` Christoph Schulz
2014-07-13 16:07 ` Christoph Schulz
2014-07-13 18:51 ` Daniel Borkmann [this message]
2014-07-13 18:51 ` Daniel Borkmann
2014-07-15 4:54 ` Christoph Schulz
2014-07-15 4:54 ` Christoph Schulz
2014-07-15 5:18 ` Varka Bhadram
2014-07-15 5:30 ` Varka Bhadram
2014-07-15 6:35 ` Christoph Schulz
2014-07-15 6:35 ` Christoph Schulz
2014-07-15 6:59 ` Daniel Borkmann
2014-07-15 6:59 ` Daniel Borkmann
2014-07-15 15:38 ` Alexei Starovoitov
2014-07-15 15:38 ` Alexei Starovoitov
2014-07-16 18:47 ` Christoph Schulz
2014-07-16 18:47 ` Christoph Schulz
2014-07-16 19:40 ` David Miller
2014-07-16 19:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C2D541.8080900@redhat.com \
--to=dborkman@redhat.com \
--cc=develop@kristov.de \
--cc=isdn@linux-pingi.de \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.