Re: [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
	jasowang@redhat.com, apw@canonical.com,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	ohering@suse.com, jbottomley@parallels.com,
	linux-scsi@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host
Date: Mon, 14 Jul 2014 10:57:53 +0200	[thread overview]
Message-ID: <53C39B91.4010000@suse.de> (raw)
In-Reply-To: <20140714083047.GB22715@infradead.org>

On 07/14/2014 10:30 AM, Christoph Hellwig wrote:
> On Mon, Jul 14, 2014 at 08:15:17AM +0200, Hannes Reinecke wrote:
>> Limiting max_lun to 255 will make the driver to _not_ respond to LUNs higher
>> than that; ie Well-known LUN won't work here.
>> Also the SCSI stack will be using REPORT LUNS anyway since you're
>> advertising SPC-2 compliance. So your driver runs into issues if Hyper-V
>> would ever return more than 256 LUNs with the REPORT LUN command or if any
>> of the LUNs has an addressing scheme other than
>> '0x00'.
>> I would suggest to raise this to the technical limit (ie the largest LUN
>> which the _protocol_ supports) and let REPORT LUNS deal with the actual
>> LUNs.
>
> I suspect hypverv doesn't support anything more.  For now I'd be
> inclined to just put it in ASAP and if your suggestion works out fix it
> up later, although I'll wait a bit for more review feedback.
>
Okay, that's fine by me.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)

WARNING: multiple messages have this Message-ID (diff)

From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
	jasowang@redhat.com, apw@canonical.com,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	ohering@suse.com, jbottomley@parallels.com,
	linux-scsi@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host
Date: Mon, 14 Jul 2014 10:57:53 +0200	[thread overview]
Message-ID: <53C39B91.4010000@suse.de> (raw)
In-Reply-To: <20140714083047.GB22715@infradead.org>

On 07/14/2014 10:30 AM, Christoph Hellwig wrote:
> On Mon, Jul 14, 2014 at 08:15:17AM +0200, Hannes Reinecke wrote:
>> Limiting max_lun to 255 will make the driver to _not_ respond to LUNs higher
>> than that; ie Well-known LUN won't work here.
>> Also the SCSI stack will be using REPORT LUNS anyway since you're
>> advertising SPC-2 compliance. So your driver runs into issues if Hyper-V
>> would ever return more than 256 LUNs with the REPORT LUN command or if any
>> of the LUNs has an addressing scheme other than
>> '0x00'.
>> I would suggest to raise this to the technical limit (ie the largest LUN
>> which the _protocol_ supports) and let REPORT LUNS deal with the actual
>> LUNs.
>
> I suspect hypverv doesn't support anything more.  For now I'd be
> inclined to just put it in ASAP and if your suggestion works out fix it
> up later, although I'll wait a bit for more review feedback.
>
Okay, that's fine by me.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nï¿½rnberg
GF: J. Hawn, J. Guild, F. Imendï¿½rffer, HRB 16746 (AG Nï¿½rnberg)

next prev parent reply	other threads:[~2014-07-14  8:57 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-12 16:48 [PATCH V3 0/7] Drivers: scsi: storvsc: Bug fixes and improvements K. Y. Srinivasan
2014-07-12 16:48 ` K. Y. Srinivasan
2014-07-12 16:48 ` [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host K. Y. Srinivasan
2014-07-12 16:48   ` K. Y. Srinivasan
2014-07-12 16:48   ` [PATCH V3 2/7] Drivers: scsi: storvsc: Set cmd_per_lun to reflect value supported by the Host K. Y. Srinivasan
2014-07-12 16:48     ` K. Y. Srinivasan
2014-07-14  6:15     ` Hannes Reinecke
2014-07-14  6:15       ` Hannes Reinecke
2014-07-12 16:48   ` [PATCH V3 3/7] Drivers: scsi: storvsc: Filter commands based on the storage protocol version K. Y. Srinivasan
2014-07-12 16:48     ` K. Y. Srinivasan
2014-07-14  6:16     ` Hannes Reinecke
2014-07-14  6:16       ` Hannes Reinecke
2014-07-12 16:48   ` [PATCH V3 4/7] Drivers: scsi: storvsc: Fix a bug in handling VMBUS " K. Y. Srinivasan
2014-07-12 16:48     ` K. Y. Srinivasan
2014-07-14  6:16     ` Hannes Reinecke
2014-07-14  6:16       ` Hannes Reinecke
2014-07-12 16:48   ` [PATCH 5/7] Drivers: scsi: storvsc: Implement a timedout handler K. Y. Srinivasan
2014-07-12 16:48     ` K. Y. Srinivasan
2014-07-14  6:16     ` Hannes Reinecke
2014-07-14  6:16       ` Hannes Reinecke
2014-07-12 16:48   ` [PATCH 6/7] drivers: scsi: storvsc: Set srb_flags in all cases K. Y. Srinivasan
2014-07-12 16:48     ` K. Y. Srinivasan
2014-07-14  6:17     ` Hannes Reinecke
2014-07-14  6:17       ` Hannes Reinecke
2014-07-12 16:48   ` [PATCH 7/7] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure K. Y. Srinivasan
2014-07-12 16:48     ` K. Y. Srinivasan
2014-07-14  6:17     ` Hannes Reinecke
2014-07-14  6:17       ` Hannes Reinecke
2014-07-14  6:15   ` [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host Hannes Reinecke
2014-07-14  6:15     ` Hannes Reinecke
2014-07-14  8:30     ` Christoph Hellwig
2014-07-14  8:57       ` Hannes Reinecke [this message]
2014-07-14  8:57         ` Hannes Reinecke
2014-07-14  9:00         ` Christoph Hellwig
2014-07-14  9:01           ` Hannes Reinecke
2014-07-14  9:01             ` Hannes Reinecke
2014-07-16 17:26         ` KY Srinivasan
2014-07-16 17:26           ` KY Srinivasan
2014-07-16 17:26           ` KY Srinivasan
2014-07-16 17:28           ` Christoph Hellwig
2014-07-16 17:30             ` KY Srinivasan
2014-07-13  9:51 ` [PATCH V3 0/7] Drivers: scsi: storvsc: Bug fixes and improvements Christoph Hellwig
2014-07-13 18:37   ` KY Srinivasan
2014-07-13 18:37     ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C39B91.4010000@suse.de \
    --to=hare@suse.de \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=hch@infradead.org \
    --cc=jasowang@redhat.com \
    --cc=jbottomley@parallels.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=ohering@suse.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.