Re: [PATCH v3] efi: Request desired alignment via the PE/COFF headers

[Michael Brown <mbrown-OViyBiuKJBuK421+ScFKDQ@public.gmane.org>]

On 14/07/14 14:10, Matt Fleming wrote:
> On Fri, 11 Jul, at 04:16:30PM, Michael Brown wrote:
> The EFI boot stub goes to great pains to relocate the kernel image to
> an appropriately aligned address, as indicated by the ->kernel_alignment
> field in the bzImage header.  However, for the PE stub entry case, we
> can request that the EFI PE/COFF loader do the work for us.
>
> Fix by exposing the desired alignment via the SectionAlignment field
> in the PE/COFF headers.  Despite its name, this field provides an
> overall alignment requirement for the loaded file.  (Naturally, the
> FileAlignment field describes the alignment for individual sections.)
>
> There is no way in the PE/COFF headers to express the concept of
> min_alignment; we therefore do not expose the minimum (as opposed to
> preferred) alignment.
>
> Signed-off-by: Michael Brown <mbrown-OViyBiuKJBuK421+ScFKDQ@public.gmane.org>
> Signed-off-by: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Looks good to me.

Michael