Re: [PATCH v3] efi: Request desired alignment via the PE/COFF headers

[Michael Brown <mbrown-OViyBiuKJBuK421+ScFKDQ@public.gmane.org>]

On 19/06/15 13:21, Matt Fleming wrote:
>> If the patch is reverted, then I think it will cause undefined
>> behaviour on some platforms (which happen to load the kernel to
>> non-preferred alignment, and where the memory immediately after the
>> loaded kernel happens to be in use for something).
>
> I thought that we had previously established that this wasn't true?
>
> <snip>
>
> To which I replied with,
>
>> Right, this shouldn't be a problem because we do in fact allocate space
>> using the EFI boottime services in efi_relocate_kernel(), taking the
>> alignment into account, and then perform the kernel image copy.
>>
>> I still think your change makes sense, I'm just inclined to delete the
>> paragraph referring to the corruption bug (which we've established
>> doesn't exist).
>
> Do we still have a bug?

Ah; that was the old e-mail thread I couldn't find!

You are right; this change can safely be reverted.  Sorry for the noise.

Michael